So it does have an upper limit.
numThreads is the parallelization factor, relative to the number of CPU cores
OK, so the app is probably doing a lot of blocking.
If the blocking is being done because of lots of short I/O tasks (such as Spymemcached blocking), and the blocking is happening in so many places that you can't fix them all, I would maybe recommend a CachedThreadpool : https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/Executors.html#newCachedThreadPool()
that way you don't get stuck without a thread, old threads get reused when possible, etc
Let me know if you want me to prep a PR for that alexandru/shade@f06dc1b.
No PR for that commit needed
Version 1.7.3 is released and syncing to Maven Central: https://github.com/alexandru/shade/blob/master/release-notes/1.7.md#version-173---may-11-2016
@/all version 1.8.0 is released: https://github.com/monix/shade/blob/master/release-notes/1.8.md
Note that the organization has changed to io.monix, along with the GitHub move to monix/shade, so in order to update your dependencies you need this:
"io.monix" %% "shade" % "1.8.0"
Hi @alexandru I'm currently using the client to store compressed data in memcached and found that the Spy client integration is not allowing setting any flags (just hard-setting 0s). Would it be possible to expose this functionality? Possibly by extending the Codec interface as
trait Codec[T] {
def serialize(value: T, flags: Int): Array[Byte]
def deserialize(data: Array[Byte], flags: Int): T
}Thanks!
What do those flags specify?
@alexandru thanks for looking into this! The flags are supposed to be just arbitrary "metadata" that describe the value stored under a given key. It's mentioned here https://github.com/memcached/memcached/blob/master/doc/protocol.txt (under the storage command description).
The shade API seems to enable this in the internals https://github.com/monix/shade/blob/master/src/main/scala/shade/memcached/internals/SpyMemcachedIntegration.scala#L208
however the public API doesn't allow setting the actual value https://github.com/monix/shade/blob/master/src/main/scala/shade/memcached/MemcachedImpl.scala#L71
yeah, that's what i was thinking
i actually have made the changes in my fork
i could create a PR if you'd like to take a look?
I’m currently toying with a refactoring, because I have the feeling that poking those internals isn’t needed anymore. It’s dirty and the whole point of accessing those internals, when I started this project, was that the
Future objects returned by SpyMemcached where not exposing some kind of addListener, but now they do.
feel free to take a look if it makes sense. happy to make any changes if needed.
need any help?
Well, this PR isn’t a small change, because I got rid of the internals we had, as they were tricky and at some point SpyMemcached started supporting listeners for completed futures, etc… so there are some interface changes and the tests we had are broken and need to be ported.