by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Stephen Shaw
    @decriptor
    I'm starting to wonder if naming it FSpot.Gtk is the big problem
    I think the best move might be to rename FSpot.Gtk to something else
    Jack
    @genterminl
    I'm likely to get to the unique stuff, as it just sounds like code cleanup. I'll dig into the addins stuff, but don't think I'll actually have time until next week anyway. Renaming sounds reasonable.
    Stephen Shaw
    @decriptor
    That was my thought
    if you can look at the unique stuff I can merge that and focus on mono-addins and resources
    I might do the renaming tonight too
    I'm defiintely open to suggestions :)
    Jack
    @genterminl
    I might always stumble onto something useful.
    Stephen Shaw
    @decriptor
    anything is welcome :)
    Jack
    @genterminl
    I have a diff for removing the few remaining unique-sharp refs - only 62 lines (git diff). I can email it to you?
    Stephen Shaw
    @decriptor
    Sure, but you are welcome to create a PR
    I can help you with the PR if you'd like
    then you get credit for it
    Jack
    @genterminl
    I only ever did that one, so I'll have to dig through old memories to set up for it. I guess the timing isn't urgent, since it's only a warning. Probably early next week.
    Stephen Shaw
    @decriptor
    The rough steps:
    1. Fork github.com/f-spot/f-spot to your personal github account
    2. Clone from your personal github account
    3. Create a branch (git checkout -b remove-unique)
    4. Commit (git commit -m "Some commit message here")
    5. Push (git push, this'll like give you a message, follow that. git --set-upstream or something)
    6. Go to github, create PR against github.com/f-spot/f-spot master
    more or less
    Jack
    @genterminl
    sounds familiar. Family commitments for the weekend, so I won't be able to concentrate enough to get it right until next week, but I'll do it then. Now to see if I can make any sense of the addins stuff.
    Stephen Shaw
    @decriptor
    I think it has to do with assembly names and string matching
    Jack
    @genterminl
    My eyes are crossed trying to follow that. However, it does let me parse the error message better. From my simplistic understanding, it looks like the xml file you referred to above sets up the extensionpoint at the path /FSpot/Sidebar and expects an extensionnode there of name SidebarPage of type FSpot.Gtk.Extensions.SidebarPageNode. The entry later in that file seems (prior to your disabled FIXME) set a SidebarPage of SidebarPageType FSpot.Widgets.MetadataDisplayPage. I really can't tell if that mismatch means anything, or if the SidebarPage simply never manages to properly register its ExtensionNode. I know that's from a very simplistic analysys, but maybe it will trigger some understanding. I also note this error was mentioned on the mailing list in 2008, but the answer was deleting some config files under ~/.gnome2/.
    Jack
    @genterminl
    @decriptor Following one of your comments from 12/12 I finally had time and replaced FSpot.Gtk with FSpot.Main in all folder names, file names, and file contents. No change to behavior and the "Extension node not found in path" error is still present. As you suggested - reading up on addins seems a next step.
    Stephen Shaw
    @decriptor
    @genterminl I've been working on a tool to "upgrade"/switch the database over to a new system. Once I'm completely happy with that I'll bring it over to a branch in f-spot/f-spot
    just been a bit busy lately, but hoping to get something going with that soon
    Jack
    @genterminl
    Any progress is good. Just curious about what type of database changes you intend, although I suppose I'll see them when you push to git. However, I still wont be able to test if I still can't get fspot running. I did some reading on addins, and just got myself more confused. I was trying to figure out what triggered that extension node not found error, but I realized it doesn't matter. What matters is what's NOT happening, and I haven't figured out exactly where that extension node SHOULD be getting added to the path, and then why it's failing to do so.
    Stephen Shaw
    @decriptor
    Very cool. I'm switching from using the Hyena raw sqlite interface and sql calls all over the code base to EFcore (Entity Framework). I'm setting it up so that it can convert from the current sqlite to a new sqlite database. Going forward we don't need to write manual DB migrations, etc.
    I'm going to switch out a lot of the raw sql to calls to EFcore instead
    I have a library right now that I'm testing. I was going to publish it in the f-spot repo, but right now all of the unit tests revolves around your database and I didn't want to publish your database or at the very least without your permission
    Jack
    @genterminl
    It's probably OK to include my DB in git. I don't THINK I have anything personal or confidential in it. Hold off if you see anything you think I might actually care about, but otherwise go ahead an publish it.
    Christopher Hoskin
    @mans0954
    With the release of Ubuntu 20.04 coming up, I was wondering if there was any hope of building a functioning F-Spot on it?
    Stephen Shaw
    @decriptor
    @mans0954 I'm actually sitting down to work some more no f-spot today. Not sure how much time I'll actually have, but I've been slowly redoing sections of it. I'm currently working on replacing the entire database layer.
    But, overall, I'm trying to write out all of the gnome dependencies. We'll still be stuck with gtk2 (for now), but that should hopefully be the only requirement outside of .net. That'll be the next step
    Jack Ostroff
    @ostroffjh
    That's great - any progress at all is good. Separating migration from gtk2 to either gtk3 or something else into a totally separate effort makes sense. My short term desire is just for something that compiles and runs, with minimal functionality. Additional functionality can be added back a bit at a time. Decreasing dependencies and changing underlying libraries can also split out into separate efforts. None of it helps me at all until I have something that works, at least for the basics.
    Stephen Shaw
    @decriptor
    @ostroffjh agreed. I'm making very slow progress on the database conversion, but it is progressing. I think I'm slowly getting closer to something that compiles
    Stephen Shaw
    @decriptor
    It is in very very bad shape, but I finally got the database-conversion branch to at least compile :)
    Some of my migration script stuff needs some more verification work.
    Once I get that figured out a bit more I'll need to just try and run it and see how bad things are. Then slowly fix and re-enable things :)
    Jack Ostroff
    @ostroffjh
    Let me know if there is anything I can help with - although I'm not sure what state the dotnet stuff is on my various PCs and VBox instances.
    Stephen Shaw
    @decriptor
    @ostroffjh I finally got it compiling, but it is in very bad shape
    It still requires mono. I won't be able to use dotnet any time sure because of gtk#
    If you grab the database-conversion branch you can try and play with that
    the FSpot.Console app can try and convert your old database file, but I'd HIGHLY HIGHLY HIGHLY recommend backing up everything!!!! :)
    Stephen Shaw
    @decriptor
    image.png
    I got something to show up! :)
    Jack Ostroff
    @ostroffjh
    Good news. I'll try to find time to test soon. I didn't think getting rid of mono was a short-term goal, although I agree it's a good direction.
    Jack Ostroff
    @ostroffjh
    Trying in my Ubuntu 18.04, and getting Hyena.Downloader/DownloadManagerJob.cs(33,7): error CS0246: The type or namespace name 'Mono' could not be found for several of the Hyena subdirs. Is this something about cleaning/updating/? subprojects?
    Stephen Shaw
    @decriptor
    @ostroffjh this isn't about getting rid of mono so much as it is about replacing code with other .net libraries. Ideally, I'd like to switch to .net core which still isn't necessarily getting rid of mono. One hold up is gtk# currently
    my main focus was getting rid of gnome dependencies and using more .net standardish things such as efcore instead of a manually bound sqlite library
    Bruno B. de Souza
    @knuxbbs

    @ostroffjh this isn't about getting rid of mono so much as it is about replacing code with other .net libraries. Ideally, I'd like to switch to .net core which still isn't necessarily getting rid of mono. One hold up is gtk# currently

    @decriptor , have you taken a look on https://github.com/GtkSharp/GtkSharp ?

    Stephen Shaw
    @decriptor
    @knuxbbs I have sort of. I want to get some of the code cleaned up before trying to bring back the port to gtk# 3
    I'm also working on a new tool so that we can bind any gir file on the fly