by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 07 2019 17:29
    @directhex banned @CharlieIsHere
  • Oct 11 2018 17:23
    @directhex banned @deleteaccount1234567890
Jason Millard
@jsm174
I tried setx from command line, and "Edit the system environment variables" from start menu. it doesn't look like unity is respecting them. Need to figure out the command that the hub launches it with.
Katelyn Gadd
@kg
if you're changing system wide env vars on windows, you need to kill anything that was already running and then launch it from a new cmd (or log out / back in) to ensure it gets the new system wide vars
Jay Krell
@jaykrell

You rarely need machine-wide environment variables.
Maybe though for UAP?
Otherwise, just launch whatever from the command line.
UAP is launched differently, granted.
It is set, not setenv. There is no export, it is the default and sort of only (bad).
There is setlocal, but that's just for in .cmd files (which you should avoid writing, horrible language).

You can also use gflags to set foo.exe for given foo to launch under a debugger. Can be handy.

Neale Ferguson
@nealef
make dist doesn't seem to include eventpipe in the creation of the dist tarball.
Alexander Köplinger
@akoeplinger
that sounds like something we should fix :smile:
do you want to send a PR?
Neale Ferguson
@nealef
I am trying to see what needs to be done. At the moment it only has a basically empty Makefile. It needs destdir: defined which is usually in Makefile.in. So I guess it would need a Makefile.am as well to be standard. This has implications as to the rest of the config process.
Alexander Köplinger
@akoeplinger
yeah so afaik we only support eventpipe in dotnet/runtime so mono/mono has just a stub
are you actually trying to include the eventpipe source?
if the tarball based build actually fails due to a missing mono/eventpipe/Makefile then I think adding the folder to DIST_SUBDIRS here should fix it: https://github.com/mono/mono/blob/master/mono/Makefile.am#L45
Neale Ferguson
@nealef
I do a make dist then use the tarball as input to rpmbuild. When it then tries to build using that then it complains that eventpipe is missing.
Alexander Köplinger
@akoeplinger
ok yeah then I think it's just missing the stub Makefile
Neale Ferguson
@nealef
I added the file to DIST_SUBDIRS but it breaks during the make dist as it is looking for the destdir: target.
Alexander Köplinger
@akoeplinger
ok, then add an empty dist: to the Makefile
Neale Ferguson
@nealef
This seems to do the trick (eventpipe/Makefile):
# empty placeholder for build
DISTFILES = Makefile
top_srcdir = ../..
srcdir = .

distdir:  $(DISTFILES)
    @srcdirstrip=`echo "$(srcdir)" | sed 's/[].[^$$\\*]/\\\\&/g'`; \
    topsrcdirstrip=`echo "$(top_srcdir)" | sed 's/[].[^$$\\*]/\\\\&/g'`; \
    list='$(DISTFILES)'; \
      dist_files=`for file in $$list; do echo $$file; done | \
      sed -e "s|^$$srcdirstrip/||;t" \
          -e "s|^$$topsrcdirstrip/|$(top_builddir)/|;t"`; \
    case $$dist_files in \
      */*) $(MKDIR_P) `echo "$$dist_files" | \
               sed '/\//!d;s|^|$(distdir)/|;s,/[^/]*$$,,' | \
               sort -u` ;; \
    esac; \
    for file in $$dist_files; do \
      if test -f $$file || test -d $$file; then d=.; else d=$(srcdir); fi; \
      if test -d $$d/$$file; then \
        dir=`echo "/$$file" | sed -e 's,/[^/]*$$,,'`; \
        if test -d "$(distdir)/$$file"; then \
          find "$(distdir)/$$file" -type d ! -perm -700 -exec chmod u+rwx {} \;; \
        fi; \
        if test -d $(srcdir)/$$file && test $$d != $(srcdir); then \
          cp -fpR $(srcdir)/$$file "$(distdir)$$dir" || exit 1; \
          find "$(distdir)/$$file" -type d ! -perm -700 -exec chmod u+rwx {} \;; \
        fi; \
        cp -fpR $$d/$$file "$(distdir)$$dir" || exit 1; \
      else \
        test -f "$(distdir)/$$file" \
        || cp -p $$d/$$file "$(distdir)/$$file" \
        || exit 1; \
      fi; \
    done
Alexander Köplinger
@akoeplinger
hm sounds a bit complicated, why doesn't an empty distdir and distclean target work?
Neale Ferguson
@nealef
It is just a cut and paste of other Makefile.in contents. It is obviously overkill but I just wanted to do the rpmbuild
It needs to add the Makefile to the dist tarball doesn't it?
Alexander Köplinger
@akoeplinger
so add the mono/eventpipe/Makefile in the root Makefile.am and then add emtpy distdir and distclean targets
Neale Ferguson
@nealef
Yep, looks much simpler
Neale Ferguson
@nealef
Just testing it now and will generate PR if all is ok. I did note this other problem tar: mono-6.13.0/external/llvm-project/lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/breakpoints_delayed_breakpoint_one_watchpoint/TestConcurrentBreakpointsDelayedBreakpointOneWatchpoint.py: file name is too long (cannot be split); not dumped
Neale Ferguson
@nealef
PR #20079 generated
Alexander Köplinger
@akoeplinger
yeah that file name thing should be harmless since it's just an llvm test
Jason Millard
@jsm174

so I tried everything tons of different things with the env variables on Windows. Even tried a batch script:

SET MONO_LOG_LEVEL="debug"
SET MONO_LOG_MASK="all"
"C:\Program Files\Unity\Hub\Editor\2020.1.0b14\Editor\Unity.exe" -projectpath C:/vpe2/VPE2 -useHub -hubIPC -cloudEnvironment production -hubSessionId 3bbd0140-bf51-11ea-b216-cd51a9376b52

I wonder if mono on windows even supports these as I can't seem to find anything concrete via google.

On Mac, if I launch the same thing, it works perfectly.

MONO_LOG_LEVEL="debug" MONO_LOG_MASK="all" /Applications/Unity/Hub/Editor/2020.1.0b14/Unity.app/Contents/MacOS/Unity -projectpath /Users/jsm174/vpe2/vpe2 -useHub -hubIPC -cloudEnvironment production -hubSessionId 9fd94c70-bfdc-11ea-ac70-0741a2090fc5
Alexander Köplinger
@akoeplinger
it's possible that Unity changed something so these env variables aren't read on windows
maybe ask them about it?
Neale Ferguson
@nealef
@NattyNarwhal I found an endian issue with NuGet.Client that I reported to the maintainers: NuGet/Home#9547. Their fix should appear in NuGet5.8.
Calvin Buckley
@NattyNarwhal
excellent!
i need to return to this soon, been busy/without energyfor hacking on this recently, so
Phil Jaenke
@rootwyrm
yeah, you and me both, i'm miles behind and nobody seems interested in helping with all these regressions. motivation is nonexistent.
Calvin Buckley
@NattyNarwhal
oh fwiw can unwedge aix builder whenever, i cleared out its issue afaik yesrerdat but forgot to ment
Phil Jaenke
@rootwyrm
how the hell is 6.8.0.123 passing musl checks at all? all of my reproducible builds hang.
Eli Stone
@natis1_gitlab
Does anybody know if it's possible to build any of the mono 5 versions on Linux?
I regularly run into this error while trying with multiple versions and I have been unable to find any solutions on the internet: Cannot open assembly ',profile=./../../class/lib/build/csc.System.Core.dll.aotprofile': No such file or directory.
the aotprofile file exists just fine btw, but there's that weird comma there
Andres G. Aragoneses
@knocte
natis1_gitlab: what versions are you trying to build exactly? and is it from a tarball or from git?
Esme
@madewokherd
is it supposed to be possible for a native-to-managed wrapper to call an instance method with this==NULL ?
Zoltan Varga
@vargaz
on some platforms yes, but it should be avoided.
its very hard to implement.
since the native code only receives a native function pointer, and that function pointer somehow needs to obtain the this pointer.
Esme
@madewokherd
I ask because I'm debugging what looks to be a race condition, and sometimes I get this:NULL, sometimes I get crashes
so I'm interested in what circumstances would give me this:NULL
it looks like this happens while the object is being finalized
Zoltan Varga
@vargaz
also, delegates passed to native code needs to be kept alive by storing them in a static variable or something.
Esme
@madewokherd
it looks like it's stored in an instance variable, guessing that means it can get collected and then crash if called
I wonder why this seemed to work before/on other platforms
also, for some reason I can't understand, instances have a weak reference to themselves
is it OK if the static reference to the delegate is deleted while the delegate is being called? presumably the stack would hold a reference