Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 07 17:29
    @directhex banned @CharlieIsHere
  • Oct 11 2018 17:23
    @directhex banned @deleteaccount1234567890
Filip Navara
@filipnavara
great, it happens on CoreCLR too
I'll report it to Adam
Mikkel Kruse Johnsen
@mikkeljohnsen
@rootwyrm Hmm, that patch is not compatible with 6.0.0.319. Some of it is already there and other do not match with functions replaced.
Nikolay Sivov
@nsivov
@steveisok hi, could you take a look at mono/mono#16161 ? I'd be happy to improve it further if you have any comments
Steve Pfister
@steveisok
sure, thanks for pinging me.
Nikolay Sivov
@nsivov
@steveisok @akoeplinger thanks
Steve Pfister
@steveisok
np, and thank you for contributing!
Phil Jaenke
@rootwyrm
@steveisok vaguely related, any feedback/thoughts on mono/mono#16383 ?
Alexander Köplinger
@akoeplinger
I commented on it already :wink:
Phil Jaenke
@rootwyrm
<shakes fist at email>
And what's weird is... that actually is getting run on FreeBSD for sure.
Alexander Köplinger
@akoeplinger
what does Environment.OSVersion.Platform return there?
Phil Jaenke
@rootwyrm
Let me find it... I've been seeing it on the CI builder actually.
Steve Pfister
@steveisok
I think you're right, @akoeplinger
because nix should just take the id
I added @MaximLipnin to review
since he's touched the tz stuff recently :wink:
Phil Jaenke
@rootwyrm
Oh-ho, well then, I shall issue myself a pointy-hat indeed... also my notes suck :(
Here it is...
4) ConvertTime_AjustmentConvertTimeWithSourceTimeZone (MonoTests.System.TimeZoneInfoTest+ConvertTimeTests.ConvertTime_AjustmentConvertTimeWithSourceTimeZone)
   System.TimeZoneNotFoundException : The time zone ID 'US/Eastern' was not found on the local computer.
  ----> System.IO.DirectoryNotFoundException : Could not find a part of the path "/usr/share/zoneinfo/US/Eastern".
  at System.TimeZoneInfo.FindSystemTimeZoneById (System.String id) [0x00096] in /mnt/jenkins/workspace/test-mono-mainline-community/label/freebsd-12-amd64/external/corefx/src/Common/src/CoreLib/System/TimeZoneInfo.Unix.cs:726 
  at MonoTests.System.TimeZoneInfoTest+ConvertTimeTests.ConvertTime_AjustmentConvertTimeWithSourceTimeZone () [0x00000] in /mnt/jenkins/workspace/test-mono-mainline-community/label/freebsd-12-amd64/mcs/class/corlib/Test/System/TimeZoneInfoTest.cs:747 
  at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
  at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in /mnt/jenkins/workspace/test-mono-mainline-community/label/freebsd-12-amd64/mcs/class/corlib/System.Reflection/RuntimeMethodInfo.cs:395 
--DirectoryNotFoundException
  at System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode, System.IO.FileAccess access, System.IO.FileShare share, System.Int32 bufferSize, System.Boolean anonymous, System.IO.FileOptions options) [0x0015e] in /mnt/jenkins/workspace/test-mono-mainline-community/label/freebsd-12-amd64/mcs/class/corlib/System.IO/FileStream.cs:223 
  at System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode, System.IO.FileAccess access, System.IO.FileShare share, System.Int32 bufferSize) [0x00000] in /mnt/jenkins/workspace/test-mono-mainline-community/label/freebsd-12-amd64/mcs/class/corlib/System.IO/FileStream.cs:96 
  at (wrapper remoting-invoke-with-check) System.IO.FileStream..ctor(string,System.IO.FileMode,System.IO.FileAccess,System.IO.FileShare,int)
  at System.IO.File.ReadAllBytes (System.String path) [0x00000] in /mnt/jenkins/workspace/test-mono-mainline-community/label/freebsd-12-amd64/external/corefx/src/System.IO.FileSystem/src/System/IO/File.cs:338 
  at System.TimeZoneInfo.TryGetTimeZoneFromLocalMachine (System.String id, System.TimeZoneInfo& value, System.Exception& e) [0x00012] in /mnt/jenkins/workspace/test-mono-mainline-community/label/freebsd-12-amd64/external/corefx/src/Common/src/CoreLib/System/TimeZoneInfo.Unix.cs:213
I poked wrong file :(
Alexander Köplinger
@akoeplinger
that's US/Eastern, not canada :stuck_out_tongue:
but your PR shouldn't hurt anyway since we never call MapTimeZoneId with "Canada/Eastern"
oh we do, in another file
Phil Jaenke
@rootwyrm
@akoeplinger well, there's multiple failures there, yes.
Alexander Köplinger
@akoeplinger
ok. I guess the PR doesn't make sense in its current form then
Phil Jaenke
@rootwyrm
Canada/Eastern fails in FindSystemTimeZoneById
8) FindSystemTimeZoneById (MonoTests.System.TimeZoneTest.FindSystemTimeZoneById)
   System.TimeZoneNotFoundException : The time zone ID 'Canada/Eastern' was not found on the local computer.
  ----> System.IO.DirectoryNotFoundException : Could not find a part of the path "/usr/share/zoneinfo/Canada/Eastern".
  at System.TimeZoneInfo.FindSystemTimeZoneById (System.String id) [0x00096] in /mnt/jenkins/workspace/test-mono-mainline-community/label/freebsd-12-amd64/external/corefx/src/Common/src/CoreLib/System/TimeZoneInfo.Unix.cs:726 
  at MonoTests.System.TimeZoneTest.FindSystemTimeZoneById () [0x00000] in /mnt/jenkins/workspace/test-mono-mainline-community/label/freebsd-12-amd64/mcs/class/corlib/Test/System/TimeZoneTest.cs:367 
  at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
  at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in /mnt/jenkins/workspace/test-mono-mainline-community/label/freebsd-12-amd64/mcs/class/corlib/System.Reflection/RuntimeMethodInfo.cs:395 
--DirectoryNotFoundException
  at System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode, System.IO.FileAccess access, System.IO.FileShare share, System.Int32 bufferSize, System.Boolean anonymous, System.IO.FileOptions options) [0x0015e] in /mnt/jenkins/workspace/test-mono-mainline-community/label/freebsd-12-amd64/mcs/class/corlib/System.IO/FileStream.cs:223 
  at System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode, System.IO.FileAccess access, System.IO.FileShare share, System.Int32 bufferSize) [0x00000] in /mnt/jenkins/workspace/test-mono-mainline-community/label/freebsd-12-amd64/mcs/class/corlib/System.IO/FileStream.cs:96 
  at (wrapper remoting-invoke-with-check) System.IO.FileStream..ctor(string,System.IO.FileMode,System.IO.FileAccess,System.IO.FileShare,int)
  at System.IO.File.ReadAllBytes (System.String path) [0x00000] in /mnt/jenkins/workspace/test-mono-mainline-community/label/freebsd-12-amd64/external/corefx/src/System.IO.FileSystem/src/System/IO/File.cs:338 
  at System.TimeZoneInfo.TryGetTimeZoneFromLocalMachine (System.String id, System.TimeZoneInfo& value, System.Exception& e) [0x00012] in /mnt/jenkins/workspace/test-mono-mainline-community/label/freebsd-12-amd64/external/corefx/src/Common/src/CoreLib/System/TimeZoneInfo.Unix.cs:213
So yeah, I goofed, wrong TimeZoneInfo file. Lemme close the PR and fix.
Alexander Köplinger
@akoeplinger
ok. I'm fine with changing Canada/Eastern -> America/Toronto
Phil Jaenke
@rootwyrm
Probably should but that's definitely a Windows question because Microsoft has their own timezone database (TZdatabase++)
The real problem is that FreeBSD and Linux disagree extensively on valid timezones. i.e. FreeBSD does not have US/Eastern it uses EST5EDT or EST
Calvin Buckley
@NattyNarwhal
$ echo $TZ
<EST>5<EDT>,M3.2.0,M11.1.0
i think this is allowed by POSIX, but software just can't cope
Phil Jaenke
@rootwyrm
TZstandard++
(Sigh.)
Alexander Köplinger
@akoeplinger
hm then we need some freebsd-specific code in the test
Steve Pfister
@steveisok
we're going to need to change up the tests then :disappointed:
Phil Jaenke
@rootwyrm
Anyhow, FreeBSD uses /usr/share/zoneinfo/zone.tabfrom IANA basically
But yeah, definitely need to think on it a bit.. and learn some C# apparently.
Calvin Buckley
@NattyNarwhal
most OSes ship IANA's zoneinfo intact (well, AIX ships it in a weird place, but I placed a symlink on CI,, because it's hardcoded in System)
did anyone say TimeZoneInfo.cs.in :grimacing:
rootwyrm @rootwyrm cowers under a rock. Under a mountain. On the bottom of the ocean.
Nikolay Sivov
@nsivov
@akoeplinger @steveisok another one in my queue that's assigned to you both, mono/mono#16324. It's rather benign, adding attributes, and rearranging methods in compatible way, please let me know if you have any questions
Phil Jaenke
@rootwyrm
I'm going to create a issue for the TZ stuff so it's a bit more clear, I think.
Phil Jaenke
@rootwyrm
Opened mono/mono#16415 for the timezone stuff.
Phil Jaenke
@rootwyrm
@NattyNarwhal I'm gonna break all your stuff 'kay? ;)
Calvin Buckley
@NattyNarwhal
oh no
Phil Jaenke
@rootwyrm
Actually, I kinda hope it won't break anything since 7.1 + uses IANA but it's in a weird location.
Calvin Buckley
@NattyNarwhal
the CI box runs 6.1
it has IANA from BOS though
Phil Jaenke
@rootwyrm
Oh yeah... I keep forgetting about that because I keep actively suppressing my memories of 6.1.