Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 21:00

    tgiphil on master

    Fixed Discord Links (#957) * U… (compare)

  • 21:00
    tgiphil closed #957
  • 21:00
    tgiphil opened #957
  • 20:59

    tgiphil on 259-WIP

    Updated the docs Updated the docs (compare)

  • 20:41

    tgiphil on 259-WIP

    Update Readme.md Better image drawing performanc… Updates to BitTracker (#953) *… and 1 more (compare)

  • 20:20

    tgiphil on master

    Updates to BitTracker (#953) *… (compare)

  • 20:20
    tgiphil closed #953
  • 20:20
    tgiphil ready_for_review #953
  • 16:26
    tgiphil synchronize #953
  • 16:26

    tgiphil on 258-bit

    - Updates to BitTracker (compare)

  • 13:03

    charsleysa on master

    Better image drawing performanc… (compare)

  • 13:03
    charsleysa closed #951
  • 09:42
    AnErrupTion synchronize #951
  • 04:14
    tgiphil synchronize #953
  • 04:14

    tgiphil on 258-bit

    - Updates to BitTracker (compare)

  • 03:21
    tgiphil synchronize #953
  • 03:21

    tgiphil on 258-bit

    - Updates to BitTracker (compare)

  • Dec 04 17:24

    tgiphil on master

    Update Readme.md (compare)

  • Dec 04 13:22
    AnErrupTion synchronize #951
  • Dec 04 13:20
    AnErrupTion synchronize #951
ShiningLea
@AnErrupTion
and nothing seems to be thrown
Phil Garcia
@tgiphil
There is a bug in the exception handing system that I’m tracking down. It’s super rare and none of our unit test cases are trigger it. Just FYI.
Stefan Andres Charsley
@charsleysa
yea, the slice does possibly throw an index out of range exception, so it could be that
Stefan Andres Charsley
@charsleysa
also, just added a slice test locally and it runs fine
Phil Garcia
@tgiphil
I think it's related to "finally" clause or memory corruption.... but I'm not sure at all. It's extremely elusive.
Stefan Andres Charsley
@charsleysa
@AnErrupTion can you provide a reproduction for the slice issue? I can't seem to be able to recreate it
Stefan Andres Charsley
@charsleysa
I found a way to recreate the issue, which I think is the same on that @AnErrupTion is experiencing
stick the following code into the myworld demo program setup:
            var myArray = new int[3];
            fixed (int* ptr = &myArray[0])
            {
                var span1 = new System.Span<int>(ptr, 3);
                span1[1] = 42;

                var span2 = span1.Slice(1, 1);
                char a = (char)span2[1];
                Screen.Write(a);
            }
it should print * but instead causes exceptions
Stefan Andres Charsley
@charsleysa
actually, ignore that, I had a bug in my test
char a = (char)span2[1]; should actually be char a = (char)span2[0];
when fixed it works correctly
so at this point, its back to waiting for @AnErrupTion providing a reproduction
ShiningLea
@AnErrupTion
@charsleysa
int[] array = new int[10] { 4, 2, 7, 3, 6, 9, 1, 0, 2, 8 };
            fixed (int* ptr = array)
            {
                Span<int> span = new Span<int>(ptr, array.Length);
                Console.WriteLine("Created span");

                span = span.Slice(2, 4);
                Console.WriteLine("Sliced span");
            }
this will freeze at Span.Slice(); and will never show "Sliced span" in the console
but it does show "Created span"
Stefan Andres Charsley
@charsleysa
@AnErrupTion thanks for the reproduction, I'll investigate it tomorrow
One thing that I noticed is that you are overwriting the span variable, does the issue still happen if you store the slice result into a new variable?
ShiningLea
@AnErrupTion
i don't know i have to check
ShiningLea
@AnErrupTion
nope it does not work @charsleysa
Phil Garcia
@tgiphil
Yahoo! New exception code appears to be working and passing all the unit tests and demos!
Stefan Andres Charsley
@charsleysa
@tgiphil awesome!
@AnErrupTion adding the following code to myworld demo works fine for me
            int[] array = new int[10] { 4, 2, 7, 3, 6, 9, 1, 0, 2, 8 };
            fixed (int* ptr = array)
            {
                System.Span<int> span = new System.Span<int>(ptr, array.Length);
                Screen.WriteLine("Created span");

                span = span.Slice(2, 4);
                Screen.WriteLine("Sliced span");
            }
using master branch on MOSA-project, can you please confirm that the code I posted breaks for you on MOSA-project master branch?
Stefan Andres Charsley
@charsleysa
i've created a branch with the code https://github.com/charsleysa/MOSA-Project/tree/bug-demo
can you please pull that branch and reproduce the issue from that branch
Phil Garcia
@tgiphil
@charsleysa Don't accept the pull request yet. thanks.
okay --- ready now
Stefan Andres Charsley
@charsleysa
@tgiphil reviewed, just nitpicking really
nifanfa
@nifanfa
@tgiphil
how to use sse register?
Phil Garcia
@tgiphil
double and float types use them automatically
@charsleysa Thanks for the nitpicking! The last comment, I can't remember why --- so let's leave it.
ShiningLea
@AnErrupTion
huh it works
i guess it's mosa-core then
Stefan Andres Charsley
@charsleysa
Ah yes, issues from mosa-core aren't really applicable to mosa as that project is heavily customized. If you have any more issues I'd recommend testing the issue with mosa master branch first to see if it's bug with mosa or nifanfa's mosa-core
nifanfa
@nifanfa
@tgiphil
why Schedular.IdleThread seems won't be triggered?
QQ截图20210828123316.png
Phil Garcia
@tgiphil
The idle thread isn’t called when there are other threads.
nifanfa
@nifanfa
@tgiphil
how list<> work
like the capacity
how the capacity increased
Phil Garcia
@tgiphil
list<> work as you might expect. If the list needs to grow, a larger internal is created and the elements are copied to the new array
Stefan Andres Charsley
@charsleysa
@tgiphil code review complete, theres a few changes needed, I also added some comments on things that I think should change but not completely necessary
Phil Garcia
@tgiphil
@charsleysa Thanks! That was a through review. Much appreciated!
Phil Garcia
@tgiphil
All - I’m trying out Discord server for MOSA: https://discord.gg/tRNMn3npsv