mosra/magnum

Lightweight and modular C++11/C++14 graphics middleware for games and dataviz

Vladimír Vondruš

@mosra

i hit this a few times myself as well, it boils down to a conflict in template type

the signature should be arrayAppend(Array<T>&, const std::common_type<T>::type&) instead of arrayAppend(Array<T>&, const T&) and then it would work i think

Guillaume Jacquemin

@williamjcm

and i suppose arrayAppend with InPlaceInit works, right?

Yup.

Vladimír Vondruš

@mosra

i am useless today anyway, so i could as well just go and fix that

Guillaume Jacquemin

@williamjcm

Ah, I just saw you finally implemented your own Pair type. :)

Been a while since I last took a glance at the sidebar in Gitter.

Vladimír Vondruš

@mosra

and a Triple :D

Pair is there for quite a while, Triple since now

i hope i'll never need a Quadruple

mosra/corrade@34a53fa should be the fix

once the CI gods approve

Guillaume Jacquemin

@williamjcm

It'll give me an excuse to upgrade my current project's dependencies.

Vladimír Vondruš

@mosra

i guess i could do also arrayInsert() and arrayRemove() while at it

Guillaume Jacquemin

@williamjcm

I haven't updated Corrade or Magnum since I added them as submodules in early June.

At the same time, I haven't really needed any of the new stuff.

Guillaume Jacquemin

@williamjcm

i guess i could do also arrayInsert() and arrayRemove() while at it

Now that I think about it, while I won't need arrayInsert(), arrayRemove() will be useful.

While I could do std::remove_if() combined with arrayRemoveSuffix(), it's a bit too long just to remove single elements.

Jamil Halabi

@jay3d

Installing magnum on linux with vcpkg is failing

CMake Error at scripts/cmake/vcpkg_from_github.cmake:164 (message):
  Failed to parse API response from '':



  {

    "ref": "refs/heads/master",
    "node_id": "MDM6UmVmMjg2MzkwOTpyZWZzL2hlYWRzL21hc3Rlcg==",
    "url": "https://api.github.com/repos/mosra/corrade/git/refs/heads/master",
    "object": {
      "sha": "34a53fab11928765f5fb2704b5653769a20b63a5",
      "type": "commit",
      "url": "https://api.github.com/repos/mosra/corrade/git/commits/34a53fab11928765f5fb2704b5653769a20b63a5"
    }

  }



Call Stack (most recent call first):
  ports/corrade/portfile.cmake:1 (vcpkg_from_github)
  scripts/ports.cmake:140 (include)

Vladimír Vondruš

@mosra

errrrr

doesn't sound like my problem, tho

Jamil Halabi

@jay3d

Yes I think it's a problem getting head packages from vcpkg on linux

Vladimír Vondruš

@mosra

this? microsoft/vcpkg#19651

from 19th August, lol

microsoft/vcpkg#19657 seems to be a candidate for a fix and/or introducing other bugs

Vladimír Vondruš

@mosra

where is the dumpster fire emoji

Jamil Halabi

@jay3d

How to download this as a patch again :P

Ah just add .patch

Jamil Halabi

@jay3d

Nice! works

Fo Nz

@FoNz99089892_twitter

I think I encountered this same exact problem. I had a mesh, where Phong shader didn't work correctly. PART OF MESH appeared all white, but only on ES, not on Desktop. This was strange. The culprit was the model, whose local coordinates didn't match transformations in global coordinates (as I saw in Blender).

Vladimír Vondruš

@mosra

but how would that manifest only on ES?

Fo Nz

@FoNz99089892_twitter

This is how I was seeing my mesh in ES. After I fixed my mesh in Blender, it rendered correctly with Phong shader.

This mesh was downloaded from internet. Then I changed it a bit, but basically it was made by someone else.

but how would that manifest only on ES?

I really don't know...

When I say ES, I mean OpenGL ES!!! NOT EcmaScript!!!!

Vladimír Vondruš

@mosra

yeah i get you ;)

no idea, the only possibility is something related to floating point, a NaN that propagates differently on mobile drivers, or an (ES-specific) shader precision causing normals to explode?

if you have the original model and can share it, i'll investigate, this is interesting

Fo Nz

@FoNz99089892_twitter

no idea, the only possibility is something related to floating point, a NaN that propagates differently on mobile drivers, or an (ES-specific) shader precision causing normals to explode?

That's the first thing that comes in mind, indeed.

safe.glb

if you have the original model and can share it, i'll investigate, this is interesting

This above is the indicted model

Guillaume Jacquemin

@williamjcm

Might be more of a general C++ question, but what would be the best way to add a variable's byte representation to an Array<char> ? Appending an ArrayView that wraps over a pointer to that variable ?

Vladimír Vondruš

@mosra

sideways question: what do you want to achieve, exactly?

Guillaume Jacquemin

@williamjcm

Basically, serialise data to an array before writing it to a file.

Vladimír Vondruš

@mosra

if you need to preserve alignment of the type for reading it later, then ArrayTuple might be the answer, but you can't grow that one

but appending an arrayview is a solution too, yep

Guillaume Jacquemin

@williamjcm

Okay, got it.

Guillaume Jacquemin

@williamjcm

The reason I'm asking for that is because I'm working with a third-party data serialisation format (Unreal Engine 4 save files, to be exact), and I need to be able to count bytes written (as header for each object/value contains the value's size in bytes). According to docs, std::ftell() (yes, I use C I/O here) returns a signed long, while using an Array would allow me to use size_t instead.

Vladimír Vondruš

@mosra

yeah that makes sense

Vladimír Vondruš

@mosra

safe.glb

hmm, so i looked at this one and didn't find anything suspicious, no NaNs or inifinites or overly large normals or anything, the only weird thing was that:

the knob and handle were mistransformed in a weird way, both with assimp and tinygltf
the file used three different textures while just one of them would be enough, but i don't see how that would cause the model to appear white :D

Fo Nz

@FoNz99089892_twitter

the knob and handle were mistransformed in a weird way, both with assimp and tinygltf

I think it's the contrary: the "safe block" mesh was mistransformed, because in Blender I was seeing a pending transformation in Object mode (NOT in edit mode). Anyway, I still don't know if it was the problem which the other user had... Anyway, I am no 3D modeler. I basically encoutered this error because I downloaded this mesh from the internet, which I don't do usually.

the file used three different textures while just one of them would be enough, but i don't see how that would cause the model to appear white :D

I don't know. I simply fixed transformation from Object mode to Edit mode in Blender and shading was then correct.

Where communities thrive

People

Repo info

Activity