This is more of a test run of various features I need than making the actual game proper
the near/far range is so huge that it's beyond what can be represented in a (I assume) 24bit depth buffer, and so the cube front and back faces get assigned the same depth value, which makes the output depend on the order the GPU processes the triangles and not the actual depth
i went with
0.1f, 10000.0f and it started looking acceptable, but if you see similar artifacts later you might want to narrow it down even further
Yep, switching to 10.0f to 10000.0f seems to fix the issue completely!
Thanks for the help! Now all I have to do is figure out why the sprite transparency isn't working even when I enable blending haha
what am i doing wrong?
ah, no, actually
this is it:
GL::Renderer::enable(GL::Renderer::Feature::DepthTest);
terrain.draw(*_camera);
/* Draw sprites after the terrain, so it's obscured by it if it's behind.
But disable depth writes, so the sprites don't cut into each other */
GL::Renderer::setDepthMask(false);
sprites.draw(*_camera);
GL::Renderer::setDepthMask(true);
GL::Renderer::disable(GL::Renderer::Feature::DepthTest);
before you had sprites rendered first, and they wrote to the depth buffer so the cube wasn't rendered behind it
the
AlphaMask (and no blending, or depth ordering) works as well, but that's a purely binary operation (a pixel either is there or is not), so it looks acceptable only on sufficiently high-DPI screens and won't work for semi-transparent stuff
I'll copy and paste that change into my code
Thanks a bunch, you cut through some stubborn issues for me just like that
Yeah, again
constant, which is larger for surfaces that are smoother and more mirror-like.
I guess you can say that mirrors are not shine because they don't have any specular highlight? In my head tho it's always been like the reflection itself is just a big specular hightlight. A bit counterintuitive...
mirrors are 100% specular reflection, virtually no subsurface scattering
shininess value of
0.0f results in perfect mirror-like look
shiny surface -> small highlight
could anybody on Windows run the following and tell me if it all passes or mostly fails? it all passes for me on Linux with both Chrome and FF, but on the Windows machine I tested on it was about 40 failures and I don't know why :D
9 replies
i only wanted to fix that one ANGLE bug, but apparently there's a bottomless pit full of bugs, again
the buffer you blit from gets resized as well?
_size = size;
auto halfSize = Vector2i{ size.x() / 2, size.y() };
auto& bufferGroup = _bufferGroup[index];
// RenderBuffer Resize
bufferGroup.colorBuffer = GL::Renderbuffer{};
bufferGroup.depthStencilBuffer = GL::Renderbuffer{};
bufferGroup.colorBuffer.setStorageMultisample(GL::Renderbuffer::maxSamples(), GL::RenderbufferFormat::RGBA8, halfSize);
bufferGroup.depthStencilBuffer.setStorageMultisample(GL::Renderbuffer::maxSamples(), GL::RenderbufferFormat::Depth24Stencil8, halfSize);
// MSAA Framebuffer Resize
bufferGroup.framebufferMSAA = GL::Framebuffer{ { {}, halfSize }};
bufferGroup.framebufferMSAA
.attachRenderbuffer(GL::Framebuffer::ColorAttachment{ 0 }, bufferGroup.colorBuffer)
.attachRenderbuffer(GL::Framebuffer::BufferAttachment::DepthStencil, bufferGroup.depthStencilBuffer)
.mapForDraw({ {Shaders::PhongGL::ColorOutput, GL::Framebuffer::ColorAttachment{0}} });
bufferGroup.framebufferMSAA.setViewport({ {}, halfSize });
// camera viewport setting
_camera.reshape(size, halfSize);