mpdairy/posh

A luxuriously simple and powerful way to make front-ends with DataScript and Reagent in Clojure.

λex Vincent

@alexisvincent

Hmm. That’s clever! Thought you might have figured out a way to it with one query. Pull is a bit more complicated though..? I was wondering about an approach that constructed a filter database specifically for the query and then just saved Datoms it encountered to a set

The catch set might be too large though

Matt Parker

@mpdairy

I think with pulls all the relevant datom info is already in the result of the pull results, so you just have to traverse it and pull out everything as individual EAV datoms.

Have you looked at the Datsync project? They've been working on syncing between datomic and datascript for a while now. I don't know how it's going, but they are active at least.

Oliver Rolle

@orolle

@mpdairy Does posh have the same performance characteristics as rum + datascript? I have read that datascript causes lags in the UI when the database is large (browsers UI thread is blocked)? Is it an option to run a datascript query within a web worker?

Matt Parker

@mpdairy

@orolle Posh should be faster because it doesn't make full queries or pulls every time there is a new transaction, only when a new tx will change the result of a pull/query (this is assuming we're comparing it to a rum + raw datascript that redoes all its pulls/queries every tx). In posh, pull is more efficient than q, so you might be able to get away with a large ui if you use mostly pulls.

i'd just recommend doing some testing before you commit to using it

Oliver Rolle

@orolle

@mpdairy Thanks. I will try it out.

Álvaro Castro-Castilla

@alvatar

Hi @mpdairy, could you provide some pointers on how to use Posh with Rum, please?

Álvaro Castro-Castilla

@alvatar

Seems like this answers my question: mpdairy/posh#27

Camilo Roca

@carocad

hey @mpdairy first of all thanks for the great work that you have done with posh !! that is definitely the missing piece in reactive programming that I was looking for.
I just started working with it and got some errors using pull. I checked the source code and Cursive showed me that there are three functions used with less than their declared arguments; namely

posh.plugin-base/missing-pull-result line 20 and 22
posh.plugin-base/get-db line 127
The error that I get is this

object[TypeError TypeError: null is not an object (evaluating 'new cljs.core.Keyword(null,"conn?","conn?",167224275).cljs$core$IFn$_invoke$arity$1(dcfg).call')]
posh$plugin_base$get_db
cljs$core$IFn$_invoke$arity$5
posh$plugin_base$pull
cljs$core$IFn$_invoke$arity$4
G__10589__3
G__10589


eval code
eval@[native code]
figwheel$client$utils$eval_helper

Since I just started working with posh, I am not sure if this is a problem with my configuration or an actual bug in the implementation, so I wanted to ask you first. I am happy to submit a PR to fix that if you want.

Camilo Roca

@carocad

oh it seems that this was already solved in master: mpdairy/posh@61c951b
I dont see a new release in Clojars, though :(

Petrus Theron

@theronic

Any update on Rum support for Posh? :) Posh is the last thing keeping me on Reagent

Christopher Small

@metasoarous

@theronic I don't think anyone has done this yet, but there was a bunch of refactoring that extracted most of the stateful bits of things so that someone could add a rum plugin fairly easily. If you're interested in hacking on that, I'd be happy to point you in the right direction there.

Brian Marco

@bamarco

@theronic i also put a ticket describing what I think needs to take place to make it happen.

Matt Parker

@mpdairy

does anyone want to help me set up posh to automatically compile and do a new release to clojars whenever master changes? I tried before but I couldn't get the auth working.

Camilo Roca

@carocad

@mpdairy I have an auto deploy config with travis ci for one of my projects. I didnt setup the auto deploy myself but I think that the file is pretty self-explanatory. The only things that you would need to change are the your encripted env vars and your release config in project.clj. Links below

Matt Parker

@mpdairy

@carocad thanks! that's just what I needed

Petrus Theron

@theronic

Is there a Leiningen template for a quick blank reagent+datascript+posh project?

Brian Marco

@bamarco

Best I know of is to use lein new chestnut <app-name> -- --reagent then add the posh depency manually.

This message was deleted

eoliphan

@eoliphan

Hi, I'm trying to get re-posh working with my app, but my pretty simple req-query-sub seems to be causing an "Assert failed: (db?db)" exception. Not sure what's going on. I was pulling in the datascript conn via mount, removed that, still have the problem, and did some mucking around and determined that calling connect! without a valid conn, throws an assertion there. So it seems like as of connect! things are fine. unfortunately the stack trace isn't really helping me figure out whats going on. I tried the query with and without ':in $' to no avail

eoliphan

@eoliphan

figured it out, but not sure what the problem is. When I got rid of the pull, everything was ok. But I'm not sure why pull isn't happy. been over the DS, etc docs and it seems like it should

(reg-query-sub
  :cur-form-def
  '[:find (pull ?e [*])    
    :in $
    :where
    [_ :designer/cur-form-id ?id]
    [?e :form/id ?id]
    ])

Oliver Rolle

@orolle

Pulls all fields of an entity via (re-frame/subscribe [:subs/pull entity-id])

(re-posh/reg-pull-sub
 :subs/pull
 '[*])

Petrus Theron

@theronic

There are two problems in Reagent land I keep running into: I forget to update Form-2 component arguments, and I can't get posh to re-render things when I expect to. I want to display the entire the posh db at the bottom of my page so see what's going on. I can never remember when I should deref conn or not. Why doesn't [:code (pr-str @conn)] inside my root component re-render on every db change?

Denis Krivosheev

@denistakeda

@theronic I can be wrong but I suppose that connection is just a regular clojure atom. Reagent doesn't rerender component for regular atom, only for reagent/atom. At the same time q and pull return reagent atom and it works as expected.

Petrus Theron

@theronic

@denistakeda thanks, that probably explains it. How do I get a component to re-render on any change to conn's db?

Denis Krivosheev

@denistakeda

I don't know the easy way to do so. The first idea is to add watcher to this atom that triggers force rerendering of the root component.

But wait a little bit. Maybe somebody else has a better idea

Brian Marco

@bamarco

https://github.com/bamarco/onyx-sim/blob/master/src/cljs/onyx/sim/core.cljs using make-reaction like i do in debug-conn here will work. Haven’t really stress tested it though might just be getting lucky. If you want to be more efficient you could rig up a listen! on the conn.

Oliver Rolle

@orolle

Does posh support running the query execution in a web worker? I have small lacks in my UI and I think about putting the heavy work into workers.

Christopher Small

@metasoarous

@orolle Not at present. I did some preliminary work trying to get it working, but couldn't quite sort it out. In theory it should be possible, as long as you're not putting functions or anything weird in your db. We are looking at the possibility of putting this in datsync fwiw.

Brian Marco

@bamarco

@mpdairy @metasoarous I've got rum working for the most part with posh. I needed to understand posh internals better and this seemed like a way to kill two birds with one stone. Only thing not quite compatible is that rum derived-atoms have no :on-dispose.

Brian Marco

@bamarco

well it almost works. still something not quite right with derived-atoms updating.

Christopher Small

@metasoarous

@bamarco Awesome!

Is the remaining issue that it won't garbage collect properly/automatically?

Brian Marco

@bamarco

the :on-dispose issue is related to that. The worse problem is that make-reaction is not updating period. If you use the atoms directly it works, but not inside a derived-atom.

I fixed a small bug that was hiding the big one from me.

It may only be a problem with nil starting values. haven't tested yet because all my code in onyx-sim is re-com based and not rum compatible

I also tried using build-defc from rum, but couldn't get that to work either.

Brian Marco

@bamarco

Okay I found a fix, but now I need to test to make sure I didn't break the reagent plugin. It'll have to be tomorrow

Christopher Small

@metasoarous

Awesome man! Thanks for working on that!

Brian Marco

@bamarco

Got it tested will push to my pr after i get wifi back

Brian Marco

@bamarco

Okay. The pr is in good shape except for the comment by @alexandergunnarson. The only reason I made any changes to posh.ratom at all was because it was putting errors and warnings in my figwheel project.

Anybody know the right fn call for array? mpdairy/posh#30

Brian Marco

@bamarco

@alexandergunnarson I think I figured out the issue. The if-cljs macro may be functioning off a little bit. Testing to see if that's the problem now.

Brian Marco

@bamarco

Nope just needed to fully qualify the name cljs.core/array works

Okay rum support pr should be good to go now

Christopher Small

@metasoarous

Dope!

Brian Maddy

@bmaddy

Is there a way to do a pull-all in posh? I'm trying to write a pull-all version of this: https://github.com/denistakeda/re-posh/blob/master/src/re_posh/subs.cljc#L16
Mapping over ids with p/pull gives errors. I suspect because it returns a reaction (which I don't really understand yet).

Where communities thrive

People

Repo info

Activity