Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 02:28
    omfgitsmark commented #397
  • 02:26
    omfgitsmark commented #397
  • Aug 23 07:50
    Nicate opened #432
  • Aug 23 06:47
    harbingerofme opened #431
  • Aug 22 16:11
    staghouse assigned #271
  • Aug 22 16:11
    staghouse labeled #271
  • Aug 22 16:11
    staghouse opened #271
  • Aug 22 16:08

    staghouse on master

    untracked | fixed try/catch bre… (compare)

  • Aug 22 14:48
    staghouse labeled #269
  • Aug 22 14:48

    staghouse on master

    issue/269 | fix: spacing for my… (compare)

  • Aug 22 14:48
    staghouse closed #270
  • Aug 22 14:48
    codecov-io commented #270
  • Aug 22 14:45
    codecov-io commented #270
  • Aug 22 14:44
    staghouse opened #270
  • Aug 22 14:43

    staghouse on 269

    issue/269 | fix: spacing for my… (compare)

  • Aug 22 05:55
    staghouse commented #269
  • Aug 22 05:51
    ZeldaZach assigned #269
  • Aug 22 01:58
    csuhta commented #429
  • Aug 22 01:58
    csuhta commented #430
  • Aug 22 01:09
    tooomm edited #269
Arnau Castelltort
@drimet
Thanks!
icameron
@icameron
Zach H
@ZeldaZach
GRN added to V3 @ https://mtgjson.com/. V4 beta should be finished up tonight and I'll look at a deployment of a sort shortly!
Zach H
@ZeldaZach
The GitHub repo has changed: https://github.com/mtgjson/mtgjson4
Psithief
@Psithief
oops
Daniele
@dbottillo
hello, I have an app on the play store/apple store about magic that uses mtgjson as a source for the cards. I've noticed that there is a mention about dropping support for version 3 in favour of version 4. What would be the difference? I can't find any info on the main website
Zach H
@ZeldaZach
The beta is going live this weekend
Daniele
@dbottillo
beta of the version 4?
Zach H
@ZeldaZach
Yeah
Daniele
@dbottillo
but what would be the difference? is it about how the cards are generated?
Psithief
@Psithief
I'm not sure if @ZeldaZach is implying the changelog will be posted at that time or not.
Zach H
@ZeldaZach
We have documentation on the new format. Almost finalized
Daniele
@dbottillo
+1
Zach H
@ZeldaZach
For those who want to see our documentation for MTGJSON4, you can view it in markdown @ https://github.com/mtgjson/mtgjson4-website/tree/master/content/pages.
tooomm
@tooomm
loooking at the doc: why is there a loyalty field for token?
Zach H
@ZeldaZach
Jace
tooomm
@tooomm
ahhhh, correct :+1:
will allsets and allcards have the meta field, too?
and is there still the difference between normal and extended files?
Zach H
@ZeldaZach
Yes and no
tooomm
@tooomm
:+1:
one more question then: the meta object sais Keys are date or version. in its description.
so one can not rely on the field having always a date for example? it is one or the other, never both?
Zach H
@ZeldaZach
It’s always both
Those are the two key options
tooomm
@tooomm
ok, good. but docs should say and then?
Zach H
@ZeldaZach
Yeah probably
tooomm
@tooomm
what's the progress status on v4 so far?
Zach H
@ZeldaZach
Almost ready
tooomm
@tooomm
awesome
tooomm
@tooomm
will the old repo stay around after v4 release? like rename it to v3 and use the archive option?
Zach H
@ZeldaZach
Correct
the v4 will stay as mtgjson4 repo url until we're fully released (1/1/19)
tooomm
@tooomm
:+1:
Dashiel Nemeth
@ChainsawXIV
It would be very useful to have documentation on what's changed, specifically, to facilitate updates to our code. Any chance of that?
Zach H
@ZeldaZach
I can try
Zach H
@ZeldaZach
Hey @gwax
George Leslie-Waksman
@gwax
Whats up @ZeldaZach ?
On the topic of what to do with v3, I'd suggest doing two separate things:
1) keep it around in its own repo for archival purposes
2) tag the version in mtgjson/mtgjson and then overwrite with the contents of mtgjson/mtgjson4
This lets us keep a clone-able view of the old code AND lets us maintain continuity from 3 to 4 in the git tree
Zach H
@ZeldaZach
Hmm interesting
Was gonna archive and rename
Zach H
@ZeldaZach
We mainly use discord now to chat over gitter if you’re interested
Zach H
@ZeldaZach
Thanks for all the help
Black is interest
Interesting
George Leslie-Waksman
@gwax
I can do discord
tooomm
@tooomm
is this channel deprecated? @ZeldaZach
i realized that the webhook is not correctly working anymore
Zach H
@ZeldaZach
Hmm I’ll check it out
tooomm
@tooomm
i think that's becaues of the repo move/rename
Zach H
@ZeldaZach
True
Zach H
@ZeldaZach
Fixed
tooomm
@tooomm
Thanks! :)
Zach H
@ZeldaZach
(For those who are here for MTGJSON, feel free to join us on Discord at https://discord.gg/74GUQDE )