naturalcrit/Lobby

Trevor Buckner

@calculuschild

This may be one of the remaining causes of random memory spikes that crash our server.

Eric Scheid

@ericscheid_twitter

Yup

Gazook89

@Gazook89

since the last update, i now see this in the console:

may not be a big problem. and maybe has always been there. I was having issues with the Inspector tool in FF even after a few tries and this is the only thing I saw as a "problem"....though now I've restarted FF and not having the same inspector issues so probably just me.

Trevor Buckner

@calculuschild

That has always been there. It shouldn't make much difference (the JavaScript bundle is a little larger than it needs to be is all).

It's some setting we can change somewhere in the build script that I never prioritized figuring out.

Trevor Buckner

@calculuschild

What are people's thoughts on https://github.com/naturalcrit/homebrewery/pull/1661#pullrequestreview-769352254 ?

G.Ambatte

@G-Ambatte

Hey @calculuschild, we have received a message from Phylea, the lead mod at /u/UnearthedArcana, requesting we change our link to their subreddit.
I've recorded this in Issue #1744, and raised a PR to resolve it (#1745).

G.Ambatte

@G-Ambatte

On #1661, I believe we've got to go with what works for everyone; and when that's not possible, what works for the most people. By that criteria, box-shadow appears to be the best choice - losing text selection in the PDF is a major PITA.

Trevor Buckner

@calculuschild

In that vein then, we may need to reverse naturalcrit/homebrewery#1577 as well, since V3 currently has unselectable text.

G.Ambatte

@G-Ambatte

Oh damn, I didn't see that comment on the Undo/Redo PR until just now. I've got a bit on tonight/tomorrow but hopefully I should have enough time to figure out the last couple of things by the end of the week.

G.Ambatte

@G-Ambatte

Solbera has put out a test release of v2 of his SolberaImitation! See the reddit post about it here: https://www.reddit.com/r/homebrewery/comments/q5oxpi/solbera_imitation_v2_test/

Gazook89

@Gazook89

Is it actually possible to get to the Welcome Msg V3 page?

I was working on the FAQ and realized we have a .md file for Welcome Message v3, separate from Welcome Message (legacy), but since they are not "real" brews, don't have any metadata, and thus default to Legacy....and I can't think of any way to get to that .md file.

Trevor Buckner

@calculuschild

Yes, there is a link next to the "change to v3" toggle button. We set up the link inside the server.js file.

Gazook89

@Gazook89

ah right, forgot it was there

Trevor Buckner

@calculuschild

And we also set the renderer version (and any other metadata) in the same block of code.

So we can already access the faq via /faq. We just need to put a button or text link somewhere.

Gazook89

@Gazook89

k i'm working on adding that to welcome page now

just under the "Issues, suggestions..." heading

Trevor Buckner

@calculuschild

Cool. Sounds good.

Gazook89

@Gazook89

I'm not going to pretend like I know enough to get a dropdown working for the Report Issue navbar item, so hoping to leave that to someone else...especially since it's linked to another issue (create reusable dropdown component)

Trevor Buckner

@calculuschild

Ok. Do what you can and we'll merge it.

Gazook89

@Gazook89

k, #1676 is ready for review

Eric Scheid

@ericscheid_twitter

On #1749 .. testing out a super simple legacy /new which just contains this

- https://google.com/
- <a href="https://google.com/">Google</a>

Pellentesque vel dui sed orci faucibus iaculis. 
Suspendisse dictum magna id purus tincidunt rutrum. 
Nulla congue. 
Vivamus sit amet lorem posuere dui vulputate ornare.

... and the resulting PDF didn't have any selectable text. Doing a search in the PDF for"google" or "ellen" also gives zero results.

So, uh, that's troubling.

Eric Scheid

@ericscheid_twitter

This happens with Chrome saving as PDF, and with Chrome handing off to System Print Dialog.

Repeating in Safari though .. and the text is selectable, and the links are linked. Safari uses the System Print Dialog directly, it doesn't interpose it's own mechanism.

Chrome is being difficult here.

Where can I upload the two PDFs for your edification?

Trevor Buckner

@calculuschild

You can upload documents to GitHub on that issue by dragging and dropping into a comment. I'm not sure if gitter allows documents.

There's got to be some pattern but I have no idea what is going on.

Eric Scheid

@ericscheid_twitter

I’ll upload soon. I’ll rewrite the text to be self-explanatory.

The no selectable text is a worry. Might it also be related to the background-image-is-repeated-in-file issue?

Gazook89

@Gazook89

currently, visiting another users /user/ page shows no Published brews when there are in fact published brews. That's a new problem, right?

hang on, scratch that, i didn't think the username would be case-sensitive in this case.

Gazook89

@Gazook89

perhaps if usernames are going to be case-sensitive, the name in the upper right corner when logged in should be "Small Caps" for text style. There was a reddit post about not being able to view a friends profile, and a comment within saying similar, but I suspect it boils down to just not having the right username due to case issues.

Trevor Buckner

@calculuschild

@Gazook89 This was probably an oversight when stolksdorf first created the site. I guess we have two possible solutions. Either

We start handling everything as case-insensitive (I'm not sure if there are any conflicts in the current list of users, I could try scanning the database to check) or
We just display the names in mixed-case as you suggest.

If there are no conflicts, I think we should try to make it case-insensitive to prevent future issues. I'm not sure how likely it is but it seems like a potential security issue to allow multiple users to register under myName, mYNAME, MynamE.

Of course if it's already happened we just need to roll with it I guess.

Trevor Buckner

@calculuschild

Looks like there are a total of 3715 usernames that are duplicate by case.

But just skimming over they look pretty unique, and I haven't found any that don't share the same password hash...

Gazook89

@Gazook89

I don't know how feasible it is to make it case-insensitive going forward, and make a whitelist of those duplicate accounts? That sounds like a pain to me, but just throwing it out there

Trevor Buckner

@calculuschild

Yeah that would be a mess trying to keep a whitelist with special treatment.

Ok, so looks like the best option then is just allowing mixed-case and making sure we change the names in the display. Super annoying but it's too late now to change the existing usernames in the database.

Trevor Buckner

@calculuschild

Solbera has been updating the Drop-cap font some more. Does anybody see any glaring issues? I have it loaded in this brew: https://homebrewery.naturalcrit.com/share/UwjVT0e1cArZ

Some characters are shifted ever so slightly or resized just a touch where I was eyeballing it before.

Gazook89

@Gazook89

here is a reddit comment from me in response to a question about converting legacy docs to v3 mostly in pursuit of the better TOC. It sounded to me like it'd be a pain for this user. So I spent this evening making what is basically my first js tool, to convert legacy ToCs into v3 style ToC's but using regular divs and spans. And it provides the v3 CSS.

Sharing it so I can get my "participation award" but also in case it's useful. Going out of town for a few days tomorrow but when I come back I may spruce it up beyond just a single .html file.

Trevor Buckner

@calculuschild

@Gazook89 I factored out a "dropdown menu" component for the nav bar if you want to try your hand at building the FAQ link. You can see how to put it together in the sharePage.jsx page for example. Essentially just wrap <Nav.item>s you want inside <Nav.dropdown>. The first item will always be shown in the navbar, and any other items will show up only in the dropdown.

Trevor Buckner

@calculuschild

How are you guys doing on your hacktoberfest progress?

Trevor Buckner

@calculuschild

There are some "easy" things I can think of that could have a PR.

G.Ambatte

@G-Ambatte

I'm up to 3 at the moment... October and November are busy months at work, as we try to clear the workload so we've got capacity for the Christmas rush.

Where communities thrive

People

Repo info

Activity