Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 20:29
    calculuschild edited #1954
  • 20:28

    dependabot[bot] on npm_and_yarn

    (compare)

  • 20:28

    dependabot[bot] on npm_and_yarn

    (compare)

  • 20:28

    calculuschild on master

    Bump @babel/preset-env from 7.1… Merge pull request #2176 from n… (compare)

  • 20:28
    calculuschild closed #2176
  • 20:28

    calculuschild on master

    Bump marked from 4.0.14 to 4.0.… Merge pull request #2178 from n… (compare)

  • 20:28
    calculuschild closed #2178
  • 20:25
    calculuschild synchronize #1954
  • 20:25

    calculuschild on SwappableThemes-ReorganizeFolderStructure

    Remove redundant helper files f… (compare)

  • 20:24
    calculuschild review_requested #1954
  • 20:24
    calculuschild review_requested #1954
  • 20:24
    calculuschild review_requested #1954
  • 20:24
    calculuschild review_requested #1954
  • 20:23
    calculuschild edited #1954
  • 20:23
    calculuschild synchronize #1954
  • 20:23

    calculuschild on SwappableThemes-ReorganizeFolderStructure

    Remove redundant snippets from … (compare)

  • 20:21
    calculuschild synchronize #1954
  • 20:21
    dependabot[bot] edited #2176
  • 20:20
    calculuschild ready_for_review #1954
  • 20:20
    dependabot[bot] edited #2176
G.Ambatte
@G-Ambatte
Solbera has put out a test release of v2 of his SolberaImitation! See the reddit post about it here: https://www.reddit.com/r/homebrewery/comments/q5oxpi/solbera_imitation_v2_test/
Gazook89
@Gazook89
Is it actually possible to get to the Welcome Msg V3 page?
I was working on the FAQ and realized we have a .md file for Welcome Message v3, separate from Welcome Message (legacy), but since they are not "real" brews, don't have any metadata, and thus default to Legacy....and I can't think of any way to get to that .md file.
Trevor Buckner
@calculuschild
Yes, there is a link next to the "change to v3" toggle button. We set up the link inside the server.js file.
Gazook89
@Gazook89
ah right, forgot it was there
Trevor Buckner
@calculuschild
And we also set the renderer version (and any other metadata) in the same block of code.
So we can already access the faq via /faq. We just need to put a button or text link somewhere.
Gazook89
@Gazook89
k i'm working on adding that to welcome page now
just under the "Issues, suggestions..." heading
Trevor Buckner
@calculuschild
Cool. Sounds good.
Gazook89
@Gazook89
I'm not going to pretend like I know enough to get a dropdown working for the Report Issue navbar item, so hoping to leave that to someone else...especially since it's linked to another issue (create reusable dropdown component)
Trevor Buckner
@calculuschild
Ok. Do what you can and we'll merge it.
Gazook89
@Gazook89
k, #1676 is ready for review
Eric Scheid
@ericscheid_twitter

On #1749 .. testing out a super simple legacy /new which just contains this

- https://google.com/
- <a href="https://google.com/">Google</a>

Pellentesque vel dui sed orci faucibus iaculis. 
Suspendisse dictum magna id purus tincidunt rutrum. 
Nulla congue. 
Vivamus sit amet lorem posuere dui vulputate ornare.

... and the resulting PDF didn't have any selectable text. Doing a search in the PDF for"google" or "ellen" also gives zero results.

image.png
So, uh, that's troubling.
Eric Scheid
@ericscheid_twitter

This happens with Chrome saving as PDF, and with Chrome handing off to System Print Dialog.

Repeating in Safari though .. and the text is selectable, and the links are linked. Safari uses the System Print Dialog directly, it doesn't interpose it's own mechanism.

Chrome is being difficult here.

Where can I upload the two PDFs for your edification?
Trevor Buckner
@calculuschild
You can upload documents to GitHub on that issue by dragging and dropping into a comment. I'm not sure if gitter allows documents.
There's got to be some pattern but I have no idea what is going on.
Eric Scheid
@ericscheid_twitter
I’ll upload soon. I’ll rewrite the text to be self-explanatory.
The no selectable text is a worry. Might it also be related to the background-image-is-repeated-in-file issue?
Gazook89
@Gazook89
currently, visiting another users /user/ page shows no Published brews when there are in fact published brews. That's a new problem, right?
hang on, scratch that, i didn't think the username would be case-sensitive in this case.
Gazook89
@Gazook89
perhaps if usernames are going to be case-sensitive, the name in the upper right corner when logged in should be "Small Caps" for text style. There was a reddit post about not being able to view a friends profile, and a comment within saying similar, but I suspect it boils down to just not having the right username due to case issues.
Trevor Buckner
@calculuschild

@Gazook89 This was probably an oversight when stolksdorf first created the site. I guess we have two possible solutions. Either

  1. We start handling everything as case-insensitive (I'm not sure if there are any conflicts in the current list of users, I could try scanning the database to check) or
  2. We just display the names in mixed-case as you suggest.

If there are no conflicts, I think we should try to make it case-insensitive to prevent future issues. I'm not sure how likely it is but it seems like a potential security issue to allow multiple users to register under myName, mYNAME, MynamE.

Of course if it's already happened we just need to roll with it I guess.

Trevor Buckner
@calculuschild
Looks like there are a total of 3715 usernames that are duplicate by case.
But just skimming over they look pretty unique, and I haven't found any that don't share the same password hash...
Gazook89
@Gazook89
I don't know how feasible it is to make it case-insensitive going forward, and make a whitelist of those duplicate accounts? That sounds like a pain to me, but just throwing it out there
Trevor Buckner
@calculuschild
Yeah that would be a mess trying to keep a whitelist with special treatment.
Ok, so looks like the best option then is just allowing mixed-case and making sure we change the names in the display. Super annoying but it's too late now to change the existing usernames in the database.
Trevor Buckner
@calculuschild
Solbera has been updating the Drop-cap font some more. Does anybody see any glaring issues? I have it loaded in this brew: https://homebrewery.naturalcrit.com/share/UwjVT0e1cArZ
Some characters are shifted ever so slightly or resized just a touch where I was eyeballing it before.
Gazook89
@Gazook89

here is a reddit comment from me in response to a question about converting legacy docs to v3 mostly in pursuit of the better TOC. It sounded to me like it'd be a pain for this user. So I spent this evening making what is basically my first js tool, to convert legacy ToCs into v3 style ToC's but using regular divs and spans. And it provides the v3 CSS.

Sharing it so I can get my "participation award" but also in case it's useful. Going out of town for a few days tomorrow but when I come back I may spruce it up beyond just a single .html file.

Trevor Buckner
@calculuschild
@Gazook89 I factored out a "dropdown menu" component for the nav bar if you want to try your hand at building the FAQ link. You can see how to put it together in the sharePage.jsx page for example. Essentially just wrap <Nav.item>s you want inside <Nav.dropdown>. The first item will always be shown in the navbar, and any other items will show up only in the dropdown.
Trevor Buckner
@calculuschild
How are you guys doing on your hacktoberfest progress?
Trevor Buckner
@calculuschild
There are some "easy" things I can think of that could have a PR.
G.Ambatte
@G-Ambatte
I'm up to 3 at the moment... October and November are busy months at work, as we try to clear the workload so we've got capacity for the Christmas rush.
Doesn't help that the team has been cut and cut again over the last four or five years, so we're now handling an increasing workload with about 1/3 of the original staff. Uh, yay progress?
G.Ambatte
@G-Ambatte
I think Undo/Redo is finally working!
G.Ambatte
@G-Ambatte
Rebased to master, switched the branches on the PR, it's still working on my local install... I think it's actually ready for a final review!
G.Ambatte
@G-Ambatte
Pushed through a quick PR to close the code wrapping issue as well.
G.Ambatte
@G-Ambatte
Pushed through #1760 to (hopefully) fix the issue with the divider getting lost off the edge of the screen.
Trevor Buckner
@calculuschild
I think I got CodeMirror document swapping figured out. No more losing your place (or undo history) when swapping between tabs!
G.Ambatte
@G-Ambatte
Nice!
caesuric
@caesuric

Hey, folks. I hope this is the right place to reach out to the Homebrewery dev team. I have a tool for building PDF books from Markdown sources, and I have built some Homebrewery-related extensions for it:

  1. A style fork of Homebrewery that is compatible with print media as well as the HTML renderer we are using.
  2. A plugin to my tool that will parse the Homebrewery markdown extensions into "Markdown in HTML" extension compatible Markdown that we can parse with the tool.

I would like to open source all of the above, but I wanted to check in for the Homebrewery-specific stuff and see if that's okay with you and/or if you need any specific form of attribution besides a link and general acknowledgment.

Thanks!

Trevor Buckner
@calculuschild
@caesuric The Homebrewery is licensed using the MIT License. Which means you are free to use The Homebrewery or any parts of the codebase any way that you want, except for claiming that you made it yourself, and provided that you include a copy of the license somewhere in your project where others can see it (even as a comment in the code is fine , just so people can trace it back to us somehow).
caesuric
@caesuric
@calculuschild Awesome, thank you for the clarification. I believe I am familiar with the legal obligations of the license, I was more just checking for things you'd like/appreciate beyond the things I'm legally required to do . Feel free to let me know if doing this in any particular way would be helpful for you. :)
Trevor Buckner
@calculuschild
@caesuric You could always make a shout-out to us whenever you advertise it. Point people to our Patreon page, etc. Maybe let us know when you release it so we can check it out! But really we don't expect anything else. Depending how your project functions, we could potentially create some kind of collaboration and add your extension as an official Homebrewery component if you would be amenable to that. Lots of people are creating new CSS themes, tweaks in their own forks, etc. and occasionally we reach out and ask if we can incorporate their work into the official project. Open-source is nice when it goes both ways, if that makes sense.
caesuric
@caesuric
Absolutely will do all of that, and am open to collaboration if it's welcome and makes sense. Really appreciate all of the work that went into Homebrewery.