Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 05:32
    jeddai synchronize #1841
  • 05:05
    jeddai synchronize #1841
  • Nov 30 08:59
    G-Ambatte review_requested #1867
  • Nov 30 08:59
    G-Ambatte opened #1867
  • Nov 30 08:37
    G-Ambatte synchronize #1801
  • Nov 30 05:18
    calculuschild commented #1841
  • Nov 30 04:49
    G-Ambatte labeled #1866
  • Nov 30 04:49
    G-Ambatte labeled #1866
  • Nov 30 04:49
    G-Ambatte opened #1866
  • Nov 30 04:29
    ericscheid commented #1844
  • Nov 30 04:22
    ericscheid labeled #1844
  • Nov 30 04:22
    ericscheid commented #1844
  • Nov 30 04:20
    dependabot[bot] edited #1758
  • Nov 30 04:20
    dependabot[bot] synchronize #1860
  • Nov 30 04:20

    dependabot[bot] on npm_and_yarn

    Bump marked from 3.0.8 to 4.0.5… (compare)

  • Nov 30 04:20
    dependabot[bot] edited #1860
  • Nov 30 04:19
    dependabot[bot] edited #1860
  • Nov 30 04:19
    dependabot[bot] synchronize #1860
  • Nov 30 04:19

    dependabot[bot] on npm_and_yarn

    Bump marked from 3.0.8 to 4.0.5… (compare)

  • Nov 30 04:19
    dependabot[bot] edited #1860
caesuric
@caesuric
Thank you! I'll let you know when it becomes public. :)
Trevor Buckner
@calculuschild
Easy PR if someone still needs to fill out their Hacktoberfest quota. naturalcrit/homebrewery#1767
Just update the Dockerfile to match the version of Node in Package.json
caesuric
@caesuric
@calculuschild just made the project(s) public! You may be interested in the tweaks needed to get Homebrewery's style working with paged media without explicit page breaks, possibly.
libris (multiple MD -> PDF tool) here: https://github.com/lazy-scrivener-games/libris
Homebrewery style fork here: https://github.com/lazy-scrivener-games/homebrewery-fork-for-libris
pipe for pasting Homebrewery flavored markdown directly into libris input files here: https://github.com/lazy-scrivener-games/homebrewery-to-libris
G.Ambatte
@G-Ambatte
Oh man, Docker... It's been a while.
I should have time to a swing at it later today, if no one else wants to leap on it - I already have 4 accepted PRs for Hacktoberfest, but I'm happy to push through some more.
Trevor Buckner
@calculuschild
I'm pretty sure it's just changing a number. Should be easy.
G.Ambatte
@G-Ambatte
I'm just looking through the Docker packages for Node 16.11, and they don't seem to have one... 16.12 is there, though.
I might have to install Docker, just to confirm the changes actually work before committing a PR.
G.Ambatte
@G-Ambatte
I must have been looking in the wrong place.... Despite not being listed on the page I was looking at, setting the version in the Dockerfile to 16.11 allows it to compile and run just fine. PR coming through shortly.
G.Ambatte
@G-Ambatte
I've just opened PR #1771, which is some initial work at including CodeMirror's editor themes in Homebrewery. If I've done anything the awkward/difficult way, please let me know the simple solution!
Trevor Buckner
@calculuschild
@G-Ambatte I might recommend using a package like less-plugin-glob as a less plugin rather than shuffling around files everywhere
then you can just use @import (less) 'codemirror/theme/*'; in the codeEditor.less to import all the files.
Trevor Buckner
@calculuschild
Alternatively, do copy the cm themes over to \buildbut don't bother manually stitching them together. Instead just swap the css file in and out on the editor as needed like we do with the brew themes in https://github.com/naturalcrit/homebrewery/blob/732021f5a5ab190752eacf76a178c7b5bc256c07/client/homebrew/brewRenderer/brewRenderer.jsx#L202 .
probably the easiest and keeps the themes separated so users dont have to download every theme in a big lump, just one by one as they select them.
Trevor Buckner
@calculuschild
yeah, probably cleaner than needing more dependencies
G.Ambatte
@G-Ambatte
For some reason, I was under the impression we couldn't <link> in <body>. That'll make things much easier!
Trevor Buckner
@calculuschild
In html 4 it wasn't allowed but html 5 is fine with it, even if its not considered "best practice". It seemed to be the most straightforward way that takes advantage of React's ability to rebuilt the DOM at-will.
G.Ambatte
@G-Ambatte
Cool... This week is shaping up to be super busy but I'll see if I can squeeze in those changes.
Trevor Buckner
@calculuschild
Hey, so you guys who do Docker... this is solved, right? naturalcrit/homebrewery#198
G.Ambatte
@G-Ambatte
It worked for me after I fixed the base Node image to 16.11, so I guess?
In #206, stolksdorf explicitly states that Docker will no longer be supported.
#203 and #206 were closed without merging, as best I can tell. #206 looked like it was going to reduce the container size significantly by using the Alpine base image, rather than the standard Node image.
G.Ambatte
@G-Ambatte
I'm just testing running 16.11-alpine instead of flat 16.11, looks like it's reduced the Docker container size by about 40%.
It does appear that the Docker install is running Homebrewery using Yarn, rather than NPM. Not entirely sure what difference that makes, just an interesting point of note.
G.Ambatte
@G-Ambatte
Looks like Yarn is a better NPM, so it shouldn't be a major issue.
G.Ambatte
@G-Ambatte
I've pushed through the Docker change to 16.11-alpine as PR #1775.
G.Ambatte
@G-Ambatte
I've closed #1588 as updating the CodeMirror dependency to v5.63.3 corrected the underlying issue.
Trevor Buckner
@calculuschild
Awesome. Thanks!
Eric Scheid
@ericscheid_twitter
OK, you guys know how flex works .. is the following layout (not for HB) is at least possible?
image.png
So, a header affixed to the top of the window, the footer to the bottom, and then any number of columns in between, with excess columns available via scrolling to the right?
Eric Scheid
@ericscheid_twitter
Slept on it, found an actually useful intro to flex, coded this: https://codepen.io/ericscheid/pen/mdMwyEE .. almost exactly what I want =)
Trevor Buckner
@calculuschild
Glad you figured it out.
Sending out our latest changes live as v3.0.3 now.
Gazook89
@Gazook89
I think this should be tweaked a bit:
image.png
either no vertical black line between undo/redo and the editors, or there should be no padding between the highlight gray and the black line
Gazook89
@Gazook89
Also, there is a reddit post about certain pages not showing in Chrome's print dialog, despite showing in the preview window. Here is a Share link to a Clone for their brew. I believe it is happening because the table is too long for the page, though in the past I think it would have just run off the page and be clipped...but now it's just removing the whole table. I could be misremembering that though.
Gazook89
@Gazook89
Another thing (sorry): If I take a Legacy brew, and Clone to New, it sometimes (always?) opens in v3. Not a big deal. But further, if I don't save and click through to Get PDF the /Print/ page shows something completely different.
The print page shows a previous "new" brew where I was just testing stuff and don't think I saved.
Gazook89
@Gazook89
Finally, for now, i think my PR for the page number pseudo elements in the editor should be reverted. Something funky happens to the count as you scroll.
Trevor Buckner
@calculuschild

either no vertical black line between undo/redo and the editors, or there should be no padding between the highlight gray and the black line

The line is to differentiate between "action buttons (undo/redo/more later) vs "editor tabs". We can look at visual tweaks later but I think its important that hose are separated.

Also, there is a reddit post about certain pages not showing in Chrome's print dialog, despite showing in the preview window.

The share link prints just fine for me. It could possibly that issue where pixel differences between one or more views are shuffling things around, and maybe the PDF render is experiencing a similar thing? Not sure.

If I take a Legacy brew, and Clone to New, it sometimes (always?) opens in v3

I suspect it's opening in whatever renderer you selected last time you were in New. Clone overwrites the text and style panels but I don't think it copies over any of the metadata so it might be stuck using your old metadata. Put this in an Issue if you haven't already.

Trevor Buckner
@calculuschild

But further, if I don't save and click through to Get PDF the /Print/ page shows something completely different.
The print page shows a previous "new" brew where I was just testing stuff and don't think I saved.

Is this only if you don't edit the file at all? I think the print page just grabs whatever the latest text saved to the localStorage, and cloning a page doesn't overwrite localstorage until you start typing on it.

i think my PR for the page number pseudo elements in the editor should be reverted. Something funky happens to the count as you scroll.

Make an issue for it and we can take a look.

Trevor Buckner
@calculuschild
As for the page numbers behaving oddly, it looks like CodeMirror only holds a certain number of lines of text in the display at once, so the CSS counter is dependent on which lines are currently being shown at a given time. We probably need to just display the number with Javascript rather than relying on the CSS counter.
G.Ambatte
@G-Ambatte
Thumbnail preview in the Metadata Editor should now be working on the #1777 PR.
Charlie Humphreys
@jeddai
Hiya! Working on #629 -- I have a few dev questions. Would this be an okay place to ask them?
Trevor Buckner
@calculuschild
Yep this is a good place.