dependabot[bot] on npm_and_yarn
Bump marked from 4.0.9 to 4.0.1… (compare)
@import (less) 'codemirror/theme/*';in the
codeEditor.lessto import all the files.
\buildbut don't bother manually stitching them together. Instead just swap the css file in and out on the editor as needed like we do with the brew themes in https://github.com/naturalcrit/homebrewery/blob/732021f5a5ab190752eacf76a178c7b5bc256c07/client/homebrew/brewRenderer/brewRenderer.jsx#L202 .
either no vertical black line between undo/redo and the editors, or there should be no padding between the highlight gray and the black line
The line is to differentiate between "action buttons (undo/redo/more later) vs "editor tabs". We can look at visual tweaks later but I think its important that hose are separated.
Also, there is a reddit post about certain pages not showing in Chrome's print dialog, despite showing in the preview window.
The share link prints just fine for me. It could possibly that issue where pixel differences between one or more views are shuffling things around, and maybe the PDF render is experiencing a similar thing? Not sure.
If I take a Legacy brew, and Clone to New, it sometimes (always?) opens in v3
I suspect it's opening in whatever renderer you selected last time you were in New. Clone overwrites the text and style panels but I don't think it copies over any of the metadata so it might be stuck using your old metadata. Put this in an Issue if you haven't already.
But further, if I don't save and click through to Get PDF the /Print/ page shows something completely different.
The print page shows a previous "new" brew where I was just testing stuff and don't think I saved.
Is this only if you don't edit the file at all? I think the print page just grabs whatever the latest text saved to the localStorage, and cloning a page doesn't overwrite localstorage until you start typing on it.
i think my PR for the page number pseudo elements in the editor should be reverted. Something funky happens to the count as you scroll.
Make an issue for it and we can take a look.
npm run devseems to consistently throw an error and not start-- is that normal or is there something up with my install? Happy to elaborate if that's not expected
devscript is actually working - I've always used
node scripts/buildHomebrew.js --devinstead, which enables a watchDirectory and auto live rebuild. In theory this should probably work from a
npm run buildprompt as well, but I can't say that I've actually ever tested it.