either no vertical black line between undo/redo and the editors, or there should be no padding between the highlight gray and the black line
The line is to differentiate between "action buttons (undo/redo/more later) vs "editor tabs". We can look at visual tweaks later but I think its important that hose are separated.
Also, there is a reddit post about certain pages not showing in Chrome's print dialog, despite showing in the preview window.
The share link prints just fine for me. It could possibly that issue where pixel differences between one or more views are shuffling things around, and maybe the PDF render is experiencing a similar thing? Not sure.
If I take a Legacy brew, and Clone to New, it sometimes (always?) opens in v3
I suspect it's opening in whatever renderer you selected last time you were in New. Clone overwrites the text and style panels but I don't think it copies over any of the metadata so it might be stuck using your old metadata. Put this in an Issue if you haven't already.
But further, if I don't save and click through to Get PDF the /Print/ page shows something completely different.
The print page shows a previous "new" brew where I was just testing stuff and don't think I saved.
Is this only if you don't edit the file at all? I think the print page just grabs whatever the latest text saved to the localStorage, and cloning a page doesn't overwrite localstorage until you start typing on it.
i think my PR for the page number pseudo elements in the editor should be reverted. Something funky happens to the count as you scroll.
Make an issue for it and we can take a look.
npm run devseems to consistently throw an error and not start-- is that normal or is there something up with my install? Happy to elaborate if that's not expected
devscript is actually working - I've always used
node scripts/buildHomebrew.js --devinstead, which enables a watchDirectory and auto live rebuild. In theory this should probably work from a
npm run buildprompt as well, but I can't say that I've actually ever tested it.
re:docker: Gotcha -- so I've done a couple things that have made my workflow with it a bit easier, definitely curious of your thoughts (not sure how helpful this would be for the group)
buildHomebrew.jshas both a
--watch. With just
--devit will watch the files and update the
buildfolder as they're changed, but it doesn't start up the server.
buildfolder to the homebrewery docker image, so now when I change a file it'll pick up those changes as the
buildHomebrewscript updates the
buildfolder without needing to be restarted. Just have to refresh the browser to pick up the changes
re:linting: that's a great tip, definitely will be sure to run that!
--devoption set up to both watch files and start up a server for that very reason you mention: The server it starts will automatically pick up updates in the build folder and you only have to refresh the browser to see the changes. Since we don't normally do our dev work inside a Docker container we have never had a need to separate the livereload server out.