naturalcrit/Lobby

Eric Scheid

@ericscheid_twitter

Slept on it, found an actually useful intro to flex, coded this: https://codepen.io/ericscheid/pen/mdMwyEE .. almost exactly what I want =)

Trevor Buckner

@calculuschild

Glad you figured it out.

Sending out our latest changes live as v3.0.3 now.

Gazook89

@Gazook89

I think this should be tweaked a bit:

either no vertical black line between undo/redo and the editors, or there should be no padding between the highlight gray and the black line

Gazook89

@Gazook89

Also, there is a reddit post about certain pages not showing in Chrome's print dialog, despite showing in the preview window. Here is a Share link to a Clone for their brew. I believe it is happening because the table is too long for the page, though in the past I think it would have just run off the page and be clipped...but now it's just removing the whole table. I could be misremembering that though.

Gazook89

@Gazook89

Another thing (sorry): If I take a Legacy brew, and Clone to New, it sometimes (always?) opens in v3. Not a big deal. But further, if I don't save and click through to Get PDF the /Print/ page shows something completely different.

The print page shows a previous "new" brew where I was just testing stuff and don't think I saved.

Gazook89

@Gazook89

Finally, for now, i think my PR for the page number pseudo elements in the editor should be reverted. Something funky happens to the count as you scroll.

Trevor Buckner

@calculuschild

either no vertical black line between undo/redo and the editors, or there should be no padding between the highlight gray and the black line

The line is to differentiate between "action buttons (undo/redo/more later) vs "editor tabs". We can look at visual tweaks later but I think its important that hose are separated.

Also, there is a reddit post about certain pages not showing in Chrome's print dialog, despite showing in the preview window.

The share link prints just fine for me. It could possibly that issue where pixel differences between one or more views are shuffling things around, and maybe the PDF render is experiencing a similar thing? Not sure.

If I take a Legacy brew, and Clone to New, it sometimes (always?) opens in v3

I suspect it's opening in whatever renderer you selected last time you were in New. Clone overwrites the text and style panels but I don't think it copies over any of the metadata so it might be stuck using your old metadata. Put this in an Issue if you haven't already.

Trevor Buckner

@calculuschild

But further, if I don't save and click through to Get PDF the /Print/ page shows something completely different.
The print page shows a previous "new" brew where I was just testing stuff and don't think I saved.

Is this only if you don't edit the file at all? I think the print page just grabs whatever the latest text saved to the localStorage, and cloning a page doesn't overwrite localstorage until you start typing on it.

i think my PR for the page number pseudo elements in the editor should be reverted. Something funky happens to the count as you scroll.

Make an issue for it and we can take a look.

Trevor Buckner

@calculuschild

As for the page numbers behaving oddly, it looks like CodeMirror only holds a certain number of lines of text in the display at once, so the CSS counter is dependent on which lines are currently being shown at a given time. We probably need to just display the number with Javascript rather than relying on the CSS counter.

G.Ambatte

@G-Ambatte

Thumbnail preview in the Metadata Editor should now be working on the #1777 PR.

Charlie Humphreys

@jeddai

Hiya! Working on #629 -- I have a few dev questions. Would this be an okay place to ask them?

Trevor Buckner

@calculuschild

Yep this is a good place.

Charlie Humphreys

@jeddai

Cool! A few questions then:

npm run dev seems to consistently throw an error and not start-- is that normal or is there something up with my install? Happy to elaborate if that's not expected
the docker-compose running method is working great for me, though the homebrewery container that runs I'm guessing has some sort of prod mode enabled as console logs I added aren't popping up. Is that accurate and if so is there a way to change that?
when opening PRs do y'all prefer them to be on branches within the main project or on branches in forked repos? I didn't see anything about that in the contrib doc (I may have just missed it) and wasn't sure if y'all had a standard for that or not

G.Ambatte

@G-Ambatte

I don't know if the dev script is actually working - I've always used node scripts/buildHomebrew.js --dev instead, which enables a watchDirectory and auto live rebuild. In theory this should probably work from a npm run build prompt as well, but I can't say that I've actually ever tested it.

Charlie Humphreys

@jeddai

Ah and I can probably mount the result of that into the docker image

G.Ambatte

@G-Ambatte

Typically, I have always created PRs on branches in my own fork, then submitted them as PRs to the main project.

Charlie Humphreys

@jeddai

Cool I'll do that then!

G.Ambatte

@G-Ambatte

I starting playing with Docker a few years back , and have only just picked it back up again - as in, in the last couple of weeks - and that was to look at a specific issue for Homebrewery.
Suffice it to say, if I am the project's Docker expert, then we do not have greatest Docker support. But it is at least functional again.

Charlie Humphreys

@jeddai

Well I can definitely confirm the docker-compose config works at a base level for getting things running -- I'll happily play around with it and let you know if I find any places improvements could be made

G.Ambatte

@G-Ambatte

After we fixed the config to make it work again, we also just pushed through a change to 16.11-alpine which reduced the container size by about 40%.

Beyond that, Docker support has mostly been left alone.

G.Ambatte

@G-Ambatte

The other thing that I do is, when I'm ready to test out a new change, is to first run npm lint to make sure my code is correctly formatted, then the npm build script. It's meant a lot less follow up commits with a description of "Lint fixes".

Charlie Humphreys

@jeddai

re:docker: Gotcha -- so I've done a couple things that have made my workflow with it a bit easier, definitely curious of your thoughts (not sure how helpful this would be for the group)

I separated the watch/livereload server from the dev argument, so now the buildHomebrew.js has both a --dev and a --watch. With just --dev it will watch the files and update the build folder as they're changed, but it doesn't start up the server.
the docker compose file now bind-mounts the build folder to the homebrewery docker image, so now when I change a file it'll pick up those changes as the buildHomebrew script updates the build folder without needing to be restarted. Just have to refresh the browser to pick up the changes

re:linting: that's a great tip, definitely will be sure to run that!

Trevor Buckner

@calculuschild

@jeddai We have the --dev option set up to both watch files and start up a server for that very reason you mention: The server it starts will automatically pick up updates in the build folder and you only have to refresh the browser to see the changes. Since we don't normally do our dev work inside a Docker container we have never had a need to separate the livereload server out.

Charlie Humphreys

@jeddai

Gotcha, makes sense -- I'll switch it back then before I commit

G.Ambatte

@G-Ambatte

@calculuschild Another request for help with a password change from the subreddit: https://redd.it/qjqx0t

Trevor Buckner

@calculuschild

Got it.

Sigh... Some day I'll get some password management figured out.

G.Ambatte

@G-Ambatte

I think we need to decide which way to jump on that... We could implement a login system locally, within Homebrewery, that produces the same JWT token. I know that the original intention was the NaturalCrit could be a centralized repository of D&D tools but none of the others ever got finished or fandom like Homebrewery... It may just be a case of making the leap to have HB stand alone.

G.Ambatte

@G-Ambatte

Moving to an internal login may also give us the ability to make some minor changes... Like eliminate case sensitivity in user names, add input validation to the user name field, and add password reset confirmation password/passphrase to simplify or even automate password resets.

Eric Scheid

@ericscheid_twitter

One of the reasons password resets were never done was because storing email addresses for such would make it a target 🎯. Once we start collecting email addresses that raises all sorts of technical and legal issues.

G.Ambatte

@G-Ambatte

Precisely - GDPR becomes a thing to worry about.

Eric Scheid

@ericscheid_twitter

That said, linking an account to another service (eg. twitter or facebook) can 1. enables login via that service, and 2) provides another channel with limited spammage rights.

Does reddit provide a “log in with reddit” option?

G.Ambatte

@G-Ambatte

I don't think so... There's a post about it - https://redd.it/5oxaos - but it was more about granting access to the user's Reddit account, rather than authenticating the user against said account.

The post does recommend using OpenID instead.

Trevor Buckner

@calculuschild

We could implement a login system locally

Well, we can make those changes on Naturalcrit as well. There's nothing stopping us because I have access to both halves of the system now.

Trevor Buckner

@calculuschild

I think we've had this discussion many times before, and I think we can pull password management off without collecting any additional user info, and without forcing users to log in with social media. We wouldn't have 2-factor authentication, but as long as a user can either 1) log in currently or 2) can't log in, but can provide their username and info about private brews under the account, I feel like that should be enough to let the user change their password? If something goes wrong like they leave themselves logged in and someone maliciously changes the password, then they can still come to me and I can manually fix things. But I think that will be far less likely than users wanting to just change their own password legitimately.

Essentially automating what I have to do manually now (verify with the user their username + brew info), and shifting the need for manual intervention to only the more rare case of a malicious user happening to access the Homebrewery on the same computer as another user who happened to not log out of a public machine.

Trevor Buckner

@calculuschild

Of course that means we should have an obvious logout button finally. And possibly a pop-up when you close the page that says you should log out first if on a public machine.

Trevor Buckner

@calculuschild

Maybe also a pop-up when you log in that asks if this is a trusted machine, and if yes, we just check a box in local storage to not bug you about it again on this machine.

Eric Scheid

@ericscheid_twitter

Logging in with OpenID does provide an additional benefit - one fewer password that someone needs to remember.

Where communities thrive

People

Repo info

Activity