re:docker: Gotcha -- so I've done a couple things that have made my workflow with it a bit easier, definitely curious of your thoughts (not sure how helpful this would be for the group)
- I separated the watch/livereload server from the dev argument, so now the
buildHomebrew.jshas both a--devand a--watch. With just--devit will watch the files and update thebuildfolder as they're changed, but it doesn't start up the server. - the docker compose file now bind-mounts the
buildfolder to the homebrewery docker image, so now when I change a file it'll pick up those changes as thebuildHomebrewscript updates thebuildfolder without needing to be restarted. Just have to refresh the browser to pick up the changes
re:linting: that's a great tip, definitely will be sure to run that!
--dev option set up to both watch files and start up a server for that very reason you mention: The server it starts will automatically pick up updates in the build folder and you only have to refresh the browser to see the changes. Since we don't normally do our dev work inside a Docker container we have never had a need to separate the livereload server out.
Are you able to get a coutn of how many users there are with no linked google account?
Logging in with reddit account (if possible) and github account should be allowed, since those are the platforms in which homebrewery engages with users for reports, feature requests, updates, etc.
And if the GMB discord is any indication, I think more people are going to start moving to HB over time--- Their developer hadn't replied to messages for 6 months until last week when their SSL cert expired for a few hours and most of the active people are advising newcomers that it is abandonware.
Kind of funny since the Homebrewery is the original, then GMBinder took our source code (it is open-source so... good for them?), tweaked a few features, and then slapped a subscription model on it. Granted, we did have a lull for a year or so when the original owner was leaving the project before I joined which is what led a lot of people to switching over, but we've been pretty active lately and are seeing more traffic back this way again.
Not that we are trying to "win" anything, but it does mean people are watching our progress more these days, so more help is always welcome.
right, but I think we can likely all agree that it is a little "icky" that they don't provide support for a paid (and especially subscription-based) app. And they haven't completed their well-funded kickstarter goals. But I try not dwell on it or take a HB vs GMB mindset since I really have no horse in the race, though I do indulge in a bit of schadenfreude occasionally.
And then there is Norn--- I'm skeptical, but interested to see what happens since it is a very different approach to the same cause.
great. And in case it's mentioned, the staging site is here: https://homebrewery-stage.herokuapp.com/
I don't think there is anything in staging that isn't currently on the production site, but if there is, you'll find it here.
So I am beginning to think the way modes/addons are imported in the codeEditor.jsx isn't working properly. If I use the require method similar to the mode imports
require('codemirror/addon/fold/foldcode.js');
require('codemirror/addon/fold/foldgutter.js');the fold gutter shows up (since that's all CSS), but there are never any fold buttons inside it and the extensions that should exist don't. If I copy the contents of the IIFEs in those two files and paste them into the codeEditor.jsx where I'm importing them it works as expected. The IIFE at the top of the codemirror js files has some logic to determine whether it should use a new instance of codemirror or use one that already exists, and I confirmed via debugging that it's entering into the first if block here (the one commented with CommonJS), and not the last one which I think would be expected:
(function(mod) {
if (typeof exports == "object" && typeof module == "object") // CommonJS
mod(require("../../lib/codemirror"));
else if (typeof define == "function" && define.amd) // AMD
define(["../../lib/codemirror"], mod);
else // Plain browser env
mod(CodeMirror);
})(function(CodeMirror) {codemirror/lib/codemirror js file instead of just codemirror the addons work as expected, but the modes stop working. I'm leaning towards taking the code needed from the addons and putting it in its own js file that can be imported without the IIFE wrapper but that's definitely not ideal if codemirror ever needs to be updated