Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Nov 26 21:04
    G-Ambatte labeled #2517
  • Nov 26 21:04
    G-Ambatte assigned #2517
  • Nov 26 21:04
    G-Ambatte review_requested #2517
  • Nov 25 21:46
    G-Ambatte edited #2517
  • Nov 25 21:45
    G-Ambatte edited #2517
  • Nov 25 09:26
    ericscheid commented #2457
  • Nov 25 09:12
    ericscheid commented #2457
  • Nov 25 06:27
    Gazook89 commented #2457
  • Nov 25 06:26
    Gazook89 commented #2457
  • Nov 25 05:54
    Gazook89 commented #2457
  • Nov 25 05:46
    ericscheid commented #2457
  • Nov 25 04:57
    G-Ambatte commented #2445
  • Nov 25 04:56
    G-Ambatte opened #2517
  • Nov 25 04:19
    G-Ambatte commented #2445
  • Nov 25 04:17
    G-Ambatte opened #2516
  • Nov 25 03:48
    calculuschild commented #2457
  • Nov 25 03:41
    Gazook89 commented #2457
  • Nov 24 06:56
    ericscheid commented #2457
  • Nov 24 06:02
    Gazook89 commented #2457
  • Nov 24 05:47
    ericscheid commented #2457
Trevor Buckner
@calculuschild
We do update it pretty regularly as they come out with new versions. Maybe you can throw what you have into a draft PR and you can get more eyes on it to help crack the case.
Charlie Humphreys
@jeddai
Cool I'll open that PR in a bit
Charlie Humphreys
@jeddai
It has been opened -- any thoughts/feedback would be appreciated!
G.Ambatte
@G-Ambatte
From memory, I don't think you can rely on the CodeMirror object existing - with the recent Undo/Redo history stuff, everything would crash if the CodeMirror editor object properties weren't referenced with optional chaining.
image.png
G.Ambatte
@G-Ambatte
I am totally prepared to be wrong, of course. That is always an option I am willing to consider.
PR #1794 has been opened to fix the issue raised on Reddit about User Page ordering not working correctly for ordering by view count (https://redd.it/qlh2hn - opened on Github as issue #1793).
G.Ambatte
@G-Ambatte
Another easy PR idea: add page count to available sort options on the User Page. Not sure why anyone would want to sort by page count, but it is a thing that could be done now.
G.Ambatte
@G-Ambatte
Random thought: we could add Bugfinder flair to the subreddit. Users who report a confirmed bug get Bugfinder. Perhaps also a Bugsquasher flair, for users who have submitted PRs that fix bugs.
Just some sort of validation for the Redditors, that we value their (good) bug reports.
Trevor Buckner
@calculuschild

we could add Bugfinder flair to the subreddit. Users who report a confirmed bug get Bugfinder. Perhaps also a Bugsquasher flair, for users who have submitted PRs that fix bugs.

Sounds good to me.

Another easy PR idea: add page count to available sort options on the User Page.

Easy, but I don't think it really solves anything. Where possible lets focus our PRs on resolving existing issues.

Eric Scheid
@ericscheid_twitter
But do raise an issue for the idea, flag it as a "P2 - minor feature or tweak" and maybe "Ready to add". It's a simple low-hanging fruit with ample similar code available to copy from — ideal for someone new to the project to get their feet wet with.
Charlie Humphreys
@jeddai
@calculuschild I just noticed that if you have any sections folded as soon as you go to edit anything it unfolds all of them -- I need to figure out why it's doing that before that PR is ready. Is there a label I can add to the PR to mark it as on hold?
Trevor Buckner
@calculuschild
Click this:
image.png
Charlie Humphreys
@jeddai
Awesome, thanks
Charlie Humphreys
@jeddai
image.png
Any thoughts on having the content of the fold inside the fold widget?
It seems to wrap well but I'm currently limiting it to 20 characters
Trevor Buckner
@calculuschild
Hmmmm.... I don't know. It looks a little messy. What happens if you just leave whitespace as whitespace to reduce the clutter of symbols?
Trevor Buckner
@calculuschild
I'm tempted to say just don't show the contents in anticipation of allowing users to add more stuff onto the \page lines, possibly as folding labels (naturalcrit/homebrewery#1667) or even styling that applies to the whole page. But showing page contents might be enough for now until we make that change since I think it's still a way off.
Charlie Humphreys
@jeddai
image.png
Definitely a little cleaner -- maybe some css changes we could make to the widget could help as well?
Charlie Humphreys
@jeddai
But yeah we can also just leave it empty as an open/close arrow and call it a day haha
G.Ambatte
@G-Ambatte
Hacktoberfest T-shirt redeemed... We'll see how long it takes to ship.
Trevor Buckner
@calculuschild
@G-Ambatte I merged naturalcrit/homebrewery#1777 but found an error shortly after. I reverted the changes, but we can't reopen PRs so we will need to open a new one and keep tinkering on it.
G.Ambatte
@G-Ambatte
I'll open a new PR from the same branch.
Trevor Buckner
@calculuschild
perfect.
G.Ambatte
@G-Ambatte
Hmm, says there's no changes to PR.
Trevor Buckner
@calculuschild
Hm....
I reverted your PR.... there should be a difference.
G.Ambatte
@G-Ambatte
Exactly what I was thinking.
Trevor Buckner
@calculuschild
what's your branch called
G.Ambatte
@G-Ambatte
G-Ambatte:experimentalAddMetadata-#820
image.png
Trevor Buckner
@calculuschild
Mmmmmmmmm.... One moment
G.Ambatte
@G-Ambatte
Tried switching the base to PRODUCTION and back to master, no change
Trevor Buckner
@calculuschild
Oh I see what's going on. Its not comparing the file differences. It's looking at the commit ids and saying "oh i already have those commits".
My revert then applied another commit on top, but your old commits are still in the history.
G.Ambatte
@G-Ambatte
Ah ok, so we need an updated commit on the branch to create a new PR
Trevor Buckner
@calculuschild
And that commit needs to contain all of your branches changes or it will still only detect the latest commit as being different.
G.Ambatte
@G-Ambatte
Git works so well, when it's working well.
And then there's situations like this...
Trevor Buckner
@calculuschild
So we need to 1) open your branch and copy the files somewhere 2) merge master into your branch so it's up to date (or just make a a new branch) 3) copy back in your files so all your changes are there again.
Sorry this is all my bad.
G.Ambatte
@G-Ambatte
It's all good, I'll deal with it shortly... Currently plugging away at the unified EditorPage.
Trevor Buckner
@calculuschild
Sounds good.
The issue with the thumbnail was that it's pretty easy to hit the size limit for Google Drive properties (124 characters including the property name). I also foresee a similar issue when we start adding custom tags and things. We probably need to get around this by adding a new field into the document itself, similar to our css block for the style tab, but for metadata. Probably needs a whole separate PR just to set that up.
G.Ambatte
@G-Ambatte
Yeah, that sounds like a significant issue
Eric Scheid
@ericscheid_twitter
Side benefit: a downloaded brew will include all the user editable meta-data.
G.Ambatte
@G-Ambatte
Could probably slap a 100 character limit on the URL field as a temporary workaround until the metadata codefence is in place
Or just mark it to be added after the metadata codefence