Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Nov 28 2020 21:33
    mmcc commented #188
  • Nov 28 2020 21:31
    naugtur commented #188
  • Nov 28 2020 21:30

    naugtur on v2.6.0

    (compare)

  • Nov 28 2020 21:30

    naugtur on master

    2.6.0 (compare)

  • Nov 28 2020 21:15
    mmcc commented #188
  • May 29 2020 20:49
    rhenwood-arm commented #184
  • May 26 2020 18:41
    naugtur commented #184
  • May 26 2020 13:11
    ossdev07 commented #184
  • May 26 2020 11:24
    naugtur commented #184
  • May 26 2020 11:19
    ossdev07 commented #184
  • May 26 2020 07:50
    Raynos commented #189
  • May 25 2020 21:10
    naugtur closed #176
  • May 25 2020 21:10

    naugtur on master

    fixes #176 Merge pull request #188 from na… (compare)

  • May 25 2020 21:10
    naugtur closed #188
  • May 25 2020 21:07

    naugtur on master

    chore(readme): remove Greenkeep… Merge pull request #189 from na… (compare)

  • May 25 2020 21:07
    naugtur closed #189
  • May 25 2020 21:00
    greenkeeper[bot] opened #189
  • May 25 2020 21:00

    greenkeeper[bot] on tape-5.0.1

    (compare)

  • May 25 2020 21:00

    greenkeeper[bot] on tape-4.12.1

    (compare)

  • May 25 2020 21:00

    greenkeeper[bot] on is-function-1.0.2

    (compare)

James
@jamesplease
:v: thanks
Zbyszek Tenerowicz
@naugtur
will probably have to close the PR not to leave it hanging until v3 gets merged to master
James
@jamesplease
:+1: sounds good to me
the issue can probably be closed, too
if you need any more help with any of the v3 items, in addition to SauceLabs, let me know. happy to help out.
Zbyszek Tenerowicz
@naugtur
I've invited you to be a contributor
James
@jamesplease
the invitation was accepted :)
Zbyszek Tenerowicz
@naugtur
I'm happy you're willing to set it up. Would be even better if it was browserstack instead of saucelabs, but it's hard nontheless ;)
James
@jamesplease
i could do BrowserStack, too
Zbyszek Tenerowicz
@naugtur
The hardest part is that the tests need to make real requests, both cross domain and to the localhost server serving the tests
James
@jamesplease
with BrowserStack, they make you put a thing in your README, that says, "We use BrowserStack and it's great!" or something.
yeah, that makes sense.
Zbyszek Tenerowicz
@naugtur
I don't mind, they give a lot more runs/hour for free so they can have a line in a readme
but the setup... If I remember correctly, last time I tried saucelabs, they would block all outgoing traffic so I couldn't test cross domain requests to mocky.io
Zbyszek Tenerowicz
@naugtur
It's movie night with my wife time in my timezone, I'll catch you later!
James
@jamesplease
i'll look to see if i can find a workaround for that issue. enjoy the movie!
Bent Cardan
@reqshark
sup guys
@naugtur your point about qs: Any? is good, i have to agree with that since it might not be a function
Zbyszek Tenerowicz
@naugtur
Hi. I'd like to merge new browser runner to v3dev some time soon. Let me know if I should give anyone time to review.
The main drawback of the new runner is that while it's still maintained, it got severely broken after 3.5.0 and I'm not sure if it'll recover to a state that handles our usecase juliangruber/browser-run#137
James
@jamesplease
@naugtur i approved that PR
James
@jamesplease
i reached out to BrowserStack and SauceLabs to see about their support for making cross-origin requests from the browser. their documentation didn't clearly state that they support it (or at least, I couldn't find it)
once i hear back, i'll post in here.
work's been busy, so i haven't had time to get started on this until now :)
James
@jamesplease
SauceLabs got back to me. they support what we need, so that's an option. holding off until i hear back from BrowserStack.
i recently added SauceLabs to a project, and it got so annoying because the first run would happen quickly, and the second one would take forever. i think because i had a limit of 5 concurrent sessions, and i was testing 5 env's per run
(it was running twice due to Travis running the commit and the PR builds)
Zbyszek Tenerowicz
@naugtur
Tat's exactly what I recall people complaining about when I first wanted to use saucelabs with zuul configuration. I almost got it to work before it turned out we'd get slow runs. But compared to no tests in old browsers unless I boot up a VM it's much better anyway.
James
@jamesplease
yeah, definitely.
how many env's are we thinking of testing against? if it's...2, then SauceLabs might not be extremely slow, since each set of builds will come in below the limit of 5.
but we probably want to test more than 2, huh?
i wonder if they'd be flexible on upping the limit for us, in support of open source
Zbyszek Tenerowicz
@naugtur
We don't have to run tests against the browsers we use locally, but we'd have to test IE10+, Edge, Old safari versions and probably some mobile too.
I'll try to reach out to BrowserStack through my work, as the company has recently become a paying customer and maybe I can make them demo the setup using xhr as example. ;)
I'll do that when I'm back from vacation in a week from now.
Rick Medina
@rickmed
hello! someone here?? q: what is the lib's build size?
Ben Jefferies
@benjefferies
Hi All and @naugtur. Has anyone got any ideas why sync requests does not enable withCredentials? See here https://github.com/naugtur/xhr/blob/master/index.js#L182
James
@jamesplease
naugtur/xhr@6783dc2
Ben Jefferies, check out that commit
(I did a quick git blame through the GitHub UI to find when the if statement was added)
Ben Jefferies
@benjefferies
Cheers @jmeas. I wonder if there is a way around it. Not sure what the underlying implementation is within jquery but maybe this would work https://stackoverflow.com/a/16673436 instead of blanket disabling.
James
@jamesplease
Ben, would you mind opening an issue?
there may be a way around it. try/catch is one idea, but that’s kinda clunky. perhaps modernizr has a snippet we could use.
can you not use async requests in this situation?
you may already know this, but synchronous requests are blocking, so if the network is down, your app could freeze up for quite some time
Ben Jefferies
@benjefferies
I will open an issue sometime today
I agree it's probably nicer to use feature detections to enable this functionality rather than a hacky fix
I would love to use an async request but it's not possible; I am implementing some functionality to log users out when then navigate away from the current domain, if this is done async the request is very likely to be cancelled by the browsers when the page changes however the request will be fulfilled if the request is sync
Ben Jefferies
@benjefferies
Issue raise naugtur/xhr#168
chisholmd
@chisholmd
How can I get the XML String from xhttp.responseXML ?
Why is there no: document.toString() or document.innerHTML ?
chisholmd
@chisholmd
domDoc.doctype + domDoc.documentElement.outerHTML
James Gooding
@jameseg
what's up ya'll, if I delete fetch from my window will my requests be polyfilled with xhr instead?