These are chat archives for nelsam/vidar

25th
Nov 2017
Samuel Nelson
@nelsam
Nov 25 2017 00:14
@Kvaz1r if you can find time, I'd appreciate it if you would try the plugins branch again - I fixed a bunch of bugs from that branch
I think it's getting to the point where it doesn't have many more bugs than master; once it's as at least as good as master, I'd like to merge it
Samuel Nelson
@nelsam
Nov 25 2017 02:53
also, just FYI, I've added some things that github will use when you create issues and pull requests - this is mostly because once the plugins branch is merged, I'm going to clean up a few things, add a logo and some screenshots (and maybe a github.io page), and submit it to hackernews and lobste.rs
it doesn't really change anything for you
Kvaz1r
@Kvaz1r
Nov 25 2017 07:49
I believe it goes like:
thanks, will try it.
yes, I seen this templates and it's seems reasonable for me.
Kvaz1r
@Kvaz1r
Nov 25 2017 08:04
of course, I have time for some tests today.

bug-1

  1. vidar test.go test.txt
  2. split view
  3. move file with .go to tab with .txt
  4. ctlw-w

menubar disappear, log output:
2017/11/25 09:53:18 ERR: panic while executing bindable *focus.Location: runtime
error: index out of range

Kvaz1r
@Kvaz1r
Nov 25 2017 09:49
bug-2, from File menu for files with extension .go disappear shortcut for saving.
alt
Kvaz1r
@Kvaz1r
Nov 25 2017 10:11
bug-3, when tried open file (through ctrl-o) from root of disk the queue suggest files from current directory.
alt
The reason and variant solution exactly like I describe in #97
Samuel Nelson
@nelsam
Nov 25 2017 18:32
Do any of these happen in master, too, or just in the plugins branch?
I'll work on them today, just trying to understand if the plugins branch introduced them or not
Samuel Nelson
@nelsam
Nov 25 2017 19:24
bug-1 should be solved
Kvaz1r
@Kvaz1r
Nov 25 2017 19:44
bug-2 only for plugins branch, bug-3 - both.
Samuel Nelson
@nelsam
Nov 25 2017 19:45
I just figured out bug-2 and will be pushing a fix shortly
bug-2 should be fixed in 7d0ca94
@Kvaz1r I'll work on bug-3, but since it's a bug that is also in master, do you think I'm okay to merge plugins into master now?
(assuming that bug-1 and bug-2 are fixed)
Kvaz1r
@Kvaz1r
Nov 25 2017 19:52
yes, of course
Samuel Nelson
@nelsam
Nov 25 2017 19:54
awesome! I would appreciate it if you could check to make sure that bug-1and bug-2 are fixed for you before I merge, too
Kvaz1r
@Kvaz1r
Nov 25 2017 19:58
yes, I wait when go get load update and will check it.
yes, this fixed, but now instead 'Cmd' in shortcut 'Win'.
Samuel Nelson
@nelsam
Nov 25 2017 20:04
Yes, I added platform-specific keys. On Windows it will be Win, on Mac it will be Cmd, on Linux and BSD it will be Super
If that is confusing, I can switch it back to the old behavior
Kvaz1r
@Kvaz1r
Nov 25 2017 20:06
no, it also conveniently, just a bit unusual for me.
Samuel Nelson
@nelsam
Nov 25 2017 20:10
okay
I'm going to get some beer and will work on bug-3 at the brewery
Kvaz1r
@Kvaz1r
Nov 25 2017 20:23
heh, good idea , so that I also going to dinner.
And in your country is really so widespread beer culture as shown in the TV series?
Samuel Nelson
@nelsam
Nov 25 2017 20:34
it sort of depends; we have two sides of beer culture:
  1. The people who want to get drunk and just drink a whole lot of awful tasting beer (budweiser, miller, coors)
  2. The people who love beer for the flavor, and visit very small local breweries
I'm part of group 2
we have a very quickly growing number of those small, local breweries: https://www.brewersassociation.org/statistics/number-of-breweries/ (over 3,000 microbreweries at last count)
Samuel Nelson
@nelsam
Nov 25 2017 21:50
I added a windows-drive-letters branch that has my first attempt at a fix. Feel free to try it out when you get a chance.