These are chat archives for nelsam/vidar

2nd
Dec 2017
Kvaz1r
@Kvaz1r
Dec 02 2017 20:04
start working on #100 and had see interesting behaviour.
I think that as CodeEditor based on TextBox so he, on idea, must use handlers from there, in this case Backspace. But changes in Backspace function didn't change work of CodeEditor.
Why it happened and where corresponding function for CodeEditor? I didn't found any appropriate methods.
Samuel Nelson
@nelsam
Dec 02 2017 20:10
I pulled all of that out into an input.Handler type both to reduce our reliance on gxui and to allow the behavior to be overridden (for example, one of my friends wants to write a vim-style input handler to override the default one)
Kvaz1r
@Kvaz1r
Dec 02 2017 20:57
ahh, I see it. Didn't think that it can be overwritten.
Samuel Nelson
@nelsam
Dec 02 2017 21:08
that's a new change from when we merged in the plugins branch - it's there so that plugins can provide their own input handlers
Kvaz1r
@Kvaz1r
Dec 02 2017 21:21
really, very conveniently. Btw, which type of issue you mark with review label?
Samuel Nelson
@nelsam
Dec 02 2017 21:22
that's done by waffle - the issue board
I move things into review when they're effectively feature-complete and I'm just checking for issues before merge
or I think they're fixed and I need to review whether or not they are
Kvaz1r
@Kvaz1r
Dec 02 2017 21:25
Yeah, so somewhere I thought so.
#96 not fixed now, maybe I wasn't very correctly formulated it.
Samuel Nelson
@nelsam
Dec 02 2017 21:27
I added code that should allow deletion of the drive so you can type in a drive letter, but I hadn't tested it yet
hence why it was in review
Kvaz1r
@Kvaz1r
Dec 02 2017 22:23
understood