These are chat archives for nelsam/vidar

18th
May 2018
Kvaz1r
@Kvaz1r
May 18 2018 18:22
ok, I started, but seems it takes more time than I expected and I will have many questions. So maybe would be better if I reset all commit from #125 except first and open new PR?
Samuel Nelson
@nelsam
May 18 2018 18:26
that's fine
whatever's easiest for you
Kvaz1r
@Kvaz1r
May 18 2018 18:41
updated
btw, #121 not a bug, it more like enhancement. I meant just making copy for current file not more. I really should spend more time every day for learning English.
Samuel Nelson
@nelsam
May 18 2018 18:47
Oh, weird. What you wrote makes enough sense to me that I should have realized that; I think I got confused with a different issue.
Kvaz1r
@Kvaz1r
May 18 2018 19:00
yes, with #110
Now the thin thing for Scroller hook it's how define when should it triggered. Without operation it's easy - special handling for backspace and nothing more. Is it needed separate two case - editing with backspace and common option just shifting with caret?
Samuel Nelson
@nelsam
May 18 2018 19:01
the way that I see it, backspace should automatically trigger the caret moving, so if the scroll is hooked to caret movement, it automatically solves the backspace problem
Kvaz1r
@Kvaz1r
May 18 2018 19:11
well it's seems perfect, after moving caret - check if position out of current "box" and if yes - shift scroll for new position.
or I miss something?
Samuel Nelson
@nelsam
May 18 2018 19:12
nope, that's the idea