Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 05 12:37
    Kvaz1r synchronize #186
  • Nov 05 10:39
    Kvaz1r commented #186
  • Nov 04 14:34
    Kvaz1r ready_for_review #186
  • Nov 04 14:15
    Kvaz1r edited #186
  • Nov 04 14:14
    Kvaz1r synchronize #186
  • Nov 04 10:58
    Kvaz1r edited #186
  • Nov 04 09:17
    Kvaz1r synchronize #186
  • Nov 03 18:29
    Kvaz1r opened #186
  • Nov 01 15:00

    nelsam on master

    Add check for function with emp… Merge pull request #185 from Kv… (compare)

  • Nov 01 15:00
    nelsam closed #185
  • Nov 01 15:00
    nelsam closed #158
  • Nov 01 15:00
    nelsam commented #185
  • Nov 01 09:28
    Kvaz1r opened #185
  • Oct 30 14:17
    Kvaz1r closed #162
  • Oct 30 14:17
    Kvaz1r commented #162
  • Oct 29 17:56

    nelsam on v0.4.0

    Alpha v0.4.0: add go.mod and go… (compare)

  • Oct 19 23:52

    nelsam on master

    gocode: fix off-by-one error (<… Merge pull request #184 from ne… (compare)

  • Oct 19 23:52
    nelsam closed #184
  • Oct 19 16:16
    nelsam opened #184
  • Oct 19 15:12

    nelsam on lsp

    plugin: start implementing lang… (compare)

Kvaz1r
@Kvaz1r
start working on #100 and had see interesting behaviour.
I think that as CodeEditor based on TextBox so he, on idea, must use handlers from there, in this case Backspace. But changes in Backspace function didn't change work of CodeEditor.
Why it happened and where corresponding function for CodeEditor? I didn't found any appropriate methods.
Samuel Nelson
@nelsam
I pulled all of that out into an input.Handler type both to reduce our reliance on gxui and to allow the behavior to be overridden (for example, one of my friends wants to write a vim-style input handler to override the default one)
Kvaz1r
@Kvaz1r
ahh, I see it. Didn't think that it can be overwritten.
Samuel Nelson
@nelsam
that's a new change from when we merged in the plugins branch - it's there so that plugins can provide their own input handlers
Kvaz1r
@Kvaz1r
really, very conveniently. Btw, which type of issue you mark with review label?
Samuel Nelson
@nelsam
that's done by waffle - the issue board
I move things into review when they're effectively feature-complete and I'm just checking for issues before merge
or I think they're fixed and I need to review whether or not they are
Kvaz1r
@Kvaz1r
Yeah, so somewhere I thought so.
#96 not fixed now, maybe I wasn't very correctly formulated it.
Samuel Nelson
@nelsam
I added code that should allow deletion of the drive so you can type in a drive letter, but I hadn't tested it yet
hence why it was in review
Kvaz1r
@Kvaz1r
understood
Kvaz1r
@Kvaz1r
I think I solved #100 , but I'm not sure about this approach and ,specially, variables naming.
first, add storing offset scroll for click Kvaz1r/gxui@c71a4c6 to gxui and after update input handlers
Kvaz1r
@Kvaz1r
@nelsam , ping me, when you will have time for answer.
Samuel Nelson
@nelsam
will do ... I'm still moving in to my new house, so I don't have my main development machine hooked up yet
Kvaz1r
@Kvaz1r
o, but new house also in the same city?
Samuel Nelson
@nelsam
no, it's 950 miles (1500 kilometers) away
Kvaz1r
@Kvaz1r
yes, it's pretty far. You were in this region earlier or it spontaneously decision?
Samuel Nelson
@nelsam
I grew up there and have been planning to move for a long time
Kvaz1r
@Kvaz1r
but you don't lose current job?
Samuel Nelson
@nelsam
no, my current job is completely remote. I work from home.
Kvaz1r
@Kvaz1r
great. But new(old :D) city too in USA?
Samuel Nelson
@nelsam
yep
Kvaz1r
@Kvaz1r
looks nice
Samuel Nelson
@nelsam
okay, I'm moved
I still have things to take care of, but I'm going to be getting back in to the swing of things here
Kvaz1r
@Kvaz1r
congrats! Do you have some interesting traditions related with moved house? (like throwing "silver" coins or a cat enters the house first ...)
Samuel Nelson
@nelsam
we don't
Samuel Nelson
@nelsam
okay, I'm starting to look at that code
sorry it's taken so long
Kvaz1r
@Kvaz1r
np, I understand that OS is OS, sometime one have time sometime - no.
btw, I also fixed this PR - nelsam/gxui#6
Samuel Nelson
@nelsam
yep I saw that :)
I'll merge it for now and try using it later
Kvaz1r
@Kvaz1r
then I soon open another one for :D
btw it's strange but I definitely don't like go 1.10 all applications became very slow.
Samuel Nelson
@nelsam
strange. have you profiled any of them with pprof? https://jvns.ca/blog/2017/09/24/profiling-go-with-pprof/
it might be a bug in go
Kvaz1r
@Kvaz1r
maybe really bug. Thanks for the link I'll try to profiling it. Or I just switch back to x386 version :D
Kvaz1r
@Kvaz1r
Should I open single PR for changes which I proposed in nelsam/gxui#6 and nelsam/gxui#7 or make them as separate?
Samuel Nelson
@nelsam
whatever works best for you is fine
if the changes are small, submitting them both in one PR is reasonable
Kvaz1r
@Kvaz1r
ok
#124 doesn't seems hard for fixing so I can try solve it on this week if you not going to make it earlier.
Samuel Nelson
@nelsam
I have a fix for it already, but I'm also fixing the same problem for the fullscreen key
they're kinda related