Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 19 23:52

    nelsam on master

    gocode: fix off-by-one error (<… Merge pull request #184 from ne… (compare)

  • Oct 19 23:52
    nelsam closed #184
  • Oct 19 16:16
    nelsam opened #184
  • Oct 19 15:12

    nelsam on lsp

    plugin: start implementing lang… (compare)

  • Oct 19 15:11

    nelsam on gocode-off-by-one

    gocode: fix off-by-one error (<… (compare)

  • Oct 19 15:01

    nelsam on lsp

    plugin: start implementing lang… (compare)

  • Oct 18 23:55

    nelsam on lsp

    plugin: start implementing lang… (compare)

  • Oct 14 17:26
    Kvaz1r closed #142
  • Oct 14 17:13

    nelsam on master

    Add check isFile to file opener Merge branch 'master' into mast… command.FileOpener: present err… and 1 more (compare)

  • Oct 14 17:13
    nelsam closed #183
  • Oct 14 17:10
    Kvaz1r commented #183
  • Oct 14 16:32
    nelsam commented #183
  • Oct 14 16:32
    nelsam commented #183
  • Oct 14 16:27
    nelsam synchronize #183
  • Oct 13 20:14
    nelsam synchronize #183
  • Oct 13 20:13

    nelsam on master

    Don't expand project tree at st… Merge pull request #182 from Kv… (compare)

  • Oct 13 20:13
    nelsam closed #182
  • Oct 13 20:13
    nelsam closed #146
  • Oct 13 06:39
    Kvaz1r synchronize #183
  • Oct 12 17:20
    Kvaz1r opened #183
Kvaz1r
@Kvaz1r
np, I understand that OS is OS, sometime one have time sometime - no.
btw, I also fixed this PR - nelsam/gxui#6
Samuel Nelson
@nelsam
yep I saw that :)
I'll merge it for now and try using it later
Kvaz1r
@Kvaz1r
then I soon open another one for :D
btw it's strange but I definitely don't like go 1.10 all applications became very slow.
Samuel Nelson
@nelsam
strange. have you profiled any of them with pprof? https://jvns.ca/blog/2017/09/24/profiling-go-with-pprof/
it might be a bug in go
Kvaz1r
@Kvaz1r
maybe really bug. Thanks for the link I'll try to profiling it. Or I just switch back to x386 version :D
Kvaz1r
@Kvaz1r
Should I open single PR for changes which I proposed in nelsam/gxui#6 and nelsam/gxui#7 or make them as separate?
Samuel Nelson
@nelsam
whatever works best for you is fine
if the changes are small, submitting them both in one PR is reasonable
Kvaz1r
@Kvaz1r
ok
#124 doesn't seems hard for fixing so I can try solve it on this week if you not going to make it earlier.
Samuel Nelson
@nelsam
I have a fix for it already, but I'm also fixing the same problem for the fullscreen key
they're kinda related
Kvaz1r
@Kvaz1r
yeah, it's remember me about yet one option in menu - Save as, so I am going to open issue for it.
Eric Myhre
@warpfork
Hi, I just found vidar today and want you to know it's really freakin cool! o/
Samuel Nelson
@nelsam
thanks! :)
Kvaz1r
@Kvaz1r
It was wrong alarm, the reason in error not in my update, so I guess I finished with #125 and it ready for review.
Samuel Nelson
@nelsam
cool, I'll check it out after work
Samuel Nelson
@nelsam
I took a look but had a minor request; let me know if that doesn't make sense to you
Kvaz1r
@Kvaz1r
yes, it make sense for me, I even thought about something like this. But first it's very rare case for making new entity and second it's seems a bit complicated.
Another reason - #127, which may be related to any hook. I really tried to found root of this behaviour but I don't see any problem with the code.
Samuel Nelson
@nelsam
yeah, it's a more complicated overall solution, but because we're starting to support plugins, we need to think about what plugins might want to be able to do
I'm trying to keep each command focused on one very small thing to make them easier for plugins to use
Samuel Nelson
@nelsam
I'll take a look at #127 now - it might just be handling events in a way that forces it to process the edit more than once or something
Kvaz1r
@Kvaz1r
ok, then I'll try to update PR at the weekend.
Kvaz1r
@Kvaz1r
well, will waiting merge #128 for testing.

begin of the month was really hard, but it seems I will have time for OS.
I try to adapt #125 according to your comments, but I do not know what exactly should to do. Just by analogy

  1. create package for moving of scroll
  2. create operation on_delete

but what I really don't understand how to connect it so, that processing would active only at removal (to be honest don't know how to bind such commands at all :D).

Samuel Nelson
@nelsam
:thumbsup: I'll get you an example after work
I think we probably want to be checking scroll any time an edit happens, though - if any text is changed or the cursor moves and no cursor is visible, we probably want to scroll to the nearest (or next) cursor
Samuel Nelson
@nelsam
sorry I didn't quite get that example for you
gonna work on it today
Kvaz1r
@Kvaz1r
np, today I also all day worked ... but in garden.
Samuel Nelson
@nelsam
nice!
Samuel Nelson
@nelsam
that bug took a lot longer to fix than I was expecting
I'll add info to the wiki about how to create those op types that I mentioned in your PR in the next few days, hopefully
Samuel Nelson
@nelsam
for your situation:
  1. create package command/scroll
  2. create type scroll.Scroll which is a bind.MultiOp similar to caret.Mover except for scrolling
  3. create hook scroll.OnMove which is a bind.OpHook similar to caret.OnEdit except make it scroll the text when the cursor moves by implementing caret.MovedHook
that might be overkill, honestly, but I think it should help make sure that a cursor is always in view
the scroll.OnMove should probably first check to see if one of the passed in carets is already in view before scrolling
Kvaz1r
@Kvaz1r
great, thanks I'll try to do it at weekend.
Kvaz1r
@Kvaz1r
ok, I started, but seems it takes more time than I expected and I will have many questions. So maybe would be better if I reset all commit from #125 except first and open new PR?
Samuel Nelson
@nelsam
that's fine
whatever's easiest for you
Kvaz1r
@Kvaz1r
updated
btw, #121 not a bug, it more like enhancement. I meant just making copy for current file not more. I really should spend more time every day for learning English.
Samuel Nelson
@nelsam
Oh, weird. What you wrote makes enough sense to me that I should have realized that; I think I got confused with a different issue.
Kvaz1r
@Kvaz1r
yes, with #110
Now the thin thing for Scroller hook it's how define when should it triggered. Without operation it's easy - special handling for backspace and nothing more. Is it needed separate two case - editing with backspace and common option just shifting with caret?