Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 19 23:52

    nelsam on master

    gocode: fix off-by-one error (<… Merge pull request #184 from ne… (compare)

  • Oct 19 23:52
    nelsam closed #184
  • Oct 19 16:16
    nelsam opened #184
  • Oct 19 15:12

    nelsam on lsp

    plugin: start implementing lang… (compare)

  • Oct 19 15:11

    nelsam on gocode-off-by-one

    gocode: fix off-by-one error (<… (compare)

  • Oct 19 15:01

    nelsam on lsp

    plugin: start implementing lang… (compare)

  • Oct 18 23:55

    nelsam on lsp

    plugin: start implementing lang… (compare)

  • Oct 14 17:26
    Kvaz1r closed #142
  • Oct 14 17:13

    nelsam on master

    Add check isFile to file opener Merge branch 'master' into mast… command.FileOpener: present err… and 1 more (compare)

  • Oct 14 17:13
    nelsam closed #183
  • Oct 14 17:10
    Kvaz1r commented #183
  • Oct 14 16:32
    nelsam commented #183
  • Oct 14 16:32
    nelsam commented #183
  • Oct 14 16:27
    nelsam synchronize #183
  • Oct 13 20:14
    nelsam synchronize #183
  • Oct 13 20:13

    nelsam on master

    Don't expand project tree at st… Merge pull request #182 from Kv… (compare)

  • Oct 13 20:13
    nelsam closed #182
  • Oct 13 20:13
    nelsam closed #146
  • Oct 13 06:39
    Kvaz1r synchronize #183
  • Oct 12 17:20
    Kvaz1r opened #183
Kvaz1r
@Kvaz1r
It was wrong alarm, the reason in error not in my update, so I guess I finished with #125 and it ready for review.
Samuel Nelson
@nelsam
cool, I'll check it out after work
Samuel Nelson
@nelsam
I took a look but had a minor request; let me know if that doesn't make sense to you
Kvaz1r
@Kvaz1r
yes, it make sense for me, I even thought about something like this. But first it's very rare case for making new entity and second it's seems a bit complicated.
Another reason - #127, which may be related to any hook. I really tried to found root of this behaviour but I don't see any problem with the code.
Samuel Nelson
@nelsam
yeah, it's a more complicated overall solution, but because we're starting to support plugins, we need to think about what plugins might want to be able to do
I'm trying to keep each command focused on one very small thing to make them easier for plugins to use
Samuel Nelson
@nelsam
I'll take a look at #127 now - it might just be handling events in a way that forces it to process the edit more than once or something
Kvaz1r
@Kvaz1r
ok, then I'll try to update PR at the weekend.
Kvaz1r
@Kvaz1r
well, will waiting merge #128 for testing.

begin of the month was really hard, but it seems I will have time for OS.
I try to adapt #125 according to your comments, but I do not know what exactly should to do. Just by analogy

  1. create package for moving of scroll
  2. create operation on_delete

but what I really don't understand how to connect it so, that processing would active only at removal (to be honest don't know how to bind such commands at all :D).

Samuel Nelson
@nelsam
:thumbsup: I'll get you an example after work
I think we probably want to be checking scroll any time an edit happens, though - if any text is changed or the cursor moves and no cursor is visible, we probably want to scroll to the nearest (or next) cursor
Samuel Nelson
@nelsam
sorry I didn't quite get that example for you
gonna work on it today
Kvaz1r
@Kvaz1r
np, today I also all day worked ... but in garden.
Samuel Nelson
@nelsam
nice!
Samuel Nelson
@nelsam
that bug took a lot longer to fix than I was expecting
I'll add info to the wiki about how to create those op types that I mentioned in your PR in the next few days, hopefully
Samuel Nelson
@nelsam
for your situation:
  1. create package command/scroll
  2. create type scroll.Scroll which is a bind.MultiOp similar to caret.Mover except for scrolling
  3. create hook scroll.OnMove which is a bind.OpHook similar to caret.OnEdit except make it scroll the text when the cursor moves by implementing caret.MovedHook
that might be overkill, honestly, but I think it should help make sure that a cursor is always in view
the scroll.OnMove should probably first check to see if one of the passed in carets is already in view before scrolling
Kvaz1r
@Kvaz1r
great, thanks I'll try to do it at weekend.
Kvaz1r
@Kvaz1r
ok, I started, but seems it takes more time than I expected and I will have many questions. So maybe would be better if I reset all commit from #125 except first and open new PR?
Samuel Nelson
@nelsam
that's fine
whatever's easiest for you
Kvaz1r
@Kvaz1r
updated
btw, #121 not a bug, it more like enhancement. I meant just making copy for current file not more. I really should spend more time every day for learning English.
Samuel Nelson
@nelsam
Oh, weird. What you wrote makes enough sense to me that I should have realized that; I think I got confused with a different issue.
Kvaz1r
@Kvaz1r
yes, with #110
Now the thin thing for Scroller hook it's how define when should it triggered. Without operation it's easy - special handling for backspace and nothing more. Is it needed separate two case - editing with backspace and common option just shifting with caret?
Samuel Nelson
@nelsam
the way that I see it, backspace should automatically trigger the caret moving, so if the scroll is hooked to caret movement, it automatically solves the backspace problem
Kvaz1r
@Kvaz1r
well it's seems perfect, after moving caret - check if position out of current "box" and if yes - shift scroll for new position.
or I miss something?
Samuel Nelson
@nelsam
nope, that's the idea
Kvaz1r
@Kvaz1r
carcass done (I opened #133), but with current state getting warning
2018/05/21 21:09:36 Warning: Executor of type *scroll.Scroller ran without execu ting
What am I miss here?
Samuel Nelson
@nelsam
I'll take a look after work
looks mostly correct so far, though
Samuel Nelson
@nelsam
@Kvaz1r I found some time to review your scroll work and sent you a PR.
Kvaz1r
@Kvaz1r
great, I will look it one more time when I have enough time for restoring question in memory, but it looks accessibly, thanks.
Kvaz1r
@Kvaz1r
@nelsam , I've updated #133, so it ready to review. I'm not sure about naming, but guess it cover all basic case(remove block,single backspace,pasting) except implementing shifting horizontal scroll when it required.
As alternative variant instead Direction could add method ToRuneWithChecks and look for shift if necessary there.
And what are you going to doing with nelsam/gxui#12 ? For me your solution very good or you see some real problem in there?
Samuel Nelson
@nelsam
oh, for nelsam/gxui#12 I just forgot to circle back to it
I'll take a look at #133
Samuel Nelson
@nelsam
@Kvaz1r can you give #145 a test? I think it's working. I also made windows use the polling watcher instead of the fsnotify watcher because the fsnotify watcher wasn't working in wine (a windows emulator that I used to test it). The PR also includes some performance fixes on startup and when changing projects.
Kvaz1r
@Kvaz1r
yeah, now vidar runs much more faster. I found a typo, but except it the patch works well.
Samuel Nelson
@nelsam
I finally put together an icon (and sorta made a more detailed logo - the logo still needs work)
Kvaz1r
@Kvaz1r
great work! The logo reminded me Salish Spirits from Stargate :D
Kvaz1r
@Kvaz1r
@nelsam , hello, what do you think about my proposal from nelsam/gxui#16 ? I mean idea in whole.
Samuel Nelson
@nelsam
@Kvaz1r just FYI, I've found some time again and am going to do a pretty drastic change to vidar's directory structure, hopefully make it a bit easier to stay decoupled from dependencies and whatnot