Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 13 19:32
    Kvaz1r synchronize #172
  • Sep 13 17:51
    Kvaz1r synchronize #172
  • Sep 13 17:34
    Kvaz1r synchronize #172
  • Sep 09 16:26

    nelsam on master

    fix data races Merge branch 'master' into data… command/history: convert use of… and 13 more (compare)

  • Sep 09 16:26
    nelsam closed #164
  • Sep 09 16:09
    nelsam synchronize #164
  • Sep 09 16:09
    nelsam commented #164
  • Sep 09 16:08
    nelsam synchronize #164
  • Sep 03 18:30
    Kvaz1r edited #172
  • Sep 03 18:29
    Kvaz1r ready_for_review #172
  • Sep 03 18:21
    Kvaz1r synchronize #172
  • Sep 03 17:43
    Kvaz1r opened #172
  • Sep 03 14:41
    Kvaz1r commented #169
  • Sep 01 18:48
    Kvaz1r commented #168
  • Sep 01 18:00
    nelsam commented #168
  • Sep 01 17:38
    Kvaz1r commented #168
  • Sep 01 16:46
    nelsam commented #168
  • Sep 01 16:43

    nelsam on master

    Create folder if not exist Merge pull request #171 from Kv… (compare)

  • Sep 01 16:43
    nelsam closed #171
  • Sep 01 16:43
    nelsam closed #167
Samuel Nelson
@nelsam
for your situation:
  1. create package command/scroll
  2. create type scroll.Scroll which is a bind.MultiOp similar to caret.Mover except for scrolling
  3. create hook scroll.OnMove which is a bind.OpHook similar to caret.OnEdit except make it scroll the text when the cursor moves by implementing caret.MovedHook
that might be overkill, honestly, but I think it should help make sure that a cursor is always in view
the scroll.OnMove should probably first check to see if one of the passed in carets is already in view before scrolling
Kvaz1r
@Kvaz1r
great, thanks I'll try to do it at weekend.
Kvaz1r
@Kvaz1r
ok, I started, but seems it takes more time than I expected and I will have many questions. So maybe would be better if I reset all commit from #125 except first and open new PR?
Samuel Nelson
@nelsam
that's fine
whatever's easiest for you
Kvaz1r
@Kvaz1r
updated
btw, #121 not a bug, it more like enhancement. I meant just making copy for current file not more. I really should spend more time every day for learning English.
Samuel Nelson
@nelsam
Oh, weird. What you wrote makes enough sense to me that I should have realized that; I think I got confused with a different issue.
Kvaz1r
@Kvaz1r
yes, with #110
Now the thin thing for Scroller hook it's how define when should it triggered. Without operation it's easy - special handling for backspace and nothing more. Is it needed separate two case - editing with backspace and common option just shifting with caret?
Samuel Nelson
@nelsam
the way that I see it, backspace should automatically trigger the caret moving, so if the scroll is hooked to caret movement, it automatically solves the backspace problem
Kvaz1r
@Kvaz1r
well it's seems perfect, after moving caret - check if position out of current "box" and if yes - shift scroll for new position.
or I miss something?
Samuel Nelson
@nelsam
nope, that's the idea
Kvaz1r
@Kvaz1r
carcass done (I opened #133), but with current state getting warning
2018/05/21 21:09:36 Warning: Executor of type *scroll.Scroller ran without execu ting
What am I miss here?
Samuel Nelson
@nelsam
I'll take a look after work
looks mostly correct so far, though
Samuel Nelson
@nelsam
@Kvaz1r I found some time to review your scroll work and sent you a PR.
Kvaz1r
@Kvaz1r
great, I will look it one more time when I have enough time for restoring question in memory, but it looks accessibly, thanks.
Kvaz1r
@Kvaz1r
@nelsam , I've updated #133, so it ready to review. I'm not sure about naming, but guess it cover all basic case(remove block,single backspace,pasting) except implementing shifting horizontal scroll when it required.
As alternative variant instead Direction could add method ToRuneWithChecks and look for shift if necessary there.
And what are you going to doing with nelsam/gxui#12 ? For me your solution very good or you see some real problem in there?
Samuel Nelson
@nelsam
oh, for nelsam/gxui#12 I just forgot to circle back to it
I'll take a look at #133
Samuel Nelson
@nelsam
@Kvaz1r can you give #145 a test? I think it's working. I also made windows use the polling watcher instead of the fsnotify watcher because the fsnotify watcher wasn't working in wine (a windows emulator that I used to test it). The PR also includes some performance fixes on startup and when changing projects.
Kvaz1r
@Kvaz1r
yeah, now vidar runs much more faster. I found a typo, but except it the patch works well.
Samuel Nelson
@nelsam
I finally put together an icon (and sorta made a more detailed logo - the logo still needs work)
Kvaz1r
@Kvaz1r
great work! The logo reminded me Salish Spirits from Stargate :D
Kvaz1r
@Kvaz1r
@nelsam , hello, what do you think about my proposal from nelsam/gxui#16 ? I mean idea in whole.
Samuel Nelson
@nelsam
@Kvaz1r just FYI, I've found some time again and am going to do a pretty drastic change to vidar's directory structure, hopefully make it a bit easier to stay decoupled from dependencies and whatnot
it'll also help me finally finish the "shared session" work that I'm doing
but it means that if you have work in progress on vidar, merges might get complicated
Samuel Nelson
@nelsam
I'm also probably going to move everything to git.sr.ht at some point, but I'll sync changes between the two
Kvaz1r
@Kvaz1r

I've found some time again and am going to do a pretty drastic change to vidar's directory structure, hopefully make it a bit easier to stay decoupled from dependencies and whatnot

great

but it means that if you have work in progress on vidar, merges might get complicated

no, unfortunately this January I'm not very lucky for free time, so I haven't any work in progress at all.

I'm also probably going to move everything to git.sr.ht at some point, but I'll sync changes between the two

interesting. That is by some specific reason or just because?

never heard about this platform
Samuel Nelson
@nelsam
yeah, sr.ht is very new - I want to try it out because they're trying something different and have a very simple, stripped down interface
I thought about moving to gitlab because github is now owned by microsoft (and I don't like supporting microsoft when I can help it), but decided I would try sr.ht first
Kvaz1r
@Kvaz1r
yeah, gitlab has very similar interface to github and many projects was moved there , but Gitlab hasn't good search. I'm not big fan of Microsoft but sometimes not understand why it's problem (while they don't try change rules). Except obvious argument that they are monopolist.
Samuel Nelson
@nelsam
one of the biggest reasons for me is that microsoft spends most of their effort on making it hard for competitors to write better software, instead of just trying to write better software than their competitors
this gives their users a worse experience
most of my other reasons are summarized pretty well by a friend of mine, here: https://github.com/taotetek/WhyILeftGithub
Kvaz1r
@Kvaz1r
principles...it deserves respect. I personally haven't bothering about all this thing (unfair competition, participation in various government programs) because it's a bit far for me and all or almost corporation do same thing.
Kvaz1r
@Kvaz1r
at least they just make money and don't making view that all they do it's for goodness of people. Though sometimes they are trying.
Kvaz1r
@Kvaz1r
@nelsam , very well January is gone and I'm free. I forgot to mention, but I finished with nelsam/gxui#16 so it ready for your review. And also started nelsam/gxui#18, but it's more like concept.
Kvaz1r
@Kvaz1r
Found an interesting project - fyne - Cross platform GUI in Go based on Material Design. It still doesn't contain many controls but can be good replacement for gxui in future since in active development phase.
Although a bit slowly, even in comparing to gxui, but I will try it for my next pet-project.
Samuel Nelson
@nelsam
I'll keep an eye on it

I've been distracted lately, but I am still slowly changing the internal types in vidar so that they no longer embed the mixins types - i.e. instead of

type Editor struct {
    mixins.CodeEditor
    // Other fields...
}

we will have:

type Editor struct {
    box ui.TextBox // the gxui.CodeEditor is stored here
}