Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 17:26
    Kvaz1r closed #142
  • 17:13

    nelsam on master

    Add check isFile to file opener Merge branch 'master' into mast… command.FileOpener: present err… and 1 more (compare)

  • 17:13
    nelsam closed #183
  • 17:10
    Kvaz1r commented #183
  • 16:32
    nelsam commented #183
  • 16:32
    nelsam commented #183
  • 16:27
    nelsam synchronize #183
  • Oct 13 20:14
    nelsam synchronize #183
  • Oct 13 20:13

    nelsam on master

    Don't expand project tree at st… Merge pull request #182 from Kv… (compare)

  • Oct 13 20:13
    nelsam closed #182
  • Oct 13 20:13
    nelsam closed #146
  • Oct 13 06:39
    Kvaz1r synchronize #183
  • Oct 12 17:20
    Kvaz1r opened #183
  • Oct 12 15:45
    Kvaz1r opened #182
  • Oct 10 21:22

    nelsam on readme-xdg-bump

    (compare)

  • Oct 10 20:53

    nelsam on master

    Bump `Configuration` section pe… Merge pull request #181 from ne… (compare)

  • Oct 10 20:53
    nelsam closed #181
  • Oct 10 20:03
    Kvaz1r commented #146
  • Oct 10 20:02
    nelsam synchronize #181
  • Oct 10 20:02

    nelsam on readme-xdg-bump

    Bump `Configuration` section pe… (compare)

Samuel Nelson
@nelsam
I'll take a look at #133
Samuel Nelson
@nelsam
@Kvaz1r can you give #145 a test? I think it's working. I also made windows use the polling watcher instead of the fsnotify watcher because the fsnotify watcher wasn't working in wine (a windows emulator that I used to test it). The PR also includes some performance fixes on startup and when changing projects.
Kvaz1r
@Kvaz1r
yeah, now vidar runs much more faster. I found a typo, but except it the patch works well.
Samuel Nelson
@nelsam
I finally put together an icon (and sorta made a more detailed logo - the logo still needs work)
Kvaz1r
@Kvaz1r
great work! The logo reminded me Salish Spirits from Stargate :D
Kvaz1r
@Kvaz1r
@nelsam , hello, what do you think about my proposal from nelsam/gxui#16 ? I mean idea in whole.
Samuel Nelson
@nelsam
@Kvaz1r just FYI, I've found some time again and am going to do a pretty drastic change to vidar's directory structure, hopefully make it a bit easier to stay decoupled from dependencies and whatnot
it'll also help me finally finish the "shared session" work that I'm doing
but it means that if you have work in progress on vidar, merges might get complicated
Samuel Nelson
@nelsam
I'm also probably going to move everything to git.sr.ht at some point, but I'll sync changes between the two
Kvaz1r
@Kvaz1r

I've found some time again and am going to do a pretty drastic change to vidar's directory structure, hopefully make it a bit easier to stay decoupled from dependencies and whatnot

great

but it means that if you have work in progress on vidar, merges might get complicated

no, unfortunately this January I'm not very lucky for free time, so I haven't any work in progress at all.

I'm also probably going to move everything to git.sr.ht at some point, but I'll sync changes between the two

interesting. That is by some specific reason or just because?

never heard about this platform
Samuel Nelson
@nelsam
yeah, sr.ht is very new - I want to try it out because they're trying something different and have a very simple, stripped down interface
I thought about moving to gitlab because github is now owned by microsoft (and I don't like supporting microsoft when I can help it), but decided I would try sr.ht first
Kvaz1r
@Kvaz1r
yeah, gitlab has very similar interface to github and many projects was moved there , but Gitlab hasn't good search. I'm not big fan of Microsoft but sometimes not understand why it's problem (while they don't try change rules). Except obvious argument that they are monopolist.
Samuel Nelson
@nelsam
one of the biggest reasons for me is that microsoft spends most of their effort on making it hard for competitors to write better software, instead of just trying to write better software than their competitors
this gives their users a worse experience
most of my other reasons are summarized pretty well by a friend of mine, here: https://github.com/taotetek/WhyILeftGithub
Kvaz1r
@Kvaz1r
principles...it deserves respect. I personally haven't bothering about all this thing (unfair competition, participation in various government programs) because it's a bit far for me and all or almost corporation do same thing.
Kvaz1r
@Kvaz1r
at least they just make money and don't making view that all they do it's for goodness of people. Though sometimes they are trying.
Kvaz1r
@Kvaz1r
@nelsam , very well January is gone and I'm free. I forgot to mention, but I finished with nelsam/gxui#16 so it ready for your review. And also started nelsam/gxui#18, but it's more like concept.
Kvaz1r
@Kvaz1r
Found an interesting project - fyne - Cross platform GUI in Go based on Material Design. It still doesn't contain many controls but can be good replacement for gxui in future since in active development phase.
Although a bit slowly, even in comparing to gxui, but I will try it for my next pet-project.
Samuel Nelson
@nelsam
I'll keep an eye on it

I've been distracted lately, but I am still slowly changing the internal types in vidar so that they no longer embed the mixins types - i.e. instead of

type Editor struct {
    mixins.CodeEditor
    // Other fields...
}

we will have:

type Editor struct {
    box ui.TextBox // the gxui.CodeEditor is stored here
}
this will decouple vidar from gxui so that if/when we change to fyne or shiny or some other UI, all we have to do is make a quick wrapper package that acts like our ui types expect
Kvaz1r
@Kvaz1r
It's reasonable way, it will be much easier change something in one place. Just from curiosity are you did for now many changes by comparison to github master branch?
Samuel Nelson
@nelsam
There are a bunch of changes to the core parts of vidar (commander, editor, etc), but the command package should mostly stay the same.
Samuel Nelson
@nelsam
@Kvaz1r just FYI: I think I finally tracked down that lockup when selecting text. I merged a fix here: nelsam/gxui#19
Kvaz1r
@Kvaz1r
great, I sometimes watched this behaviour but always thought the problem in my old laptop :D
Kvaz1r
@Kvaz1r
@nelsam , Go team active develop gopls tool("is an implementation of the Language Server Protocol (LSP) server for Go. LSP allows any text editor to be extended with IDE-like features (see https://langserver.org for details)"). It seems very perspective and I think it will interesting to you.
Samuel Nelson
@nelsam
yeah, I've been staring at it pretty often with the hopes of using it soon
I'm not quite ready to work on that yet though
if you want to start working on it, feel free :)
Kvaz1r
@Kvaz1r
no, it looks like a hard one issue and I am not a big fun of such tasks =)
Kvaz1r
@Kvaz1r
but if you know some simple or at least simpler issue I would like implement it since next month I will have some time for open source.
Samuel Nelson
@nelsam
I had forgotten about the PRs on gxui; just went through and reviewed them all
Kvaz1r
@Kvaz1r
great. If I remember correctly after github.com/nelsam/gxui/pull/16/ will be possible to simplify tab swithing.
I am going to implement fix for #178 but not sure how better to do it. What should be extended - struct Find or FindBox ?
Samuel Nelson
@nelsam
the main logic needs to be on Find, but you should add some key bindings (e.g. ctrl-n and ctrl-p) to the FindBox, too
you'll have to override KeyPress(event gxui.KeyboardEvent) (consume bool) on the FindBox in order to handle key bindings
we could alternatively bind entirely separate commands in order to cycle through all selections in the file, but that probably isn't ideal since I'm planning to change find anyway
Kvaz1r
@Kvaz1r
the thin thing for me is how add new controls to the Find because I don't see how it layouts existing widgets.
Samuel Nelson
@nelsam
you should be able to update f.Start so that instead of f.next = f.pattern, you do:
patternLayout = theme.CreateLinearLayout()
patternLayout.Add(f.pattern)
patternLayout.Add(prev)
patternLayout.Add(next)
f.next = patternLayout
Kvaz1r
@Kvaz1r
ahh, right. But LinearLayout doesn't fit here because f.next require Focusable. Maybe make File LinearLayout as it done for Locator?
Samuel Nelson
@nelsam
I'd make a separate custom LinearLayout with Focusable methods, similar to Locator except keeping File a separate type
embedding gxui logic into our types that deal with logic was a big mistake that I'm still trying to fix in a different branch