Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Enrico Olivelli
    @eolivelli

    @normanmaurer this is the memory counter patch netty/netty#8945 thanks.

    I am working on the heap dump (but it is huge), but I think that current discussion already helped me a lot in understanding the mechanics of using Netty allocators out side Netty threads. So I think I won't find much valueable data in the dump.

    Norman Maurer
    @normanmaurer
    @eolivelli ok cool… let me know if you have any more questions etc
    Norman Maurer
    @normanmaurer
    @eolivelli @martinfurmanski the PR was merged
    Enrico Olivelli
    @eolivelli
    @normanmaurer I saw. Longing now for a release :-)
    Martin Furmanski
    @martinfurmanski
    @normanmaurer Tres cool. Also looking forward to the next release!
    Lukasz
    @lradziwonowicz

    Hi, simple application which returns fastest result of two WebClient requests using Mono.first(). The application is failing with LEAK error:

    2019-03-28 10:52:21.203 ERROR 25237 --- [or-http-epoll-4] io.netty.util.ResourceLeakDetector       : LEAK: ByteBuf.release() was not called before it's garbage-collected. See http://netty.io/wiki/reference-counted-objects.html for more information.

    I prepared POC with full error logs: https://github.com/lradziwonowicz/spring-boot-webflux-webclient-netty-leak Should I create a bug or my approach is not correct?

    Norman Maurer
    @normanmaurer
    @lradziwonowicz I think you should ask in the reactor / spring forums
    it basically tells you release() was not called. I guess this should be done as part of the reactor / spring integration tho
    Violeta Georgieva
    @violetagg
    @lradziwonowicz let’s discuss it here https://gitter.im/reactor/reactor You might want to try with the latest Californium-SR6 (put this property <reactor-bom.version>Californium-SR6</reactor-bom.version> in the pom.xml)
    Actially from the code - you consume just the status code and do not consume the body and thus your code will leak the memory
    you might want to check these two links
    bodyToMono(Void.class)
    Lukasz
    @lradziwonowicz
    @violetagg ok, that was only an example, my original application was consuming the body, where to put Californium-SR6 inside of pom.xml, <properties>?
    Violeta Georgieva
    @violetagg
    yep
    Lukasz
    @lradziwonowicz
    ok, but maven did not download anything new, is this ok?
    Violeta Georgieva
    @violetagg
    Reactor Core should be version 3.2.8 and Reactor Netty 0.8.6?
    Lukasz
    @lradziwonowicz
    ok, I see it in dependency tree, I'll test it, thx for the links
    Violeta Georgieva
    @violetagg
    :+1:
    Lukasz
    @lradziwonowicz
    @violetagg cool, it is working, the LEAK is gone. I'll test it with my original application
    Violeta Georgieva
    @violetagg
    also you might want to try then Spring Framework 5.1.6 snapshots there are some fixes related to memory leaks
    Nouras Hamwi
    @NourasHamwi
    I am using netty with apache camel and it works fine on my local enviroment ( Mac ) but when I moved the project to Linux it is giving this error NettyProducer WARN No payload to send for exchange
    Any idea what could be causing it ?
    Norman Maurer
    @normanmaurer
    Sorry I think you will need to ask on the camel mailing list
    Nouras Hamwi
    @NourasHamwi
    I got the issue resolved, it was a packaging proglem.
    Enrico Olivelli
    @eolivelli
    Hi guys. I am working on Maven Surefire. We are going to rewrite the communication system between core Maven process and forked JVMs in tests, we are going to use loopback network instead of stdout/stdin. We are currently discussing about using Netty because it will make it very simple to implement the protocol and it is, you know, very efficient.
    I have a concern about shading/relocating Netty bits and deploying it inside the forked JVM: this will "pollute" the environment for projects that are really using Netty.
    May I have an opinion from any of you ?
    Norman Maurer
    @normanmaurer
    not sure what to say here @eolivelli :D
    I think as it is only a test dependency I would not worry
    that said I think you must shade
    netty is too widely used to not shade
    Enrico Olivelli
    @eolivelli
    How would you see it to have a shaded org.apache.surefire.io.netty while running netty self tests ? Wouldn't it be a mess, looking at thread dumps for instance, or contents of ThreadLocals, log messages ?
    Norman Maurer
    @normanmaurer
    hmm no idea
    I would not be too concerned imho
    as long as it is shaded
    Enrico Olivelli
    @eolivelli
    ok, thanks for your feedback @normanmaurer
    Norman Maurer
    @normanmaurer
    np
    Francesco Nigro
    @franz1981
    Hi! I'm looking the single threaded event loops and which type of JCTools q they use...
    It seems the mpsc unbounded q, unless users specify a limit for the pending tasks...it is correct?
    Norman Maurer
    @normanmaurer
    yes
    Francesco Nigro
    @franz1981
    Nice one, so (fingers crossed)...On the next week I'm thiking to give it a shot to a new mpsc q I've implemented for JCTools
    I'm waiting Nitsan to review (and I'm sure, improve) it :)
    Norman Maurer
    @normanmaurer
    cool :)
    the XADD one ?
    (following jctools as well)
    Francesco Nigro
    @franz1981
    Yep :)
    I just need to undertand the use case: depends if the event loop mailbox is being stressed by multiple threads...starting from 2 the difference is "interesting" :)
    Norman Maurer
    @normanmaurer
    it depends :)
    Francesco Nigro
    @franz1981
    The king answer of computer science eheh
    Norman Maurer
    @normanmaurer
    exactly