Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 23 09:11
    AprilSylph review_requested #2012
  • Nov 20 19:10
    AprilSylph opened #2012
  • Nov 20 17:56

    AprilSylph on master

    package.json: install and use e… (compare)

  • Nov 20 17:56
    AprilSylph closed #2011
  • Nov 20 17:53

    github-actions[bot] on gh-pages

    Rebuild Distribution (compare)

  • Nov 20 17:52

    AprilSylph on master

    XKit Preferences: catch extensi… (compare)

  • Nov 20 17:52
    AprilSylph closed #2008
  • Nov 19 22:25
    AprilSylph review_requested #2011
  • Nov 19 22:25
    AprilSylph opened #2011
  • Nov 19 22:13
    marcustyphoon synchronize #1971
  • Nov 19 22:10
    marcustyphoon synchronize #1957
  • Nov 19 22:05
    marcustyphoon synchronize #1975
  • Nov 19 22:02
    marcustyphoon synchronize #1968
  • Nov 19 22:01
    marcustyphoon synchronize #1967
  • Nov 19 21:59
    marcustyphoon synchronize #1966
  • Nov 19 21:54
    marcustyphoon synchronize #1988
  • Nov 19 21:43
    marcustyphoon synchronize #1957
  • Nov 19 21:40
    marcustyphoon synchronize #1987
  • Nov 19 21:22
    AprilSylph review_requested #2008
  • Nov 19 21:20
    AprilSylph closed #2010
nightpool
@nightpool
@blackjackkent try using template strings. that’s helps a bit
BlackjackKent
@blackjackkent
@nightpool yeah, i may do. right now i'm just trying to strip out some of the cruft that isn't used anymore
cos there's like three redesigns worth of fallbacks in here
nightpool
@nightpool
(:
BlackjackKent
@blackjackkent
full disclosure -- it's gonna need further cleaning when i get the PR in. :P aiming for a working solution right now and will clean it up further some other time
nightpool
@nightpool
kk!
BlackjackKent
@blackjackkent
OCR PR is in
April Sylph
@AprilSylph
hey sorry if i seem nagging but i got a couple more reblogs today on my activity feed slimming extension that ive now built into a Tweak (#1326) so i thought i should bump that here, on their behalf
i know it seems minor but its a bit sad knowing people could have a single-click solution but dont
nightpool
@nightpool
Yeah, sorry, I’ve been too burnt out recently to do any coding stuff
Merged
Aku no Homu
@akunohomu
@nightpool add braces to all conditionals or only that one?
nightpool
@nightpool
there shouldn’t be any conditionals without braces...
something like if (whatever) { thing } is okay (basically due to historical precedent
but imo stuff like
if (whatever)
     thing
isn't
Aku no Homu
@akunohomu
Fixed in PR
BlackjackKent
@blackjackkent
@/all could I get #1337 reviewed please?
nightpool
@nightpool
@blackjackkent oh, shit, thanks for the reminder
looking at it now
BlackjackKent
@blackjackkent
:+1:
nightpool
@nightpool
Did you test it on the dashboard?
BlackjackKent
@blackjackkent
yeah
all of that was still working
nightpool
@nightpool
did you test it with classic notifications?
nightpool
@nightpool
replying to multiple notifications is broken
BlackjackKent
@blackjackkent
hmm
i tested that...
sec
nightpool
@nightpool
I’m testing on things like likes and reblogs w/o text too, maybe that’s the problem?
xkit.js:860 Uncaught TypeError: Cannot read property 'replace' of undefined
    at Object.replace_all (xkit.js:860)
    at Object.strip_sentence (xkit/one_click_reply.js:841)
BlackjackKent
@blackjackkent
ahhh. maybe
grrr. there are so many goddamn use casses for this thing :P
all right i'll poke it further when i get home
nightpool
@nightpool
nope, still happening with all replies
BlackjackKent
@blackjackkent
blargle
nightpool
@nightpool
also I don’t see any indication I selected multiple things?
BlackjackKent
@blackjackkent
i know for a fact i tested it. must have had a regression working on something else
nightpool
@nightpool
did you test it on the dashboard or on the activity page?
it works on the dashboard
BlackjackKent
@blackjackkent
activity
BlackjackKent
@blackjackkent
riddle me this, batman. i'm setting a value in settings and verified that it can be retrieved with get_setting(), and then when the page reloads and the setting is retrieved it has a different value in it.
(OCR)
has anyone encountered something like this before?
nightpool
@nightpool
is there another tab that’s also setting the setting, differently?
how long is it between setting the setting and reloading the page?
BlackjackKent
@blackjackkent
like fifteen seconds
and i'm not touching anything else
nightpool
@nightpool
do you have other tabs open?
BlackjackKent
@blackjackkent
no, just the extension editor