by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 13:38
    AprilSylph closed #1645
  • May 27 15:08
    AprilSylph edited #1836
  • May 27 15:04
    AprilSylph opened #1837
  • May 27 13:43
    AprilSylph opened #1836
  • May 27 01:05
    AprilSylph commented #1835
  • May 26 22:43
    AprilSylph edited #1834
  • May 26 19:00
    AprilSylph labeled #1835
  • May 26 19:00
    AprilSylph labeled #1835
  • May 26 19:00
    AprilSylph opened #1835
  • May 26 18:43
    AprilSylph labeled #1834
  • May 26 18:43
    AprilSylph labeled #1834
  • May 26 18:43
    AprilSylph opened #1834
  • May 22 19:10
    AprilSylph opened #1833
  • May 20 16:30
    AprilSylph edited #1802
  • May 20 16:27

    NewXKitBot on gh-pages

    Rebuild distribution based on 3… (compare)

  • May 20 16:25

    AprilSylph on master

    Release 7.9.2 (#1831) (compare)

  • May 20 16:25
    AprilSylph closed #1831
  • May 20 16:23

    AprilSylph on v7.9.2

    (compare)

  • May 19 00:53
    hobinjk commented #1831
  • May 18 22:20
    AprilSylph opened #1832
BlackjackKent
@blackjackkent
all of that was still working
nightpool
@nightpool
did you test it with classic notifications?
nightpool
@nightpool
replying to multiple notifications is broken
BlackjackKent
@blackjackkent
hmm
i tested that...
sec
nightpool
@nightpool
I’m testing on things like likes and reblogs w/o text too, maybe that’s the problem?
xkit.js:860 Uncaught TypeError: Cannot read property 'replace' of undefined
    at Object.replace_all (xkit.js:860)
    at Object.strip_sentence (xkit/one_click_reply.js:841)
BlackjackKent
@blackjackkent
ahhh. maybe
grrr. there are so many goddamn use casses for this thing :P
all right i'll poke it further when i get home
nightpool
@nightpool
nope, still happening with all replies
BlackjackKent
@blackjackkent
blargle
nightpool
@nightpool
also I don’t see any indication I selected multiple things?
BlackjackKent
@blackjackkent
i know for a fact i tested it. must have had a regression working on something else
nightpool
@nightpool
did you test it on the dashboard or on the activity page?
it works on the dashboard
BlackjackKent
@blackjackkent
activity
BlackjackKent
@blackjackkent
riddle me this, batman. i'm setting a value in settings and verified that it can be retrieved with get_setting(), and then when the page reloads and the setting is retrieved it has a different value in it.
(OCR)
has anyone encountered something like this before?
nightpool
@nightpool
is there another tab that’s also setting the setting, differently?
how long is it between setting the setting and reloading the page?
BlackjackKent
@blackjackkent
like fifteen seconds
and i'm not touching anything else
nightpool
@nightpool
do you have other tabs open?
BlackjackKent
@blackjackkent
no, just the extension editor
BlackjackKent
@blackjackkent
i'll have to dig more when i get home and can focus on it. was just curious if anyone'd run across this before.
nightpool
@nightpool
i’ve seen this before, when there’s contention on the storage, such as with blogtracker
nightpool
@nightpool
what is this icon?
i’m assuming it’s one of ours but i’ve Never seen it before
ThePsionic
@ThePsionic
:thinking:
wow gitter update your emoji
BlackjackKent
@blackjackkent
clearly it's wee uncle tim
it doesn't ring a bell to me either
BlackjackKent
@blackjackkent
i figured out the OCR storage thing! [happy dance]
nightpool
@nightpool
ooh, what was it?
BlackjackKent
@blackjackkent
in some of my code reorganization i had accidentally made it so the event handler on the activity page button was being rebound multiple times. so it would fire several times on click, one of which was firing after the rest of the code unselected all the selected replies
so that last handler was processing asif you'd only selected one reply
nightpool
@nightpool
aaaah
blackjackkent @blackjackkent grumbles
nightpool
@nightpool
at least the activity page is back now
BlackjackKent
@blackjackkent
weirdness
updated the PR if you want to take another look when you have a chance
nightpool
@nightpool
Ah, right.
I was gonna approve that and then forgot
BlackjackKent
@blackjackkent
all good, haha
nightpool
@nightpool

@/all Happy second birthday, New XKit

new-xkit/XKit@c497326