Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 29 13:52
    AprilSylph commented #1802
  • Oct 29 09:29
    baby-bot commented #1802
  • Oct 28 15:39
    AprilSylph edited #1802
  • Oct 21 14:20
    AprilSylph closed #2005
  • Oct 21 14:20
    AprilSylph commented #2005
  • Oct 21 14:03
    amartiniglass opened #2005
  • Oct 19 05:06
    fyrepanda closed #2004
  • Oct 19 05:03
    fyrepanda opened #2004
  • Oct 18 19:32
    AprilSylph closed #2003
  • Oct 18 19:32
    AprilSylph commented #2003
  • Oct 18 19:30
    mar2357 opened #2003
  • Oct 13 20:39
    AprilSylph edited #1802
  • Oct 13 20:39
    AprilSylph edited #1802
  • Oct 13 01:26
    AprilSylph closed #2002
  • Oct 13 01:26
    AprilSylph commented #2002
  • Oct 13 01:17
    x-atalana opened #2002
  • Oct 09 14:50
    AprilSylph edited #1794
  • Oct 09 03:40
    AprilSylph closed #1770
  • Oct 09 03:40
    AprilSylph commented #1770
  • Oct 09 03:24
    AprilSylph edited #1802
BlackjackKent
@blackjackkent
(OCR)
has anyone encountered something like this before?
nightpool
@nightpool
is there another tab that’s also setting the setting, differently?
how long is it between setting the setting and reloading the page?
BlackjackKent
@blackjackkent
like fifteen seconds
and i'm not touching anything else
nightpool
@nightpool
do you have other tabs open?
BlackjackKent
@blackjackkent
no, just the extension editor
BlackjackKent
@blackjackkent
i'll have to dig more when i get home and can focus on it. was just curious if anyone'd run across this before.
nightpool
@nightpool
i’ve seen this before, when there’s contention on the storage, such as with blogtracker
nightpool
@nightpool
what is this icon?
i’m assuming it’s one of ours but i’ve Never seen it before
ThePsionic
@ThePsionic
:thinking:
wow gitter update your emoji
BlackjackKent
@blackjackkent
clearly it's wee uncle tim
it doesn't ring a bell to me either
BlackjackKent
@blackjackkent
i figured out the OCR storage thing! [happy dance]
nightpool
@nightpool
ooh, what was it?
BlackjackKent
@blackjackkent
in some of my code reorganization i had accidentally made it so the event handler on the activity page button was being rebound multiple times. so it would fire several times on click, one of which was firing after the rest of the code unselected all the selected replies
so that last handler was processing asif you'd only selected one reply
nightpool
@nightpool
aaaah
blackjackkent @blackjackkent grumbles
nightpool
@nightpool
at least the activity page is back now
BlackjackKent
@blackjackkent
weirdness
updated the PR if you want to take another look when you have a chance
nightpool
@nightpool
Ah, right.
I was gonna approve that and then forgot
BlackjackKent
@blackjackkent
all good, haha
nightpool
@nightpool

@/all Happy second birthday, New XKit

new-xkit/XKit@c497326

BlackjackKent
@blackjackkent
whoo! \ o /
blackjackkent @blackjackkent quietly nudges @nightpool and makes puppy dog eyes about #1337
nightpool
@nightpool
In on mobile so I can't leave comments, but can you flip the if check so that pn_mode comes before the hasClass? One is much more expensive then the other
James Hobin
@hobinjk
:confetti_ball: :tada: :confetti_ball: here's to two years of being not sure whether to curse Atesh or Staff
Aku no Homu
@akunohomu
new-xkit/XKit#1342 Timestamps doesn't work (for me) on search pages so made some notes on fixing it. I don't understand how to add text to a post on the search page without screwing up the positioning of everything in the post, though, so can't make a PR.
BlackjackKent
@blackjackkent
ack, @nightpool i did miss that comment, sorry -- i can toss another PR for that update soon
thanks for merging tho :)
BlackjackKent
@blackjackkent
@/all OCP seems to be borked in firefox
looking into it now but my time while at work is limited if someone wants to get ot it first
BlackjackKent
@blackjackkent
update - XKit.interface.kitty.get returns an undefined value for kitty_data.kitten in firefox but not chrome
nightpool
@nightpool
uh oh
BlackjackKent
@blackjackkent
sec
might be onto it
@nightpool at a glance i can see the necessary header ( X-tumblr-secure-form-key) in the response to the kitty request, but getResponseHeader() isn't grabbing it for some resaon. Possibly case-sensitive? i have to go to a meeting if you want to look at this; otherwise i'll work on it when i get back.
it's xkit_patches.js:752
nightpool
@nightpool
i’m assuming this is because we don’t have access to the headers for some reason
BlackjackKent
@blackjackkent
eh. getresponseheaders is working elsewhere i think
it looks like the response has X-Tumblr-Secure-Form-Key but we're getting X-tumblr-secure-form-key...which is why i'm wondering if firefox is more stringent about case sensitivity or something