Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 15:38
    AprilSylph opened #1763
  • Feb 25 04:25

    NewXKitBot on gh-pages

    Rebuild distribution based on c… (compare)

  • Feb 25 04:25
    hobinjk commented #1762
  • Feb 25 04:24

    hobinjk on no_more_ints

    (compare)

  • Feb 25 04:24

    hobinjk on master

    remove some more parseInts bump version ugh and 2 more (compare)

  • Feb 25 04:24
    hobinjk closed #1762
  • Feb 25 01:43
    nightpool synchronize #1762
  • Feb 25 01:43

    nightpool on no_more_ints

    fix bookmarker test logic (compare)

  • Feb 25 01:26
    nightpool synchronize #1762
  • Feb 25 01:26

    nightpool on no_more_ints

    fuck eslint for making upgrades… (compare)

  • Feb 25 01:15
    nightpool synchronize #1762
  • Feb 25 01:15

    nightpool on no_more_ints

    ugh (compare)

  • Feb 25 00:53
    nightpool synchronize #1762
  • Feb 25 00:53

    nightpool on no_more_ints

    bump version (compare)

  • Feb 25 00:50
    nightpool opened #1762
  • Feb 25 00:48

    nightpool on no_more_ints

    remove some more parseInts (compare)

  • Feb 25 00:12

    NewXKitBot on gh-pages

    Rebuild distribution based on b… (compare)

  • Feb 25 00:11

    AprilSylph on master

    end the nightmare: part 2 (#176… (compare)

  • Feb 25 00:11
    AprilSylph closed #1761
  • Feb 25 00:11
    AprilSylph closed #1760
nightpool
@nightpool
at least the activity page is back now
BlackjackKent
@blackjackkent
weirdness
updated the PR if you want to take another look when you have a chance
nightpool
@nightpool
Ah, right.
I was gonna approve that and then forgot
BlackjackKent
@blackjackkent
all good, haha
nightpool
@nightpool

@/all Happy second birthday, New XKit

new-xkit/XKit@c497326

BlackjackKent
@blackjackkent
whoo! \ o /
blackjackkent @blackjackkent quietly nudges @nightpool and makes puppy dog eyes about #1337
nightpool
@nightpool
In on mobile so I can't leave comments, but can you flip the if check so that pn_mode comes before the hasClass? One is much more expensive then the other
James Hobin
@hobinjk
:confetti_ball: :tada: :confetti_ball: here's to two years of being not sure whether to curse Atesh or Staff
Aku no Homu
@akunohomu
new-xkit/XKit#1342 Timestamps doesn't work (for me) on search pages so made some notes on fixing it. I don't understand how to add text to a post on the search page without screwing up the positioning of everything in the post, though, so can't make a PR.
BlackjackKent
@blackjackkent
ack, @nightpool i did miss that comment, sorry -- i can toss another PR for that update soon
thanks for merging tho :)
BlackjackKent
@blackjackkent
@/all OCP seems to be borked in firefox
looking into it now but my time while at work is limited if someone wants to get ot it first
BlackjackKent
@blackjackkent
update - XKit.interface.kitty.get returns an undefined value for kitty_data.kitten in firefox but not chrome
nightpool
@nightpool
uh oh
BlackjackKent
@blackjackkent
sec
might be onto it
@nightpool at a glance i can see the necessary header ( X-tumblr-secure-form-key) in the response to the kitty request, but getResponseHeader() isn't grabbing it for some resaon. Possibly case-sensitive? i have to go to a meeting if you want to look at this; otherwise i'll work on it when i get back.
it's xkit_patches.js:752
nightpool
@nightpool
i’m assuming this is because we don’t have access to the headers for some reason
BlackjackKent
@blackjackkent
eh. getresponseheaders is working elsewhere i think
it looks like the response has X-Tumblr-Secure-Form-Key but we're getting X-tumblr-secure-form-key...which is why i'm wondering if firefox is more stringent about case sensitivity or something
nightpool
@nightpool
maybe
BlackjackKent
@blackjackkent
confirmed
just tested it in the console
headers.png
#themoreyouknow
nightpool
@nightpool
this is definitely a new thing
BlackjackKent
@blackjackkent
i'm off to meetings but i'll get a PR in later unless you want to
nightpool
@nightpool
they used to serve it as all lowercase
BlackjackKent
@blackjackkent
yeah
might be worth checking other places we use getresponseheader
if there are any
nightpool
@nightpool
is X-tumblr-kittens still lowercase?
BlackjackKent
@blackjackkent
lemme check
nightpool
@nightpool
image.png
BlackjackKent
@blackjackkent
wat
nightpool
@nightpool
502 (success)
looks like Tumblr-Kittens was updated
BlackjackKent
@blackjackkent
nightpool
@nightpool
which will cause problems nearly everywhere
BlackjackKent
@blackjackkent
oy
not everywhere
i see eight references to it in the codebase
not crazy hard to fix
i see eighteen uses of getresponseheader altogether