Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 11 23:09
    AprilSylph opened #1756
  • Jan 08 04:40
    AprilSylph edited #1755
  • Jan 07 20:44
    AprilSylph opened #1755
  • Jan 06 17:19
    AprilSylph synchronize #1754
  • Jan 06 05:25
    AprilSylph opened #1754
  • Jan 06 00:10

    NewXKitBot on gh-pages

    Rebuild distribution based on 3… (compare)

  • Jan 05 23:41

    AprilSylph on master

    [Read More Now] Don't activate … (compare)

  • Jan 05 23:41
    AprilSylph closed #1753
  • Jan 05 04:18
    AprilSylph opened #1753
  • Dec 03 2019 17:22
    AprilSylph synchronize #1752
  • Dec 03 2019 17:18
    AprilSylph synchronize #1752
  • Dec 03 2019 02:16
    AprilSylph synchronize #1751
  • Dec 02 2019 21:39
    oneirisme commented #1665
  • Dec 02 2019 05:14
    AprilSylph edited #995
  • Dec 02 2019 05:14
    AprilSylph edited #995
  • Dec 02 2019 05:03
    drmstwizard commented #1665
  • Dec 02 2019 02:48
    nightpool commented #1665
  • Dec 02 2019 02:09
    oneirisme commented #1665
  • Nov 30 2019 20:22

    NewXKitBot on gh-pages

    Rebuild distribution based on e… (compare)

  • Nov 30 2019 20:21

    AprilSylph on master

    rewrite Tag Replacer (#1749) (compare)

nightpool
@nightpool
In on mobile so I can't leave comments, but can you flip the if check so that pn_mode comes before the hasClass? One is much more expensive then the other
James Hobin
@hobinjk
:confetti_ball: :tada: :confetti_ball: here's to two years of being not sure whether to curse Atesh or Staff
Aku no Homu
@akunohomu
new-xkit/XKit#1342 Timestamps doesn't work (for me) on search pages so made some notes on fixing it. I don't understand how to add text to a post on the search page without screwing up the positioning of everything in the post, though, so can't make a PR.
BlackjackKent
@blackjackkent
ack, @nightpool i did miss that comment, sorry -- i can toss another PR for that update soon
thanks for merging tho :)
BlackjackKent
@blackjackkent
@/all OCP seems to be borked in firefox
looking into it now but my time while at work is limited if someone wants to get ot it first
BlackjackKent
@blackjackkent
update - XKit.interface.kitty.get returns an undefined value for kitty_data.kitten in firefox but not chrome
nightpool
@nightpool
uh oh
BlackjackKent
@blackjackkent
sec
might be onto it
@nightpool at a glance i can see the necessary header ( X-tumblr-secure-form-key) in the response to the kitty request, but getResponseHeader() isn't grabbing it for some resaon. Possibly case-sensitive? i have to go to a meeting if you want to look at this; otherwise i'll work on it when i get back.
it's xkit_patches.js:752
nightpool
@nightpool
i’m assuming this is because we don’t have access to the headers for some reason
BlackjackKent
@blackjackkent
eh. getresponseheaders is working elsewhere i think
it looks like the response has X-Tumblr-Secure-Form-Key but we're getting X-tumblr-secure-form-key...which is why i'm wondering if firefox is more stringent about case sensitivity or something
nightpool
@nightpool
maybe
BlackjackKent
@blackjackkent
confirmed
just tested it in the console
headers.png
#themoreyouknow
nightpool
@nightpool
this is definitely a new thing
BlackjackKent
@blackjackkent
i'm off to meetings but i'll get a PR in later unless you want to
nightpool
@nightpool
they used to serve it as all lowercase
BlackjackKent
@blackjackkent
yeah
might be worth checking other places we use getresponseheader
if there are any
nightpool
@nightpool
is X-tumblr-kittens still lowercase?
BlackjackKent
@blackjackkent
lemme check
nightpool
@nightpool
image.png
BlackjackKent
@blackjackkent
wat
nightpool
@nightpool
502 (success)
looks like Tumblr-Kittens was updated
BlackjackKent
@blackjackkent
nightpool
@nightpool
which will cause problems nearly everywhere
BlackjackKent
@blackjackkent
oy
not everywhere
i see eight references to it in the codebase
not crazy hard to fix
i see eighteen uses of getresponseheader altogether
lol and four of those are jquery
so. not too bad, i think
BlackjackKent
@blackjackkent
...okay wait it just started working again
what the fuck
BlackjackKent
@blackjackkent
[sigh] okay it randomly started working for me but not for the person who reported hte issue so maybe something else is going on here
i'll get back to you
also #1347 i guess
BlackjackKent
@blackjackkent
nope. i was right the first time. the change i made in the xkit_editor was working but not showing up in the debugger
i'll fix this when i get home