by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 07:25
    Poopooracoocoo commented #1946
  • Sep 23 19:44
    marcustyphoon synchronize #1988
  • Sep 23 18:14
    AprilSylph edited #1794
  • Sep 23 18:12

    github-actions[bot] on gh-pages

    Rebuild Distribution (compare)

  • Sep 23 18:11

    AprilSylph on master

    remove Hermes (#1999) (compare)

  • Sep 23 18:11
    AprilSylph closed #1999
  • Sep 23 16:58
    AprilSylph opened #1999
  • Sep 23 06:48
    marcustyphoon synchronize #1988
  • Sep 23 06:40
    marcustyphoon synchronize #1996
  • Sep 22 12:29
    marcustyphoon synchronize #1986
  • Sep 22 10:18
    marcustyphoon synchronize #1988
  • Sep 22 07:26
    marcustyphoon edited #1996
  • Sep 22 07:24
    marcustyphoon synchronize #1996
  • Sep 22 01:46
    nobodysuspectsthebutterfly closed #1992
  • Sep 21 21:45
    FlowerMom7 opened #1998
  • Sep 21 17:54
    kswanson33 commented #1973
  • Sep 21 17:49
    kswanson33 synchronize #1973
  • Sep 20 00:41
    marcustyphoon edited #1988
  • Sep 20 00:40
    marcustyphoon ready_for_review #1988
  • Sep 20 00:40
    marcustyphoon synchronize #1988
BlackjackKent
@blackjackkent
ack, @nightpool i did miss that comment, sorry -- i can toss another PR for that update soon
thanks for merging tho :)
BlackjackKent
@blackjackkent
@/all OCP seems to be borked in firefox
looking into it now but my time while at work is limited if someone wants to get ot it first
BlackjackKent
@blackjackkent
update - XKit.interface.kitty.get returns an undefined value for kitty_data.kitten in firefox but not chrome
nightpool
@nightpool
uh oh
BlackjackKent
@blackjackkent
sec
might be onto it
@nightpool at a glance i can see the necessary header ( X-tumblr-secure-form-key) in the response to the kitty request, but getResponseHeader() isn't grabbing it for some resaon. Possibly case-sensitive? i have to go to a meeting if you want to look at this; otherwise i'll work on it when i get back.
it's xkit_patches.js:752
nightpool
@nightpool
i’m assuming this is because we don’t have access to the headers for some reason
BlackjackKent
@blackjackkent
eh. getresponseheaders is working elsewhere i think
it looks like the response has X-Tumblr-Secure-Form-Key but we're getting X-tumblr-secure-form-key...which is why i'm wondering if firefox is more stringent about case sensitivity or something
nightpool
@nightpool
maybe
BlackjackKent
@blackjackkent
confirmed
just tested it in the console
headers.png
#themoreyouknow
nightpool
@nightpool
this is definitely a new thing
BlackjackKent
@blackjackkent
i'm off to meetings but i'll get a PR in later unless you want to
nightpool
@nightpool
they used to serve it as all lowercase
BlackjackKent
@blackjackkent
yeah
might be worth checking other places we use getresponseheader
if there are any
nightpool
@nightpool
is X-tumblr-kittens still lowercase?
BlackjackKent
@blackjackkent
lemme check
nightpool
@nightpool
image.png
BlackjackKent
@blackjackkent
wat
nightpool
@nightpool
502 (success)
looks like Tumblr-Kittens was updated
BlackjackKent
@blackjackkent
nightpool
@nightpool
which will cause problems nearly everywhere
BlackjackKent
@blackjackkent
oy
not everywhere
i see eight references to it in the codebase
not crazy hard to fix
i see eighteen uses of getresponseheader altogether
lol and four of those are jquery
so. not too bad, i think
BlackjackKent
@blackjackkent
...okay wait it just started working again
what the fuck
BlackjackKent
@blackjackkent
[sigh] okay it randomly started working for me but not for the person who reported hte issue so maybe something else is going on here
i'll get back to you
also #1347 i guess
BlackjackKent
@blackjackkent
nope. i was right the first time. the change i made in the xkit_editor was working but not showing up in the debugger
i'll fix this when i get home
James Hobin
@hobinjk
A
James Hobin
@hobinjk
Oh my god this phone is cancelled
BlackjackKent
@blackjackkent
lol
you okay there