Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 14:20
    AprilSylph closed #2005
  • 14:20
    AprilSylph commented #2005
  • 14:03
    amartiniglass opened #2005
  • Oct 19 05:06
    fyrepanda closed #2004
  • Oct 19 05:03
    fyrepanda opened #2004
  • Oct 18 19:32
    AprilSylph closed #2003
  • Oct 18 19:32
    AprilSylph commented #2003
  • Oct 18 19:30
    mar2357 opened #2003
  • Oct 13 20:39
    AprilSylph edited #1802
  • Oct 13 20:39
    AprilSylph edited #1802
  • Oct 13 01:26
    AprilSylph closed #2002
  • Oct 13 01:26
    AprilSylph commented #2002
  • Oct 13 01:17
    x-atalana opened #2002
  • Oct 09 14:50
    AprilSylph edited #1794
  • Oct 09 03:40
    AprilSylph closed #1770
  • Oct 09 03:40
    AprilSylph commented #1770
  • Oct 09 03:24
    AprilSylph edited #1802
  • Oct 09 03:24
    AprilSylph edited #1794
  • Oct 09 03:20
    AprilSylph edited #1802
  • Oct 07 06:38
    marcustyphoon synchronize #1968
BlackjackKent
@blackjackkent
sec
might be onto it
@nightpool at a glance i can see the necessary header ( X-tumblr-secure-form-key) in the response to the kitty request, but getResponseHeader() isn't grabbing it for some resaon. Possibly case-sensitive? i have to go to a meeting if you want to look at this; otherwise i'll work on it when i get back.
it's xkit_patches.js:752
nightpool
@nightpool
i’m assuming this is because we don’t have access to the headers for some reason
BlackjackKent
@blackjackkent
eh. getresponseheaders is working elsewhere i think
it looks like the response has X-Tumblr-Secure-Form-Key but we're getting X-tumblr-secure-form-key...which is why i'm wondering if firefox is more stringent about case sensitivity or something
nightpool
@nightpool
maybe
BlackjackKent
@blackjackkent
confirmed
just tested it in the console
headers.png
#themoreyouknow
nightpool
@nightpool
this is definitely a new thing
BlackjackKent
@blackjackkent
i'm off to meetings but i'll get a PR in later unless you want to
nightpool
@nightpool
they used to serve it as all lowercase
BlackjackKent
@blackjackkent
yeah
might be worth checking other places we use getresponseheader
if there are any
nightpool
@nightpool
is X-tumblr-kittens still lowercase?
BlackjackKent
@blackjackkent
lemme check
nightpool
@nightpool
image.png
BlackjackKent
@blackjackkent
wat
nightpool
@nightpool
502 (success)
looks like Tumblr-Kittens was updated
BlackjackKent
@blackjackkent
nightpool
@nightpool
which will cause problems nearly everywhere
BlackjackKent
@blackjackkent
oy
not everywhere
i see eight references to it in the codebase
not crazy hard to fix
i see eighteen uses of getresponseheader altogether
lol and four of those are jquery
so. not too bad, i think
BlackjackKent
@blackjackkent
...okay wait it just started working again
what the fuck
BlackjackKent
@blackjackkent
[sigh] okay it randomly started working for me but not for the person who reported hte issue so maybe something else is going on here
i'll get back to you
also #1347 i guess
BlackjackKent
@blackjackkent
nope. i was right the first time. the change i made in the xkit_editor was working but not showing up in the debugger
i'll fix this when i get home
James Hobin
@hobinjk
A
James Hobin
@hobinjk
Oh my god this phone is cancelled
BlackjackKent
@blackjackkent
lol
you okay there
James Hobin
@hobinjk
I just wanted to use mobile gitter to be credit to team and "A" is what I get in return
BlackjackKent
@blackjackkent
lol
nightpool
@nightpool
mobile gitter is bad, actually
BlackjackKent
@blackjackkent
we should get on that switch to discord
one less window for me to have open
ThePsionic
@ThePsionic
^ I can cut my pinned tabs down from 23 to 22