Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 21:21
    AprilSylph opened #1741
  • Nov 11 05:45
    AprilSylph synchronize #1701
  • Nov 10 21:23
    AprilSylph commented #1701
  • Nov 10 21:19
    AprilSylph synchronize #1701
  • Nov 10 18:42
    AprilSylph synchronize #1701
  • Nov 10 18:35
    AprilSylph synchronize #1701
  • Nov 10 18:31
    AprilSylph synchronize #1701
  • Nov 07 20:56
    AprilSylph opened #1740
  • Nov 01 18:22

    NewXKitBot on gh-pages

    Rebuild distribution based on 2… (compare)

  • Nov 01 18:21

    AprilSylph on master

    Added "decrease left padding" o… (compare)

  • Nov 01 18:21
    AprilSylph closed #1738
  • Nov 01 18:18
    RetroAsgardian synchronize #1738
  • Oct 25 20:31
    AprilSylph closed #1739
  • Oct 25 20:31
    AprilSylph commented #1739
  • Oct 21 23:59
    Mormia opened #1739
  • Oct 15 03:35
    RetroAsgardian opened #1738
  • Oct 15 02:43

    NewXKitBot on gh-pages

    Rebuild distribution based on c… (compare)

  • Oct 15 02:41

    AprilSylph on master

    [Enhanced Queue] Don't require … (compare)

  • Oct 15 02:41
    AprilSylph closed #1737
  • Oct 15 02:41
    AprilSylph review_request_removed #1737
nightpool
@nightpool
which will cause problems nearly everywhere
BlackjackKent
@blackjackkent
oy
not everywhere
i see eight references to it in the codebase
not crazy hard to fix
i see eighteen uses of getresponseheader altogether
lol and four of those are jquery
so. not too bad, i think
BlackjackKent
@blackjackkent
...okay wait it just started working again
what the fuck
BlackjackKent
@blackjackkent
[sigh] okay it randomly started working for me but not for the person who reported hte issue so maybe something else is going on here
i'll get back to you
also #1347 i guess
BlackjackKent
@blackjackkent
nope. i was right the first time. the change i made in the xkit_editor was working but not showing up in the debugger
i'll fix this when i get home
James Hobin
@hobinjk
A
James Hobin
@hobinjk
Oh my god this phone is cancelled
BlackjackKent
@blackjackkent
lol
you okay there
James Hobin
@hobinjk
I just wanted to use mobile gitter to be credit to team and "A" is what I get in return
BlackjackKent
@blackjackkent
lol
nightpool
@nightpool
mobile gitter is bad, actually
BlackjackKent
@blackjackkent
we should get on that switch to discord
one less window for me to have open
ThePsionic
@ThePsionic
^ I can cut my pinned tabs down from 23 to 22
April Sylph
@AprilSylph
proposing a new extension is just a matter of adding the .js, .css and .icon.js to the Extensions folder right? its 3am and i am so burnt out lmao
nightpool
@nightpool
yep!
April Sylph
@AprilSylph
woohoo thanks
heres just hoping that direct copypaste from xkit editor to github works then
BlackjackKent
@blackjackkent
@nightpool i think this getResponseHeaders thing may be the result of a new firefox update. cos coming home today i oculdn't reproduce it, and then closed firefox and reopened, got some updates downloaded, and then got the bug
BlackjackKent
@blackjackkent
hmm
BlackjackKent
@blackjackkent
PR is in
nightpool
@nightpool
sorry, didn’t didn’t see this last night
do we have to worry about the headers we’re sending?
or just the ones we recieve?
nightpool
@nightpool
@blackjackkent I don’t have permission to push to that branch for some reason…..
ah nevermind figured it out! I was trying to push to the wrong branch, b/c hub messed me up
BlackjackKent
@blackjackkent
@nightpool just hte ones we receive i think; also weirdly enough that next-note header doesn't seem to show the problem
nightpool
@nightpool
hmm. really?
I pushed a fix anyway, because it looked uppercase in chrome
are you sure you didn’t get an updated version of the extension? because I just merged it
BlackjackKent
@blackjackkent
headers2.png
at a wild guess i htink the bug might be the fact that we're somehow shimming getResponseHeader for certain types of responses for firefox?
nightpool
@nightpool
oh, I guess jquery fixes it maybe?
huh
what version of firefox are you on btw?
BlackjackKent
@blackjackkent
self.port.on('cors-update', function(data) {
...
  // Augment with shim for XHR-expected fields
  // This could definitely be done better by looking into whether Response is
  // cloneable.
    data.response.getResponseHeader = function(key) {
        return this.headers[key];
    };
...
}
^ that's in the firefox bridge
54.0.1
as i mentioned, it seemed to kick in when i updated firefox, cos i wasn't seeing the issue on my home computer until i rebooted the browser and it installed osme stuff