These are chat archives for ngUpgraders/ng-forward

13th
Oct 2015
Hannah Howard
@hannahhoward
Oct 13 2015 18:43
Hey everyone, just getting aorund to finally contributing. Is there something specifically I should work on?
Tim Kindberg
@timkindberg
Oct 13 2015 19:28
Hi Hannah!
Well is there anything specific you'd like to work on?
pbastowski
@pbastowski
Oct 13 2015 19:53
Hi there.
Thanks Mike, I'll try that. Did you get my email? I sent it on 10th Oct... I thought you were too busy to reply :)
pbastowski
@pbastowski
Oct 13 2015 20:03
OK, so 145KB minified is really not great. You say that most of it is RX, so, is there something we could do about that? Perhaps we are using only a small portion of it? You mentioned, or it could have been Tim, that we might want to re-factor that part and use our own code... or is this a fantasy of mine :) Yeah, it's a fantasy, considering we only have a few days left till angular-connect. By the way, are any of you going to attend?
David Gang
@david-gang
Oct 13 2015 20:24
Hi
May I ask what the reason is that you use babel when angular 2 is written in Typescript?
pbastowski
@pbastowski
Oct 13 2015 20:36
Cause we like it :)
Tim Kindberg
@timkindberg
Oct 13 2015 21:02
Because we started with mike's angular-decorators repo which was using babel. Maybe we'll switch later.
@pbastowski I am not attending.
I think mike has some commits on a branch to reduce the size. Check the other branches in the repo.
Hannah Howard
@hannahhoward
Oct 13 2015 21:27
Hey! Sorry was away at lunch. Right now I am working on a basic starter package / more in depth example for ng-forward. Essentially, “here’s where you’d start if you decided to take the plunge and try to build your next production app with ng-forward"
After that I’m gonna work on the realm.
oops readme.
haha realm. Yes, I must tend to the realm, which needs it’s queen.
Also, has anyone done any work trying to get states going with ui-router? Also in general if you needed a config/run block, how would you go about using one? (considering the module interface is essentially hidden.
Tim Kindberg
@timkindberg
Oct 13 2015 21:29
Haha realm
pbastowski
@pbastowski
Oct 13 2015 21:30
@timkindberg Yeah, I just checked the core/bundling branch and it's like Mike says, about 24K.
I'm trying to get it to work now in plunker.
Tim Kindberg
@timkindberg
Oct 13 2015 21:30
@hannahhoward all good ideas to look into. There's some file in there for you a router but I can't remember if it's just a stub or actually working or what.
Hannah Howard
@hannahhoward
Oct 13 2015 21:32
what are we using Rx for? the events?
pbastowski
@pbastowski
Oct 13 2015 21:33
Yes, events, that's what Mike said last week.
Tim Kindberg
@timkindberg
Oct 13 2015 21:33
Yeah for Event emitter
Hannah Howard
@hannahhoward
Oct 13 2015 21:40
as a starting point for RxJS size drop, it appears simply doing “import ‘rx’” brings in rx.all.js from the node module — which is the mega-supersized RxJS. RxJS offers a bunch of smaller versions which I’m almost sure we could use especially since we’re using such a limited part of functionality. would just need some changes on the import statement.
Tim Kindberg
@timkindberg
Oct 13 2015 22:28
@hannahhoward Check the rx bundle branch. I think mike is pulling in rx lite.
Hannah Howard
@hannahhoward
Oct 13 2015 22:29
ah I see. I notice angular/angular is pulling from what I think is the next version of RxJS (@reactivex/rxjs) — which appears to allow you to import Subject directly, which maybe leads to a smaller bundle size? we’ll see.
Hannah Howard
@hannahhoward
Oct 13 2015 22:41
ngUpgraders/ng-forward#19 — switch to using the same RxJS version as Ng2, gets the build down to 65k minified including the needed parts of RxJS.
seems to pass tests on my machine but also I think that event emitter lacks a test :)
sorry I branched that off of master before I knew core/bundling was the branch to use then merged core/bundling into it.
pbastowski
@pbastowski
Oct 13 2015 23:26
Thanks, Hannah. I'll try that tomorrow. For now I'm off to bed ... it's 1:30 in the morning here.
Also, here is a link to a plunker example that sort of works: http://plnkr.co/edit/0Y5YdERniTisPFBZHNe3?p=preview
I had to add corejs, Reflectjs and regeneratorjs to get it to work. bootstrap doesn't work properly either - had to also add ng-app="app" to body. Inject of a class (service) also did not work. Had to add that in an array to bootstrap, before it started working. See script.js. Still many issues, but it sort of runs. Well, the example does very little atm, so, it has to run :)
Tim Kindberg
@timkindberg
Oct 13 2015 23:38
hmmm man that seems like quite a lot to make it work
I'm working til bed tonight
chat me up if needed @/all