These are chat archives for ngUpgraders/ng-forward

24th
Nov 2015
Tim Kindberg
@timkindberg
Nov 24 2015 14:43
@brandonroberts hey dude
Brandon
@brandonroberts
Nov 24 2015 14:44
@timkindberg Hey
Tim Kindberg
@timkindberg
Nov 24 2015 14:44
hey thanks for looking at the build
so what state is it all in?
looks like Symbols were the problem?
Brandon
@brandonroberts
Nov 24 2015 14:46
Yep. I think the tests may be leaking into each other, but I'm not sure. As far as the build goes, its back to normal
Tim Kindberg
@timkindberg
Nov 24 2015 14:46
So we can't use Symbols?
Brandon
@brandonroberts
Nov 24 2015 14:49
I don't think so. Mike ran into the same issue when using them. They don't work well in ES5
Tim Kindberg
@timkindberg
Nov 24 2015 14:53
hmmm
Brandon
@brandonroberts
Nov 24 2015 14:55
Then there is Travis using a very old version of Chrome ...
Tim Kindberg
@timkindberg
Nov 24 2015 14:55
which is kind of odd
maybe we should try PhantomJS
so you ended up not even upgrading babel at all
... I'd thought everything was failing because of the babel update
Brandon
@brandonroberts
Nov 24 2015 15:13
It's weird that everything just broke though, because Symbols had been in there for a while right?
Tim Kindberg
@timkindberg
Nov 24 2015 15:13
yea pretty sure
that was the commit
I'd love to keep the Symbols
it seems like to get things passing you had to disable a lot of stuff
Brandon
@brandonroberts
Nov 24 2015 15:18
Yea, it was mainly that one test spec. I'm not sure why sinon chai wasn't getting loaded for those tests
Brandon
@brandonroberts
Nov 24 2015 15:48
@timkindberg Ok. All tests that were previously running are passing now
Tim Kindberg
@timkindberg
Nov 24 2015 15:48
awesome
is it ready to merge?
Brandon
@brandonroberts
Nov 24 2015 15:52
Let me try the Symbols again real quick
Brandon
@brandonroberts
Nov 24 2015 16:01
@timkindberg Ok. I rebased/squashed everything into 1 commit. Once it passes its ready
:+1:
Tim Kindberg
@timkindberg
Nov 24 2015 16:12
Thanks Brandon!!!
I merged it... gonna pull down now and see how it works locally
Brandon
@brandonroberts
Nov 24 2015 16:13
:smile:
Ok
Tim Kindberg
@timkindberg
Nov 24 2015 16:54
It's working. And now finally, so can I. Thanks again @brandonroberts.
Brandon
@brandonroberts
Nov 24 2015 16:55
:+1:
Steven Weingärtner
@eXaminator
Nov 24 2015 19:28
Hi guys, do I need to do anything to build ng-forward besides running ./node_modules/.bin/gulp?
Brandon
@brandonroberts
Nov 24 2015 19:30
gulp build
Steven Weingärtner
@eXaminator
Nov 24 2015 19:31
build is the default task as far as I've seen... I get a couple of TypeScript and "bundle" errors
Brandon
@brandonroberts
Nov 24 2015 19:31
tsd install first
If you want the built in commands, use npm test
Steven Weingärtner
@eXaminator
Nov 24 2015 19:32
ah! tsd install did the trick :) Thanks!
Brandon
@brandonroberts
Nov 24 2015 19:33
np
Steven Weingärtner
@eXaminator
Nov 24 2015 19:43
Mh... I seem to have a bug with @Input() as I get the error TypeError: Cannot read property 'characters' of undefined where characters is the property I defined on the class which has the decorator. I use Babel 5.8 and ES6. Has anyone encountered this before or should I create an issue?