getWithQuery on collection services. When I called this method I am not able to use catchError for trapping API errors. Looking at the implementation of getWithQuery I notice that it's dispatching an action to make the request to the api, so the error is not able to bubble back to my subscription. Does anybody have any experience with trying to catch API errors when using getWithQuery ?
catchError
this.getResponseData$... and what I'm noticing is that catchError is never triggered even though I can see an error occurred in network tab in my dev tools
catchError should definitely get triggered, specifically for api errors, then perhaps my problem lies elsewhere
I have a typescript question. I'm extending Entity to extract relational keys from the entities.
export interface KeySelector<T> {[keyname: string]: IdSelectorStr<T>}
export interface EntityDefinition<T> {
selectId: IdSelector<T>;
sortComparer: false | Comparer<T>;
selectKey: KeySelector<T>;
}and then in the createEntity function
const { selectId, sortComparer, selectKey }: EntityDefinition<T> = {
sortComparer: false,
selectId: (instance: any) => instance.id,
selectKey: {'key': (instance: any) => instance.key},
...options,
};which is the default for an entity, to extract ids etc. It is being used like this:
export const adapter: EntityRelationAdapter<InventoryType> =
createEntityRelationAdapter<InventoryType>({
selectId: InventoryType => InventoryType.tid,
selectKey: {
resourcetype: InventoryType => InventoryType.resourcetype,
}
});TS2322: Type '{ [key: string]: string[]; } | ((instance: any) => any)' is not assignable to type 'IdSelectorStr<T>'. is the error
Removing noimplicitany from tsconfig it works fine, but I'm trying to type my code to find errors (which I have)
async onUpdateComment(payload: {layerId: number, comment: string}) {
this.store.dispatch(new AddComment(payload));
await this.reloadPage();
}
async reloadPage() {
this.store.dispatch(new LoadLayerCollection());
}
Hey guys, I used to be able to do the following with actions:
@Effect()
public myAction$: Observable<TheReturnedActionClass> = this.actions$.pipe(
ofType(SomeOtherAction),
mapTo(new TheReturnedActionClass())
) However, I am now creating actions with createAction method, which means I don't have access to the type of the action, for example:
const theReturnedActionFunction = createAction('[ACtion] theReturnedActionFunction');
@Effect()
public myAction$: Observable<WHATGOESHERE?> = this.actions$.pipe(
ofType(SomeOtherAction),
mapTo(theReturnedActionFunction())
)Any ideas on how I can access the type for the WHATGOESHERE part. I guess I could just use Action, but then that will be different to the rest of my application
the types through the effect carry through from ofType() if you use an action creator
...state,
categories: {
entities: { ...state.categories.entities, ...action.entities.categories },
ids: [...new Set([...action.ids.categoryIds, ...state.categories.ids])]
}, is that right?
Many
@johnazzolina_twitter components are responsible for displaying state only. My rule of thumb is that top level route components get data from the store and send actions to the store and all business rules are handled in the store selector (or on the server).... all other components are dumb... that is, they get there data via @Input and send events to the parent via @Output.
Components MAY have logic that help the display... this is handled by component services using the @Component viewProviders attribute. This keeps your components clean and puts your logic in a location that is easily testable.
The main point is ... business logic in the selector... component logic in the service.