These are chat archives for nightscout/beta

12th
Aug 2014
Tyler Rhodes
@trhodeos
Aug 12 2014 00:05
@rajatgupta431 see nightscout/cgm-remote-monitor#97 for the auto deploy functionality
note that the app.json's 'repository' field is for informational purposes only. heroku pulls the source from github's 'referer' header. So this will work automatically for forks (and branches, i believe)
Jason Calabrese
@jasoncalabrese
Aug 12 2014 00:14
@trhodeos thanks for the PR, it looks good. Only thing I think we should change is the Deploy label in the readme to [Deploy to Heroku]
never mind, saw that it's getting the image
Tyler Rhodes
@trhodeos
Aug 12 2014 00:16
yeah, but might as well change the placeholder text as well
updated.
Jason Calabrese
@jasoncalabrese
Aug 12 2014 00:18
thanks, one other thing, it's targeting master, and we merge to develop first then create a release to update master
I don't think there is a way to change the PR, really annoying
@pgdrews, the issue with the beta pebble app is that if there is a bad wifi or mobile connection the display can hang, while the time continues to update. There is a fix we can make to the c code for that, but I could use some help there.
Tyler Rhodes
@trhodeos
Aug 12 2014 00:22
@jasoncalabrese any convention on branch naming? looks like the prefix wip/ is preferred?
Jason Calabrese
@jasoncalabrese
Aug 12 2014 00:23
we're using wip/ for feature branches, but in this case we can merge your PR directly to develop
so your master to the develop branch in the community repo is fine
Tyler Rhodes
@trhodeos
Aug 12 2014 00:25
ah, gotcha
Jason Calabrese
@jasoncalabrese
Aug 12 2014 00:25
we really need to write some of this stuff down to make it easier to contribute
Jason Calabrese
@jasoncalabrese
Aug 12 2014 00:32
@bewest saw your comment about azure forcing you to fork, I think we can still add this. The FB users will never see the github page, and this is useful for development
I'll be back on later
Tyler Rhodes
@trhodeos
Aug 12 2014 00:53
I'll reply on github when I look into it a little bit more, but @bewest I'm sure that heroku has some sort of auto-restart functionality. As a PaaS, I picture that as a hard requirement. And with heroku, there is a UI for pushing updates as it doesn't sync with github's master, so it is also versioned (asynchronously from github) and the user is in full control of that. As for # of users, I'm a bit stuck there. Forking is an OK mechanism for doing so, given that the user has to fork anyway for controlled deployments for azure. But if we adopted the heroku model (less buttons to press/things to sign up for), that way of keeping metrics doesn't really make sense. we could maybe have some sort of opt-out analytics tag that runs on first-visit, with anonymization of course. That way we could keep track of # users / version. That may be overkill, but just thinking out loud here
Tyler Rhodes
@trhodeos
Aug 12 2014 01:55
Ok, thinking about more, the analytics may be overkill, but there has to be an easier way to keep track of active users anonymously
also, is it possible to get either OpenID or google logins working for the nightscout forums?
Ben West
@bewest
Aug 12 2014 02:22
I'm saying azure's policy is very ueseful to us
heroku I'm noticing people's sites go down often
yeah, metrics would make sense
metrics would solve it
opt in metrics
nightscout forums should have openid and google login
yeah, agree, jason we should go ahead and add it
it's nifty feature
Jason Calabrese
@jasoncalabrese
Aug 12 2014 02:52
@trhodeos think we just need a new PR that targets develop and we can merge this (unless someone knows an easy way to change a PR to point to a different)
Ben West
@bewest
Aug 12 2014 02:52
can't change existing PR
I saw commits from john applied to your branch jason
but was wondering if that should also be mini pr on develop
get it in sooner
Jason Calabrese
@jasoncalabrese
Aug 12 2014 02:54
John created the branch for the care-portal stuff, I just opened a PR so everyone would see it and have a place to comment
Ben West
@bewest
Aug 12 2014 02:55
ah
Tyler Rhodes
@trhodeos
Aug 12 2014 03:21
Yeah, I'll
Tyler Rhodes
@trhodeos
Aug 12 2014 03:45
*open a new PR next chance I get
Tyler Rhodes
@trhodeos
Aug 12 2014 03:53
Alright, opened nightscout/cgm-remote-monitor#98