so yeah you can write another recrusive algorithm
but after some entries I reach ENOENT: No such file or directory
but there's no reason this would move away from "underneath" me
also the fchownat always passes but fchmodat will then always fail
LOL these are all broken links during tests...
so thats my curse..
@otavio what's up?
but I'd like a full review
the rest seems good IMO
So I would like to split it as:
- rework existing code
- add new from methods
The Iterator I'd like to check how we could improve it
So we reduce the PR and keep it focused.
hi, I have the following function:
fn set_recording_mode(fd: RawFd, mode: u8) -> Result<i32, nix::Error>
{
ioctl_readwrite!(set_request2, 0x5A, MCU_SET, McuOp);
const SET_REC_MODE: u8 = 0xf4;
let mut req : [u8;2] = [mode,0];
let mut op = McuOp{r#type: SET_REC_MODE, len: 2, data: req.as_mut_ptr()};
println!("{:?}", op);
let ret = unsafe{ set_request2(fd, &mut op as *mut McuOp) };
ret
}which I'm calling in 2 different places in my code, with the same argument, and for some reason the first call succeeds and the second one fails, I ran it with strace and it looks like the ioctl call itself is the same:
~> time strace -e ioctl ./audio-test
McuOp { type: 244, len: 2, data: 0xffe78c7e }
ioctl(3, _IOC(_IOC_READ|_IOC_WRITE, 0x5a, 0x3, 0x80), 0xffe78c80) = 2
McuOp { type: 244, len: 2, data: 0xffe78c7e }
ioctl(3, _IOC(_IOC_READ|_IOC_WRITE, 0x5a, 0x3, 0x80), 0xffe78c80) = -1 EFAULT (Bad address)
thread 'main' panicked at 'Failed to set recording mode: Sys(EFAULT)', src/libcore/result.rs:999:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
+++ exited with 101 +++another weird thing that I noticed is that if I add prints in various places then (depending on the location of the prints) even the first call can fail.
any chance someone here has run into something like this and can help me understand what I'm doing wrong?
the definition of the struct I'm passing is this:
#[repr(C)]
#[repr(align(128))]
#[derive(Debug)]
pub struct McuOp {
r#type: u8 ,
len: u32 ,
data: *mut u8,
}
Of course, there is no hurry
I ask for release, because I have my project, which I'd like to publish on crates-io. Currently I have to depend on nix master.
(I'm reimplementing some syscall-heavy C stuff in Rust, and am pretty sketched out by the
libc crate. It doesn't have errno, and if there's an intended alternative, the documentation makes it incredibly hard to find. This sets an extremely low upper limit on how much battle testing that crate could have gotten.)
libc is difficult to use directly. It basically exists to make it possible for somebody to make a crate like Nix.
errno is weird because it's a global variable, not a function. See https://github.com/nix-rust/nix/blob/master/src/errno.rs for how to implement it.
@pyroxymat You need to check in the libc crate. https://github.com/rust-lang/libc . Of course, it's possible that it's supported by some OSes but hasn't been added to libc yet. In that case, the best place to check is in online man pages