Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 06 2016 09:11
    kalinchernev commented #25
  • Sep 15 2016 07:02

    martinheidegger on master

    Start Additional Lessons sectio… Add other substantially complet… Merge pull request #17 from lin… (compare)

  • Sep 15 2016 07:02
    martinheidegger closed #17
  • Sep 15 2016 07:01
    martinheidegger commented #17
  • Sep 15 2016 06:42

    martinheidegger on master

    Add Gitter badge Merge pull request #42 from git… (compare)

  • Sep 15 2016 06:42
    martinheidegger closed #42
  • Sep 15 2016 06:35
    gitter-badger opened #42
Anshul
@AnshulMalik
Okay
Martin Heidegger
@martinheidegger
Workshoppers should support all Node.js version branches that have at least one non-maintenance release that is less than a year old.
Within a branch it should support all releases that are less than a year old.
sthlikethat
Anshul
@AnshulMalik
This is a lot better :)
Martin Heidegger
@martinheidegger
:+1:
Would still be nice to have a script that renders the release range for the current day.
Anshul
@AnshulMalik
Yeah, that would be handy
Dusan Sacha
@DusanSacha
Hi, how do you guys check the changes in a PR before mergin it? Just with travis?
Or do you pull the changes to your local and play around a bit?
Martin Heidegger
@martinheidegger
yes, pulling the changes
Anshul
@AnshulMalik
Hey @martinheidegger
We were discussing how we should check the solution for correctness
workshopper/javascripting#196
Martin Heidegger
@martinheidegger
hey
uh, okay
and how can i help?
Anshul
@AnshulMalik
Will jasmine be a good choice ?
And can we take such kind of step ?
Martin Heidegger
@martinheidegger
A good PR is a good PR but maybe tap or tape might be the better choice
Martin Heidegger
@martinheidegger
Actually I think maybe tape is the best choice
Anshul
@AnshulMalik
I don't know how can tape help us, but the doc that Seth gave https://gist.github.com/bsommardahl/da8251512a0a72facca9c12aea4bdb7b
Martin Heidegger
@martinheidegger
?! tape is a test runner ?! am i not getting something
jest should work fine with tape
Anshul
@AnshulMalik
@martinheidegger, we are still using var instead of let and const, I was thinking of adopting new standard. learnyounode
Martin Heidegger
@martinheidegger
@AnshulMalik the "update"policy states that any PR updating learnyounode to features of Node 4 is welcome (including let and const)
Anshul
@AnshulMalik
Cool
Anshul
@AnshulMalik
I was trying to add code coverage to tests
We have our custom way of testing code
Anshul
@AnshulMalik
@channel, I was thinking of a similar to learnyounode for rust
Martin Heidegger
@martinheidegger
nice
Anshul
@AnshulMalik
How should I start ?
Martin Heidegger
@martinheidegger
think about lessons to learn rust?! not sure how rust goes
Anshul
@AnshulMalik
ok
People were very active here one year back
Suddenly only you and me are left :P
Martin Heidegger
@martinheidegger
but you could literally translate the tests to rust
i am but a ghost crawling these halls
Anshul
@AnshulMalik
hahaha
I'll create a repo and discuss the idea on issues may be, people will gradually come
Martin Heidegger
@martinheidegger
best way to go on about it
Anshul
@AnshulMalik

@martinheidegger, Can you checkout workshopper/learnyounode#566 ?

Builds failing for node v5, and those are failing for a very long time, I tried bit bisect, but seems like build always fail no matter how deep I go.

Anshul
@AnshulMalik
Later I was able to point to workshopper/learnyounode#434
with git bisect
andrea_denisse.go
@da-edra
Hello, how can I join Workshopper on GitHub?
I'd like to contribute.
Martin Heidegger
@martinheidegger
@da-edra An issue in the workshopper/org repo asking to be added. Also I would like to mention that you can contribute without being a member :)
Cristián Berroeta
@cristianberroeta

Hi all!

I think I've found a solution for a bug in the adventure repo. I actually discovered it by trying to solve a bug in the stream-adventure repo workshopper/stream-adventure#213.

Should I create a pull request for the adventure repo?

Martin Heidegger
@martinheidegger
@cristianberroeta if it solves something: sure though I think it might be lost love
Cristián Berroeta
@cristianberroeta

Thanks @martinheidegger!

Why do you say that? Is stream-adventure going to be updated to use https://github.com/workshopper/workshopper-adventure instead of https://github.com/workshopper/adventure?

Martin Heidegger
@martinheidegger
To my knowledge there is no-one maintaining adventure or workshopper-adventure right now ...