Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 12:43
    MartinThoma commented #758
  • 09:54
    glebmikulko closed #773
  • Jan 24 13:13
    SatricalPine commented #223
  • Jan 24 03:43
    SatricalPine commented #223
  • Jan 24 03:25
    SatricalPine commented #223
  • Jan 23 23:35
    fabioqcorreia commented #223
  • Jan 23 18:45
    rns4731 commented #593
  • Jan 23 10:36
    dnaeon commented #588
  • Jan 22 22:18
    Chainsaw2100 edited #774
  • Jan 22 22:17
    Chainsaw2100 labeled #774
  • Jan 22 22:17
    Chainsaw2100 opened #774
  • Jan 22 22:12
    ziirish commented #773
  • Jan 22 19:19
    Colin-b commented #773
  • Jan 22 16:46
    glebmikulko opened #773
  • Jan 20 11:26
    kasmediautamu commented #573
  • Jan 20 05:13
  • Jan 19 16:37
    yjk891 opened #772
  • Jan 16 16:33
Ben Steadman
@SteadBytes
Not sure though
Benjamin "Ziirish" SANS
@ziirish
@SteadBytes: checking
done
Callam
@cal97g
Nice one!
Lets get a gitter?
Maybe a trello board would be good for roadmap?
Ben Steadman
@SteadBytes
TYVM @ziirish , I'll assign it now and get working on it later on after work :)
Sam Pegler
@Poogles
So has it finally been forked?
Ben Steadman
@SteadBytes
@cal97g I think @ziirish is going to start working on the community bits and bobs (correct me if that doesn't include gitter @ziirish ). IMO, it would be worth using GitHub for the roadmap just to try and minimise the sprawl of different tools - but of course that's up for vote :) I'll check in again later on this evening :)
Sam Pegler
@Poogles
As I just logged in to ask if it's been forked yet as I've got some time to work on OpenAPI 3
Callam
@cal97g
Excellent. Please feel free to assign me a task to work on. I'll have some time later this evening too.
Callam
@cal97g
@Poogles it has been forked bud see https://github.com/python-restx/flask-restx
Sam Pegler
@Poogles
Opinions on removing Python 2.7 compatibility?
Callam
@cal97g
@Poogles kill it
Mathew Comeau
@comatlabs
Hi all. I just started playing with flask-restplus and popped in here on a whim... is this project moving to flask-restx?
Ben Steadman
@SteadBytes
@Poogles yes, I mentioned yesterday that after this first release of the latent flask-restplus 0.14.0 update that we should drop Python 2 support moving forward
Couple of things related to this big rename @ziirish , @j5awry : AUTHORS.rst is very out of date - do we keep it as is, update it or remove it? What shall we do with CHANGELOG.rst, I guess we'll start the versioning on this from 0 again, is it worth removing the change?
Change log*
Mathew Comeau
@comatlabs
@SteadBytes, I'll take "big rename" as a yes. Thanks for everyone's work, I'm loving it so far
Andrey Kurilin
@andreykurilin
In combination to dropping support of py2.7, it would be nice to drop py3.4 (it already reached end-of-life) and py3.5 (it almost reached eol)
As for AUTHORS.rst. imho, it doesn't have any advantages over git shortlog --summary --numbered --email and is always outdated :)
John Chittum
@j5awry

Couple quick things -- remove Akamai from the copyright. I don't work there anymore (well, won't, as of Jan 17th), and I never made a code commit that's copyrightable.

Kill py2

I'm not quite understanding how the 2 packages things will work since we can only publish 1

I'm a fan of slack because I'm on it all the time. Gitter is fine, but since i don't live on it, i don't check as often as I should. I...hate zulip.

Andrey Kurilin
@andreykurilin
@j5awry project name on pypi != packages that it provides. For example, both https://pypi.org/project/jwt/ and https://pypi.org/project/PyJWT/ provides package with jwt name. https://github.com/python-restx/flask-restx/blob/master/setup.py#L78 this section can include whatever you want number of packages. usually, it inbcludes only one package that equals to project name on pypi, but there are a lot of cases that it is not true. ANother example is here, when setuptools.find_packages method is executed but without providing exclude=['tests', 'tests.*']... there are a lot of projects on pypi that delivers tests package alone with their projects
Ben Steadman
@SteadBytes
@andreykurilin Just to check, would this mean having two directories within the codebase flask-restplus and flask-restx?
Ben Steadman
@SteadBytes
i.e. flask-restplus remains as it it currently and flask-restx has all the renames
Andrey Kurilin
@andreykurilin
@SteamBytes: hm... as far as I remember, 'packages' section of setup.py accepts a dict where key is name of package and value is path(or something like this?!). This means that several keys can map to one path. The hardest part is to distinguish whether it was import of 'flask_restx' or 'flask_restplus' to print deprecation message. Here we have to options. First one is adding parsing of call traceback to flask_restx.init to identify this. Another option is adding almost empty files into flask_restplus dir that duplicates names of public modules of flask_restx and include imports of flask_restx, so the code part will not be duplicated
Ben Steadman
@SteadBytes
Yeah, the setup.py bit isn't so much the problem - it's how to manage the code between both packages. If there's no absolute imports within the package itself i.e. from flask_restplus.models import ... then in theory pointing both packages to the same flast_restx directory should work (not that I've verified this).
If possible, option 1 or something similar would be best IMO
As long as parsing that call traceback does not have a significant impact at runtime
Andrey Kurilin
@andreykurilin
I can help with this task after your initial PR will be merged
Ben Steadman
@SteadBytes
Much appreciated @andreykurilin
I've put up a WIP PR for the renaming python-restx/flask-restx#2 @ziirish, @j5awry please take a look at the questions in the PR description regarding author name :smile:
Ben Steadman
@SteadBytes
Gitter should be up and running too https://gitter.im/python-restx
I've got to sign off for tonight now, hopefully we'll have some answers to the questions I mentioned on python-restx/flask-restx#2 and I can get the great renaming of 2020 complete tomorrow :wink:
John Chittum
@j5awry
Awesome! Thanks for all the setup work folks!
John Chittum
@j5awry
for consistency, dead or not, i've put in a PR to restplus remove akamai (since i don't work there and made no code changes). It also specifies what Akamai folks should do in the future
Ben Steadman
@SteadBytes
Awesome, thanks @j5awry
Ibrahima Gaye
@ibstelix
Amazing job, thank you all.
martireg
@martireg
Hello guys, is flask-restx ready for production usage?
Benjamin "Ziirish" SANS
@ziirish
hello @martireg
not yet
martireg
@martireg
Thank you, there is some aprox date┬┐?
Benjamin "Ziirish" SANS
@ziirish
I'll soon release some "usable" packages, but the intent is just to test our CI/automation
soon == by the end of the week
after that, we will work on a proper release as discussed here: noirbizarre/flask-restplus#743
martireg
@martireg
nice
Bhathiya Perera
@JaDogg
That is good to know. Thanks for all your hard work.
lewcianci
@lewcianci
hey everyone, this is probably a dumb question, but i've read the docs and i can't work out how to add an api operation that takes body parameters and produecs a response
i'm also using swagger and swagger ui
so the intent would be to make an operation that takes body parameters of a certain model, does something with those values, and then returns a serialised response to the client