Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
yaakov kuperman
@mostfunkyduck
any reason I shouldn't take a stab at the sendgrid integration (besides my general unfamiliarity with the code ;) )?
Or Carmi
@liiight
Stab away :smile:
sendgrid is a big one though IIRC
yaakov kuperman
@mostfunkyduck
yeah, it's pretty huge :O
Or Carmi
@liiight
btw, congrats on being the first one here! ;)
yaakov kuperman
@mostfunkyduck
heh, thanks
fwiw, I work for sparkpost, was planning on doing them after SG
this project caught my eye because it's essentially related to what I do for my day job
Or Carmi
@liiight
well, not being familiar with sparkpost api at all, i'd imagine it cant be as big as SG
yaakov kuperman
@mostfunkyduck
yeah, it's not
yaakov kuperman
@mostfunkyduck
sendgrid PR submitted, feel free to eviscerate :)
Or Carmi
@liiight
sweet, will check it out asap
yaakov kuperman
@mostfunkyduck
thanks
Or Carmi
@liiight
wow, just took a peek. i knew its gonna be a beast, but holy fuck
nice work on it dude, looks painful
yaakov kuperman
@mostfunkyduck
oh yeah
:)
thanks
Or Carmi
@liiight
@yaakov-github It's gonna take me a while to get back into your PR, I haven't forgot about it though
yaakov kuperman
@mostfunkyduck
cool
Or Carmi
@liiight
@yaakov-github left some feedback
yaakov kuperman
@mostfunkyduck
hey man, wondering if you got a chance to look at my updates to the PR, I think i covered what you wanted to cover
Or Carmi
@liiight
Hey @yaakov-github sorry, I got some shit going on in my personal life right now. I'll check it out asap
Ilya
@grozail
Hello, developers!
I have some questions about telegram provider.
Should I have a bot set-up to use notifications?
Also would it be possible to improve documentation about telegram provider, should I create an issue on github?
Thanks in advance for your support!
Or Carmi
@liiight
Hi @grozail !
I'll be happy to answer any specific question you have
Ilya
@grozail

Hi @liiight thanks for your response. I have figured out correct flow by myself:
Instantiate bot, acquire token.
Start conversation.
Get the chat ID via getUpdates.
Use this info in notifiers.

But it would be nice to define this or another flow in docs.
I can start an issue on github.
Thanks in advance for your support and for such a nice library!

yaakov kuperman
@mostfunkyduck
:point_up: September 20, 2018 1:21 PM turned out i did as well (this is yaakov-github's new sn)
was just going through some of my old stuff and i'd like to move that sendgrid thing along, will probably finish off whatever was outstanding this week
Or Carmi
@liiight
@mostfunkyduck I think we should drop that as I have a pending change that changes the providers validation from json schema to pydantic