Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 10 09:24
    lock[bot] locked #352
  • Dec 10 09:24
    lock[bot] commented #352
  • Dec 10 07:12
    lock[bot] locked #349
  • Dec 10 07:12
    lock[bot] commented #349
  • Dec 10 07:12
    lock[bot] locked #351
  • Dec 10 07:12
    lock[bot] commented #351
  • Dec 09 20:24

    matkoch on develop

    Update CHANGELOG.md Add AbsolutePath.Contains (compare)

  • Dec 09 17:18

    matkoch on develop

    Add GetWinRelativePath and GetU… Move AbsolutePath, RelativePath… Move global-solution generation… and 2 more (compare)

  • Dec 08 22:17
    matkoch labeled #355
  • Dec 08 22:17
    matkoch labeled #355
  • Dec 08 17:20

    matkoch on develop

    Add GetWinRelativePath and GetU… Move AbsolutePath, RelativePath… Move global-solution generation… (compare)

  • Dec 06 23:49

    matkoch on develop

    Fix NSwag to quote tool path Add GetWinRelativePath and GetU… (compare)

  • Dec 06 21:54

    matkoch on develop

    Fix SolutionSerializer to handl… (compare)

  • Dec 06 21:32
    MichaelSL commented #346
  • Dec 06 20:04

    matkoch on develop

    Add setters for Project propert… (compare)

  • Dec 06 11:01
    matkoch commented #355
  • Dec 05 17:11
    pslotvinski assigned #355
  • Dec 05 17:11
    pslotvinski opened #355
  • Dec 05 14:17

    matkoch on develop

    Fix method body style in editor… (compare)

  • Dec 05 08:33
    totollygeek commented #345
Matthias Koch
@matkoch
an example for removing a project from a solution file?
cskwrd
@cskwrd
No, one moment while I come up with a scenario
cskwrd
@cskwrd
Say my company has a software product. Let's call it "PrintMoney". I would like to build PrintMoney.sln using nuke, without adding _build.csproj to PrintMoney.sln. I would like this because I don't want to deal with the headache of remembering to stash nuke related files before commiting, but I want to prove its usefulness to my co-workers at the same time.
Does that make sense?
Matthias Koch
@matkoch
the answer is: yes, you don't need it in the solution file
but I don't understand what you're asking for - an example?
cskwrd
@cskwrd
So I only know how to set up nuke using the command line tool which seems to always add nuke to the sln I want it to build
Matthias Koch
@matkoch
no
if you select a default solution file, then it will add itself there
if none, then nothing is added
cskwrd
@cskwrd
ah ok
Matthias Koch
@matkoch
and anyway... if you don't want it to be added, just remove it afterwards
cskwrd
@cskwrd
I will give that a shot, thanks!
Matthias Koch
@matkoch
sure
Matthias Koch
@matkoch
@/all :mega::shipit: NUKE 0.23.0 IS OUT!!!
  • Changed target frameworks to netcoreapp3.0 and net472
  • Changed AzureDevOps to AzurePipelines
  • Changed CheckBuildProjectConfigurationsAttribute to skip dot-prefixed directories
  • Removed ProjectFromAttribute
  • Removed MSBuildTasks.MSBuildParseProject
  • Removed GitVersion.GetNormalizedAssemblyVersion and GetNormalizedFileVersion
  • Added NuGet package resolution from project.assets.json file
  • Added CI interface resolution via CIAttribute
  • Added Bamboo interface
  • Added TeamCityImportDotCoverPathAttribute to address version mismatch
  • Added GitHubActionsAttribute for configuration generation
  • Added AzurePipelinesAttribute for configuration generation
  • Added AppVeyorAttribute for configuration generation
  • Added execution of dotnet build-server shutdown when build has finished
  • Added NpmCi task
  • Fixed TeamCity parameter dictionaries to use original keys
  • Fixed NuGet package resolution for project files without PackageReference items
  • Fixed code inspections in PowerShell script
  • Fixed resolution for legacy package directories
  • Fixed generation of Partition parameter and script paths
  • Fixed ToolPathResolver to support global tool packages
  • Fixed ReportGeneratorTasks and GitVersionTasks by providing Framework property
Matthias Koch
@matkoch
@/all :mega::shipit: NUKE 0.23.1 IS OUT!!!
  • Fixed checking hashes for non-existing configuration files
  • Fixed null-reference exception for commands without message
Matthias Koch
@matkoch
@/all :mega::shipit: NUKE 0.23.2 IS OUT!!!
  • Fixed ensuring of existing directory for generation of configuration files
  • Fixed packaging of MSBuildTaskRunner in Nuke.Common
Matthias Koch
@matkoch
@/all :mega::shipit: NUKE 0.23.3 IS OUT!!!
  • Fixed separator in Azure Pipelines service messages
Stefan Bertels
@StefanBertels
image.png
Seems the lastet NukeBuildLocator has a problem on my machine.
Matthias Koch
@matkoch
i’m not really maintaining that anymore
Stefan Bertels
@StefanBertels

Ok. The problem persists with older NukeBuildLocator which means something on my machine changed...

Seems I really should change my build script to .net core...

Stefan Bertels
@StefanBertels
Problem solved by rebooting (wtf). Some Visual Studio setup (reboot) issue resulted in vswhere giving empty results.
I just stumbled upon GetNormalizedFileVersion (removed in 0.23). Is there a reason for removal / is there a replacement I should use?
Seems like GitVersion.AssemblySemFileVer could be a replacement (for use with SetFileVersion).
Stefan Bertels
@StefanBertels
I'm just trying to convert to .net core. Seems it should be possible to get rid of any powershell script (yes i'ts ok to not check/download dotnet sdk here). But I get some error I don't understand when running "dotnet run" in directory "build":
NUKE Execution Engine version 0.23.3 (Windows,.NETStandard,Version=v2.0)

Assertion failed: Package executable 'tools' [GitVersion.Tool|GitVersion.CommandLine] requires a framework:
 - tools
   at Nuke.Common.ControlFlow.Fail(String text)
   at Nuke.Common.ControlFlow.Assert(Boolean condition, String text)
   at Nuke.Common.Tooling.ToolPathResolver.GetPackageExecutable(String packageId, String packageExecutable, String version, String framework)
   at Nuke.Common.Tools.GitVersion.GitVersionTasks.GetToolPath(String framework)
   at Nuke.Common.Tools.GitVersion.GitVersionSettings.GetToolPath()
   at Nuke.Common.Tools.GitVersion.GitVersionSettings.get_ToolPath()
   at Nuke.Common.Tooling.ProcessTasks.StartProcess(ToolSettings toolSettings)
   at Nuke.Common.Tools.GitVersion.GitVersionTasks.GitVersion(GitVersionSettings toolSettings)
   at Nuke.Common.Tools.GitVersion.GitVersionTasks.GitVersion(Configure`1 configurator)
   at Nuke.Common.Tools.GitVersion.GitVersionAttribute.GetValue(MemberInfo member, Object instance)
   at Nuke.Common.Execution.InjectionUtility.InjectValuesInternal[T](T instance, IEnumerable`1 tuples)
   at Nuke.Common.Execution.InjectionUtility.InjectValues[T](T instance, Func`2 filter)
   at Nuke.Common.Execution.BuildManager.Execute[T](Expression`1[] defaultTargetExpressions)

This is in.build.csproj:

   <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp3.0</TargetFramework>
    <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
    <IsPackable>False</IsPackable>
    <NoWarn>CS0649;CS0169</NoWarn>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Nuke.Common" Version="0.23.3" />
    <PackageReference Include="GitVersion.CommandLine" Version="5.1.2" />
  </ItemGroup>

Any hints?

Matthias Koch
@matkoch
repro plz
Matthias Koch
@matkoch
@/all :mega::shipit: NUKE 0.23.4 IS OUT!!!
  • Fixed assignment for NuGetAssetsConfigFile when BuildProjectDirectory is null
  • Fixed ToolPathResolver to not require framework when only one file matches
Nikita Kazachkov
@NikitaKazachkov_gitlab
Hi! Please tell me how to use Nuke.Common.Tools.Git Version on Unix? Not working with GitLab CI:
"Error parsing Infinity value. Path '', line 1, position 1."
Matthias Koch
@matkoch
nuke just wraps the invocation
Nikita Kazachkov
@NikitaKazachkov_gitlab
Why then the standard example does not work in GitLab CI?
Matthias Koch
@matkoch
this is something for you to investigate, it’s not a problem of nuke
better to ask the folks of gitversion
John Korsnes
@johnkors
Hi, not sure why - but the GitHub actions generated an invalid file
the on: property was empty
known bug?
Matthias Koch
@matkoch
if there's no issue, then probably not
question is, how else would you trigger?
John Korsnes
@johnkors
I mean, by the code it looks like it should have a generated on: [push], but it was empty
Matthias Koch
@matkoch
did you define it in the attribute?
John Korsnes
@johnkors
only [GitHubActions("CI",GitHubActionsImage.Ubuntu1604, GitHubActionsImage.WindowsLatest)]
Matthias Koch
@matkoch
there's no On being set
John Korsnes
@johnkors
right, but by the code it looks the default is [push] ..?
public GitHubActionsTrigger[] On { get; set; } = new GitHubActionsTrigger[0];
Matthias Koch
@matkoch
why?
empty array?
John Korsnes
@johnkors
ah
ok, I misread it then