Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 01 2019 22:54
    AArnott closed #307
  • Oct 01 2019 22:54
    AArnott labeled #307
  • Oct 01 2019 22:54
    AArnott commented #307
  • Oct 01 2019 22:24
    ndrwrbgs commented #307
  • Sep 10 2019 14:31
    AArnott commented #307
  • Sep 10 2019 11:24
    RonenGlants commented #307
  • Aug 02 2019 14:43
    docwattsman commented #303
  • Aug 02 2019 14:39
    docwattsman commented #303
  • Jun 10 2019 21:26
    AArnott closed #309
  • Jun 10 2019 21:26
    AArnott commented #309
  • Jun 10 2019 21:26
    AArnott labeled #309
  • Jun 10 2019 21:23
    jerchap opened #309
  • May 21 2019 23:22
    AArnott closed #308
  • May 21 2019 23:22
    AArnott commented #308
  • May 21 2019 23:22
    AArnott labeled #308
  • May 21 2019 21:42
    AleRoe opened #308
  • Apr 24 2019 17:49
    ErikApption opened #307
  • Feb 14 2019 16:28
    joepeavey commented #297
  • Feb 14 2019 16:28
    joepeavey commented #297
  • Feb 13 2019 20:25
    joepeavey commented #297
Andrew Arnott
@AArnott
That should solve your binding redirect woes
Pavol Kovalik
@kovalikp
but that disables building .sln files
MSBUILD : error MSB4223: A node of the required type InProc could not be created :(
Andrew Arnott
@AArnott
whoa. Hmm.... I had no idea that limitation existed.
But I think I know how you can workaround that. Although it does involve a temporary file.
MSBuild.exe has a special switch that will produce an MSBuild project from a .sln file. You could invoke that (by spawning the process). Then you can tell your MSBUild API to build the msbuild project instead of the sln file.
Pavol Kovalik
@kovalikp
build a sln into metaproj (or something like that)
Andrew Arnott
@AArnott
yes, metaproj I think is how it's named.
I don't remember the switch though.
Pavol Kovalik
@kovalikp
ok, worth the try
Andrew Arnott
@AArnott
@kovalikp: have you seen this? https://github.com/KirillOsenkov/MSBuildStructuredLog
It has a freakin' awesome msbuild log viewer including properties, items, and metadata for every target.
Pavol Kovalik
@kovalikp
Yeah, found it just couple days ago.
Pavol Kovalik
@kovalikp
Maybe I could invoke msbuild.exe with custom logger and then push the results back to PS via WCF managed pipiline.
Aloïs de Gouvello
@aloisdg
Hello, is it possible to set a package as pre release from VS with nuproj?
Pavol Kovalik
@kovalikp
yeah, just set Version in project properties to 1.0.0-alpha or something like that
Aloïs de Gouvello
@aloisdg
ok thank you
@kovalikp indeed. Find it. https://docs.nuget.org/create/versioning
Aloïs de Gouvello
@aloisdg

new question. How to use nuproj with appveyor? I tried to run it naively and appveyor throws this during the build:

  Harmony -> C:\projects\harmony\Harmony\bin\Debug\Harmony.dll
  Harmony.Tests -> C:\projects\harmony\Harmony.Tests\bin\Debug\Harmony.Tests.dll
C:\projects\harmony\Harmony.Package\Harmony.Package.nuproj(41,3): error MSB4019: The imported project "C:\Program Files (x86)\MSBuild\NuProj\NuProj.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.
Command exited with code 1

How can I config appveyor to build my package?

(Also should I move this to an issue?)
Andrew Arnott
@AArnott
Install the NuProj nuget package to one of your projects, then modify your NuProj to get its imports from the restored package. It works on AppVeyor.
Aloïs de Gouvello
@aloisdg
@AArnott If I add the NuProj nuget package to the main lib or my lib nuproj project?
@AArnott "modify your NuProj to get its imports from the restored package." how?
Andrew Arnott
@AArnott
Either one. I prefer to add it to my nuproj itself.
You can modify it by setting the NuProjPath property in the project file as I do here
In my case, I use a project.json file to bring in the NuProj package dependency.
Aloïs de Gouvello
@aloisdg
@AArnott I guess you used a project.json because we cant add a package with nuget to a nuproj project?
Andrew Arnott
@AArnott
Yes. And because project.json rocks. 😄
Andrew Arnott
@AArnott
VS Gallery finally has an update to the NuProj.msi. :)
Pavol Kovalik
@kovalikp
:+1:
Pedro Lamas
@PedroLamas
@terrajobst hope I didn't talk to much in suggesting adding to .NET Foundation! :)
Immo Landwerth
@terrajobst
No way! It's a great suggestion. It's just Twitter sucks for longer conversation. Driving to work now. I need a keyboard ;-)
Pavol Kovalik
@kovalikp
maybe that would make me to finally sign the CLA :D
Andrew Arnott
@AArnott
netstandard support is getting pretty important. I've heard of lots of people asking for it. I haven't studied NuProj's way of dealing with individual target frameworks yet. Is anyone else able to take a look or should I dive in?
See #231
Pavol Kovalik
@kovalikp
I was hoping this would be eventually supported by NuGet.Core out of the box, just by upgrading to appropriate version of NuGet.Core
We're using GetTargetFrameworkMoniker target to get framework version of the referenced project, and then NuGet's VersionUtility.GetShortFrameworkName to determine the folder name.
See Extensions.cs
I believe this will eventually work, since NuGet.exe will have to be able package netstandard projects correctly
Pavol Kovalik
@kovalikp
I don't recall if #231 was filed before or after our last NuGet package upgrade
Maybe we already support netstandard? If not I would recommend checking with the NuGet team if they have any plan to update VersionUtility.GetShortFrameworkName, or they want to use some other way of detecting netstandard projects
Andrew Arnott
@AArnott
We do not yet support netstandard. Waiting for nuget to offer the functionality may work.
Pavol Kovalik
@kovalikp
ok, now I actually checked: dotnet core rc2 returns .NETFramework,Version=v4.5.1 from GetTargetFrameworkMoniker, even though project.json contains
"frameworks": {
    "netstandard1.6": {
      "imports": "dnxcore50"
    }
  }
also VersionUtility.GetShortFrameworkName in NuGet.Client doesn't mention netstandardX.Y at all
Pavol Kovalik
@kovalikp
so, either we wait until tooling matures more, or we would have to rely on output directory structure
the xproj puts the output in correct folder, e.g.: ...\src\ClassLibrary7\bin\Debug\netstandard1.6\ClassLibrary7.dll
Pavol Kovalik
@kovalikp
btw, we should wait at least until RC3, current tooling does not even produce correct output path in some cases: dotnet/core#215
why do I keep saying RC? it's still just a preview :smile:
Matthijs ter Woord
@mterwoord
@kovalikp version 2-dot-something is the real rtm with ms.. ;)
Pavol Kovalik
@kovalikp
:laughing:
Benjamin Hugot
@bhugot
blob
blob