Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 01 2019 22:54
    AArnott closed #307
  • Oct 01 2019 22:54
    AArnott labeled #307
  • Oct 01 2019 22:54
    AArnott commented #307
  • Oct 01 2019 22:24
    ndrwrbgs commented #307
  • Sep 10 2019 14:31
    AArnott commented #307
  • Sep 10 2019 11:24
    RonenGlants commented #307
  • Aug 02 2019 14:43
    docwattsman commented #303
  • Aug 02 2019 14:39
    docwattsman commented #303
  • Jun 10 2019 21:26
    AArnott closed #309
  • Jun 10 2019 21:26
    AArnott commented #309
  • Jun 10 2019 21:26
    AArnott labeled #309
  • Jun 10 2019 21:23
    jerchap opened #309
  • May 21 2019 23:22
    AArnott closed #308
  • May 21 2019 23:22
    AArnott commented #308
  • May 21 2019 23:22
    AArnott labeled #308
  • May 21 2019 21:42
    AleRoe opened #308
  • Apr 24 2019 17:49
    ErikApption opened #307
  • Feb 14 2019 16:28
    joepeavey commented #297
  • Feb 14 2019 16:28
    joepeavey commented #297
  • Feb 13 2019 20:25
    joepeavey commented #297
Aloïs de Gouvello
@aloisdg
@AArnott If I add the NuProj nuget package to the main lib or my lib nuproj project?
@AArnott "modify your NuProj to get its imports from the restored package." how?
Andrew Arnott
@AArnott
Either one. I prefer to add it to my nuproj itself.
You can modify it by setting the NuProjPath property in the project file as I do here
In my case, I use a project.json file to bring in the NuProj package dependency.
Aloïs de Gouvello
@aloisdg
@AArnott I guess you used a project.json because we cant add a package with nuget to a nuproj project?
Andrew Arnott
@AArnott
Yes. And because project.json rocks. 😄
Andrew Arnott
@AArnott
VS Gallery finally has an update to the NuProj.msi. :)
Pavol Kovalik
@kovalikp
:+1:
Pedro Lamas
@PedroLamas
@terrajobst hope I didn't talk to much in suggesting adding to .NET Foundation! :)
Immo Landwerth
@terrajobst
No way! It's a great suggestion. It's just Twitter sucks for longer conversation. Driving to work now. I need a keyboard ;-)
Pavol Kovalik
@kovalikp
maybe that would make me to finally sign the CLA :D
Andrew Arnott
@AArnott
netstandard support is getting pretty important. I've heard of lots of people asking for it. I haven't studied NuProj's way of dealing with individual target frameworks yet. Is anyone else able to take a look or should I dive in?
See #231
Pavol Kovalik
@kovalikp
I was hoping this would be eventually supported by NuGet.Core out of the box, just by upgrading to appropriate version of NuGet.Core
We're using GetTargetFrameworkMoniker target to get framework version of the referenced project, and then NuGet's VersionUtility.GetShortFrameworkName to determine the folder name.
See Extensions.cs
I believe this will eventually work, since NuGet.exe will have to be able package netstandard projects correctly
Pavol Kovalik
@kovalikp
I don't recall if #231 was filed before or after our last NuGet package upgrade
Maybe we already support netstandard? If not I would recommend checking with the NuGet team if they have any plan to update VersionUtility.GetShortFrameworkName, or they want to use some other way of detecting netstandard projects
Andrew Arnott
@AArnott
We do not yet support netstandard. Waiting for nuget to offer the functionality may work.
Pavol Kovalik
@kovalikp
ok, now I actually checked: dotnet core rc2 returns .NETFramework,Version=v4.5.1 from GetTargetFrameworkMoniker, even though project.json contains
"frameworks": {
    "netstandard1.6": {
      "imports": "dnxcore50"
    }
  }
also VersionUtility.GetShortFrameworkName in NuGet.Client doesn't mention netstandardX.Y at all
Pavol Kovalik
@kovalikp
so, either we wait until tooling matures more, or we would have to rely on output directory structure
the xproj puts the output in correct folder, e.g.: ...\src\ClassLibrary7\bin\Debug\netstandard1.6\ClassLibrary7.dll
Pavol Kovalik
@kovalikp
btw, we should wait at least until RC3, current tooling does not even produce correct output path in some cases: dotnet/core#215
why do I keep saying RC? it's still just a preview :smile:
Matthijs ter Woord
@mterwoord
@kovalikp version 2-dot-something is the real rtm with ms.. ;)
Pavol Kovalik
@kovalikp
:laughing:
Benjamin Hugot
@bhugot
blob
blob
Hello, nuproj last version is no longer working after adding a reference
Pavol Kovalik
@kovalikp
can you have look at #212 and provide additional info if possible?
Benjamin Hugot
@bhugot
done
Pavol Kovalik
@kovalikp
thanks
Benjamin Hugot
@bhugot
As I said I compiled with last source and it s working correctly. But I still have an old bug when project reference use bcl library. So I need to edit NuProj.targets that way
<MSBuild Targets="GetTargetPath" Projects="@(_NonNuProjProjectReference)" Properties="$(ProjectProperties);SkipValidatePackageReferences=true">
<Output TaskParameter="TargetOutputs" PropertyName="_NonNuProjProjectTargetPath" />
</MSBuild>
Aloïs de Gouvello
@aloisdg
hello
When I move my package (dll) to a nuproj's project reference, dependecies arent add. How can I add them?
Pavol Kovalik
@kovalikp
do you mean nuget dependencies of your dll (.csproj) project? does it use packages.config or project.json?
Pavol Kovalik
@kovalikp
@AArnott any idea, if/where could I find "Microsoft.DotNet.targets" on GitHub? Or is this part of some internal MSFT project?
Matthijs ter Woord
@mterwoord
afaik, the .net core tooling is not open source..
Pavol Kovalik
@kovalikp
sigh, I'd like to have look at integrating NuProj with .net core
it's just the tooling is missing so much...
Matthijs ter Woord
@mterwoord
i'd hold off for a bit: (iirc) .net core 1.1 will be using csproj files again.. :)
Pavol Kovalik
@kovalikp
and that is not opensourced either?
Pavol Kovalik
@kovalikp
essentially, what I'm looking for is a way, how to recognize .net core project using some kind of target and get appropriate result output groups
freaking xproj returns .NETFramework,Version=v4.5.1 for `GetTargetFrameworkMoniker, even though it's supposed be netstandard1.6
bloody liar :no_good:
olegoga
@olegoga
I can't find any documentation on referencing a nuproj from a nuproj. Is this supported?
olegoga
@olegoga
Actually, I see that I can add a nuproj reference to a nupoj, but I'm not sure what this means exactly.