nuproj/nuproj

Building NuGet packages with Visual Studio and MSBuild

Pedro Lamas

@PedroLamas

@terrajobst hope I didn't talk to much in suggesting adding to .NET Foundation! :)

Immo Landwerth

@terrajobst

No way! It's a great suggestion. It's just Twitter sucks for longer conversation. Driving to work now. I need a keyboard ;-)

Pavol Kovalik

@kovalikp

maybe that would make me to finally sign the CLA :D

Andrew Arnott

@AArnott

netstandard support is getting pretty important. I've heard of lots of people asking for it. I haven't studied NuProj's way of dealing with individual target frameworks yet. Is anyone else able to take a look or should I dive in?

See #231

Pavol Kovalik

@kovalikp

I was hoping this would be eventually supported by NuGet.Core out of the box, just by upgrading to appropriate version of NuGet.Core

We're using GetTargetFrameworkMoniker target to get framework version of the referenced project, and then NuGet's VersionUtility.GetShortFrameworkName to determine the folder name.

See Extensions.cs

I believe this will eventually work, since NuGet.exe will have to be able package netstandard projects correctly

Pavol Kovalik

@kovalikp

I don't recall if #231 was filed before or after our last NuGet package upgrade

Maybe we already support netstandard? If not I would recommend checking with the NuGet team if they have any plan to update VersionUtility.GetShortFrameworkName, or they want to use some other way of detecting netstandard projects

Andrew Arnott

@AArnott

We do not yet support netstandard. Waiting for nuget to offer the functionality may work.

Pavol Kovalik

@kovalikp

ok, now I actually checked: dotnet core rc2 returns .NETFramework,Version=v4.5.1 from GetTargetFrameworkMoniker, even though project.json contains

"frameworks": {
    "netstandard1.6": {
      "imports": "dnxcore50"
    }
  }

also VersionUtility.GetShortFrameworkName in NuGet.Client doesn't mention netstandardX.Y at all

Pavol Kovalik

@kovalikp

so, either we wait until tooling matures more, or we would have to rely on output directory structure

the xproj puts the output in correct folder, e.g.: ...\src\ClassLibrary7\bin\Debug\netstandard1.6\ClassLibrary7.dll

Pavol Kovalik

@kovalikp

btw, we should wait at least until RC3, current tooling does not even produce correct output path in some cases: dotnet/core#215

why do I keep saying RC? it's still just a preview :smile:

Matthijs ter Woord

@mterwoord

@kovalikp version 2-dot-something is the real rtm with ms.. ;)

Pavol Kovalik

@kovalikp

:laughing:

Benjamin Hugot

@bhugot

Hello, nuproj last version is no longer working after adding a reference

Pavol Kovalik

@kovalikp

can you have look at #212 and provide additional info if possible?

Benjamin Hugot

@bhugot

done

Pavol Kovalik

@kovalikp

thanks

Benjamin Hugot

@bhugot

As I said I compiled with last source and it s working correctly. But I still have an old bug when project reference use bcl library. So I need to edit NuProj.targets that way

Aloïs de Gouvello

@aloisdg

hello

When I move my package (dll) to a nuproj's project reference, dependecies arent add. How can I add them?

Pavol Kovalik

@kovalikp

do you mean nuget dependencies of your dll (.csproj) project? does it use packages.config or project.json?

Pavol Kovalik

@kovalikp

@AArnott any idea, if/where could I find "Microsoft.DotNet.targets" on GitHub? Or is this part of some internal MSFT project?

Matthijs ter Woord

@mterwoord

afaik, the .net core tooling is not open source..

Pavol Kovalik

@kovalikp

sigh, I'd like to have look at integrating NuProj with .net core

it's just the tooling is missing so much...

Matthijs ter Woord

@mterwoord

i'd hold off for a bit: (iirc) .net core 1.1 will be using csproj files again.. :)

Pavol Kovalik

@kovalikp

and that is not opensourced either?

Pavol Kovalik

@kovalikp

essentially, what I'm looking for is a way, how to recognize .net core project using some kind of target and get appropriate result output groups

freaking xproj returns .NETFramework,Version=v4.5.1 for `GetTargetFrameworkMoniker, even though it's supposed be netstandard1.6

bloody liar :no_good:

olegoga

@olegoga

I can't find any documentation on referencing a nuproj from a nuproj. Is this supported?

olegoga

@olegoga

Actually, I see that I can add a nuproj reference to a nupoj, but I'm not sure what this means exactly.

Andrew Arnott

@AArnott

It means a package dependency will be created.

Christoph Lindemann

@ChristophLindemann

Any idea on when the next release will be? One that is published to Visual Studio Gallery?

We get the "Value can not be null" #212 all the time, and it would be nice if I could tell the team members just to pull the latest version from Visual Studio Gallery

Andrew Arnott

@AArnott

I confess, after seeing so much action on NuProj in so little time, I've been afraid to review all the github notifications for it for lack of time.

Pavol Kovalik

@kovalikp

Well, I actually fixed the issue with resolving references in CPS, so it might be good idea release new version.

Andrew Arnott

@AArnott

awesome. :)

Andrew Arnott

@AArnott

going through my backlog of nuproj notifications now.

Christoph Lindemann

@ChristophLindemann

@kovalikp & @AArnott any closer to releasing a new version?

Where communities thrive

People

Repo info

Activity