Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 01 2019 22:54
    AArnott closed #307
  • Oct 01 2019 22:54
    AArnott labeled #307
  • Oct 01 2019 22:54
    AArnott commented #307
  • Oct 01 2019 22:24
    ndrwrbgs commented #307
  • Sep 10 2019 14:31
    AArnott commented #307
  • Sep 10 2019 11:24
    RonenGlants commented #307
  • Aug 02 2019 14:43
    docwattsman commented #303
  • Aug 02 2019 14:39
    docwattsman commented #303
  • Jun 10 2019 21:26
    AArnott closed #309
  • Jun 10 2019 21:26
    AArnott commented #309
  • Jun 10 2019 21:26
    AArnott labeled #309
  • Jun 10 2019 21:23
    jerchap opened #309
  • May 21 2019 23:22
    AArnott closed #308
  • May 21 2019 23:22
    AArnott commented #308
  • May 21 2019 23:22
    AArnott labeled #308
  • May 21 2019 21:42
    AleRoe opened #308
  • Apr 24 2019 17:49
    ErikApption opened #307
  • Feb 14 2019 16:28
    joepeavey commented #297
  • Feb 14 2019 16:28
    joepeavey commented #297
  • Feb 13 2019 20:25
    joepeavey commented #297
Pavol Kovalik
@kovalikp
thanks
Benjamin Hugot
@bhugot
As I said I compiled with last source and it s working correctly. But I still have an old bug when project reference use bcl library. So I need to edit NuProj.targets that way
<MSBuild Targets="GetTargetPath" Projects="@(_NonNuProjProjectReference)" Properties="$(ProjectProperties);SkipValidatePackageReferences=true">
<Output TaskParameter="TargetOutputs" PropertyName="_NonNuProjProjectTargetPath" />
</MSBuild>
Aloïs de Gouvello
@aloisdg
hello
When I move my package (dll) to a nuproj's project reference, dependecies arent add. How can I add them?
Pavol Kovalik
@kovalikp
do you mean nuget dependencies of your dll (.csproj) project? does it use packages.config or project.json?
Pavol Kovalik
@kovalikp
@AArnott any idea, if/where could I find "Microsoft.DotNet.targets" on GitHub? Or is this part of some internal MSFT project?
Matthijs ter Woord
@mterwoord
afaik, the .net core tooling is not open source..
Pavol Kovalik
@kovalikp
sigh, I'd like to have look at integrating NuProj with .net core
it's just the tooling is missing so much...
Matthijs ter Woord
@mterwoord
i'd hold off for a bit: (iirc) .net core 1.1 will be using csproj files again.. :)
Pavol Kovalik
@kovalikp
and that is not opensourced either?
Pavol Kovalik
@kovalikp
essentially, what I'm looking for is a way, how to recognize .net core project using some kind of target and get appropriate result output groups
freaking xproj returns .NETFramework,Version=v4.5.1 for `GetTargetFrameworkMoniker, even though it's supposed be netstandard1.6
bloody liar :no_good:
olegoga
@olegoga
I can't find any documentation on referencing a nuproj from a nuproj. Is this supported?
olegoga
@olegoga
Actually, I see that I can add a nuproj reference to a nupoj, but I'm not sure what this means exactly.
Andrew Arnott
@AArnott
It means a package dependency will be created.
Christoph Lindemann
@ChristophLindemann
Any idea on when the next release will be? One that is published to Visual Studio Gallery?
We get the "Value can not be null" #212 all the time, and it would be nice if I could tell the team members just to pull the latest version from Visual Studio Gallery
Andrew Arnott
@AArnott
I confess, after seeing so much action on NuProj in so little time, I've been afraid to review all the github notifications for it for lack of time.
Pavol Kovalik
@kovalikp
Well, I actually fixed the issue with resolving references in CPS, so it might be good idea release new version.
Andrew Arnott
@AArnott
awesome. :)
Andrew Arnott
@AArnott
going through my backlog of nuproj notifications now.
Christoph Lindemann
@ChristophLindemann
@kovalikp & @AArnott any closer to releasing a new version?
Andrew Arnott
@AArnott
@ChristophLindemann No. I'm hoping to have time before new year's. But I can't guarantee anything at this point.
Yann Duran
@yannduran
hi guys. i love the idea of this project, but correct me if I'm wrong but there has to be a separate nuproj for each class library as a nuget package?
Yann Duran
@yannduran

I've been using Nuget.Package.Builder (a Nuget package by Lars Skovlund) which turns any class library project into a Nuget packager producer for years. So you only have one project, not two. Is there any benefit of NuProj over Package Builder?

His approach adds a bunch of MSBuild code via a .targets file. I really like the purer approach that NuProj takes, but its a pity that it needs that extra project for every Nuget package (unless I'm woefully misunderstanding something)

Oh, and for open source stuff I've been using AppVeyor to create and push the packages

Zihao Chen
@amat27
Hi guys. is there a way to add empty dependency group in nuproj?
Andrew Arnott
@AArnott
@amat27 Yes. it involves adding a nuspec file to your nuproj project that nuproj's build then uses as a template for the nuspec it constructs.
@yannduran: each nuproj produces one nupkg (or two, if you build a symbols package). So if you have a collection of class libraries, you can either bundle them up in a single package with one nuproj, or you can create a nuproj for each class library to get one for each (or anywhere in between).
If you always package one dll per nupkg and you're happy with other csproj injection techniques to add packaging to a library project, that's fine. NuProj is targeting folks who want more control of packaging and its contents.
With the VS2017 .NET Core project type, libraries know how to package themselves and that may be a great option for you as well, but I personally can't migrate several of my packages to it because it's not flexible enough, so I stick with NuProj for those.
Yann Duran
@yannduran
@AArnott Thanks Andrew!
Pavol Kovalik
@kovalikp
@AArnott about that PowerShell - MSBuild integration I mentioned some while ago: got it working
Andrew Arnott
@AArnott
cool. I remember a couple times since you talked about it, wishing it was around.
Pavol Kovalik
@kovalikp
Pavol Kovalik
@kovalikp
@AArnott are the XamlPropertyRule items required to be compiled? I just noticed when you moved .xaml files to shared project, you changed XamlPropertyRule items to None, but it did not seem to have any adverse effect.
Andrew Arnott
@AArnott
The change to the item type was probably an oversight on my part. IIRC XamlPropertyRule causes code generation to run for each rule. If I got away with the mistake, I guess we didn't depend on the code generation -- although we should, in order to avoid magic strings in our code.
Pavol Kovalik
@kovalikp
my thought process here:
I want to deprecate support for 2013/2015 and only release for 2017
get rid of the MSI, keep only 2017 .vsix, update refences to MSBuild 15.0
Andrew Arnott
@AArnott
I'm OK with that. We can keep a vs5015 branch in case we need to service it.
Pavol Kovalik
@kovalikp
which is significant breaking change, so making NuProj.2017, NuProj.Common.2017 would make a sense
but I didn't realize you were waiting for me to finish #286
so, how about this:
Pavol Kovalik
@kovalikp
could you release current master, that should at least have that Project reference error that we have like 10 different bugs for
then merge #286, I'll remove support for old VS, and then release .vsix and and updated packages for MSBuild 15.0
not dealing with 2013/2015 should make easier to figure out, what's up with this https://github.com/nuproj/nuproj/issues/266#issuecomment-289991188
Andrew Arnott
@AArnott
but I didn't realize you were waiting for me to finish #286
Oh dear
Sounds like a plan
Pavol Kovalik
@kovalikp
least have fixed that Project reference