@AArnott are the XamlPropertyRule items required to be compiled? I just noticed when you moved .xaml files to shared project, you changed XamlPropertyRule items to None, but it did not seem to have any adverse effect.
Andrew Arnott
@AArnott
The change to the item type was probably an oversight on my part. IIRC XamlPropertyRule causes code generation to run for each rule. If I got away with the mistake, I guess we didn't depend on the code generation -- although we should, in order to avoid magic strings in our code.
Pavol Kovalik
@kovalikp
my thought process here: I want to deprecate support for 2013/2015 and only release for 2017
get rid of the MSI, keep only 2017 .vsix, update refences to MSBuild 15.0
Andrew Arnott
@AArnott
I'm OK with that. We can keep a vs5015 branch in case we need to service it.
Pavol Kovalik
@kovalikp
which is significant breaking change, so making NuProj.2017, NuProj.Common.2017 would make a sense
but I didn't realize you were waiting for me to finish #286
so, how about this:
Pavol Kovalik
@kovalikp
could you release current master, that should at least have that Project reference error that we have like 10 different bugs for
then merge #286, I'll remove support for old VS, and then release .vsix and and updated packages for MSBuild 15.0
but I didn't realize you were waiting for me to finish #286
Oh dear
Sounds like a plan
Pavol Kovalik
@kovalikp
least have fixed that Project reference
Christoph Lindemann
@ChristophLindemann
Hey guys
We would really appreciate, like really really, if you could do a service release for Visual Studio 2015
so that we can get rid of the "Value can not be null" #212 problem, which you fixed in oktober, but not released yet
before you abandon VS2015 for VS2017
We are not able to upgrade our toolchain to VS2017 just yet, as we are still missing some other tools that not work with 2017 yet
_
Immo Landwerth
@terrajobst
@kovalikp I want to deprecate support for 2013/2015 and only release for 2017 get rid of the MSI, keep only 2017 .vsix, update refences to MSBuild 15.0
Makes sense to me too.
How are we going to handle the VSIXs? Are there separate VSIXs for 2015 and 2017? I assume the answer is yes, otherwise we cannot support side-by-side servicing.
How are we going to handle this in the NuGet package?
Pavol Kovalik
@kovalikp
@terrajobst in #286 there is MSI containing 2013 + 2015 VSIXs, while 2017 VSIX is standalone
so this is what I would do: 1) release from current master, nuproj.msi, nuproj.nupkg and nuproj.common.nupkg as 0.12.X
2) branch it
3) change dependencies to MSBuild 15.0, consolidate code to 2017 VSIX, get rid of MSI and 2013/2015 VSIXs
4) release nuproj.2017.vsix, nuproj.nupkg and nuproj.common.nupkg as 0.13.X
Pavol Kovalik
@kovalikp
5) service 2013/2015 from branch as 0.12.Y (if that ever happen)
Andrew Arnott
@AArnott
I've finally shipped the vs2015 branch to nuget.org and the VS Marketplace. It's version 0.11.28-beta. @kovalikp Please feel free to merge your PR when ready.
Andrew Arnott
@AArnott
I've also bumped the version in master branch from 0.11.x to 0.20.x.
Yongli Chen
@saiyan86
Hey guys! How do I include vc runtime to the nuproj?