nx-dotnet/community

Michel van den Berg

@promontis

I tried to do cross-env NX_VERBOSE_LOGGING=true nx dep-graph, but it doesn't print anything more

Michel van den Berg

@promontis

Ok, I’ve debugged the yarn task and this is what I’m getting…

"Source project Brisker.MP.Search.Api.Local does not have a file: Search/Brisker.MP.Search.Api.Local/Brisker.MP.Search.Api.Local.csproj”

Michel van den Berg

@promontis

ok, the problem is here...

 const fileData = source.data.files.find((f) => f.file === sourceProjectFile);
        if (!fileData) {
            throw new Error(`Source project ${sourceProjectName} does not have a file: ${sourceProjectFile}`);
        }

source.data.files is an empty array

and it is trying to find the .csproj

Craigory V Coppola

@AgentEnder

Hey, looking at it that seems to be throwing within the addExplicitDependency method from @nrwl/devkit. What does you project.json / workspace.json configuration for the project look like? It seems like Nx doesn't think your project has any files within it.

Specifically, the root / src root

Michel van den Berg

@promontis

yeah, the files array is empty

{
    "version": 2,
    "projects": {
      "Brisker.MP.Search.Api": {
        "root": "Search/Brisker.MP.Search.Api/",
        "projectType": "application",
        "sourceRoot": "Search/Brisker.MP.Search.Api/",
        "targets": {
          "build": {
            "executor": "@nx-dotnet/core:build",
            "outputs": ["{options.output}"],
            "options": {
              "output": "dist/apps/Brisker.MP.Search.Api",
              "configuration": "Debug"
            },
            "configurations": {
              "production": {
                "configuration": "Release"
              }
            }
          },
          "serve": {
            "executor": "@nx-dotnet/core:serve",
            "options": {
              "configuration": "Debug"
            },
            "configurations": {
              "production": {
                "configuration": "Release"
              }
            }
          },
          "lint": {
            "executor": "@nx-dotnet/core:format"
          }
        }
      },
      "Brisker.MP.Search.Api.Local": {
        "root": "Search/Brisker.MP.Search.Api.Local/",
        "projectType": "application",
        "sourceRoot": "Search/Brisker.MP.Search.Api.Local/",
        "targets": {
          "build": {
            "executor": "@nx-dotnet/core:build",
            "outputs": ["{options.output}"],
            "options": {
              "output": "dist/apps/Brisker.MP.Search.Api.Local",
              "configuration": "Debug"
            },
            "configurations": {
              "production": {
                "configuration": "Release"
              }
            }
          },
          "serve": {
            "executor": "@nx-dotnet/core:serve",
            "options": {
              "configuration": "Debug"
            },
            "configurations": {
              "production": {
                "configuration": "Release"
              }
            }
          },
          "lint": {
            "executor": "@nx-dotnet/core:format"
          }
        }
      }
    },
    "cli": {
      "defaultCollection": "@nrwl/workspace"
    }
  }

this is the workspace.json

tried different root/sourceRoot values

started out with Search/Brisker.MP.Search.Api.Local

I do see that the code is parsing the actualy csproj file

so it can find it!

only the files array is empty

Craigory V Coppola

@AgentEnder

Yeah, nx-dotnet is finding it but Nx itself is reporting empty files. I'm not sure why that would be happening at first glance. Do you care to open an issue on the gh for this? If you can make a minimal repro that would be great, but if not its no worry :smile:

Michel van den Berg

@promontis

do you perhaps know where the files are being add?

in NX itself

Craigory V Coppola

@AgentEnder

Yeah, thats not something that we do. I'll have to glance over the Nx source and find it.

Michel van den Berg

@promontis

I can’t really make a minimal repro I think… what I can do is debug that NX source that should add the files

I tried with a NX generated app, and there it works

so I have no idea how to make a minimal repro :sweat_smile:

Craigory V Coppola

@AgentEnder

Ah, are you migrating a project created through VS / some other tooling into nx-dotnet? That is a case that should work, but is not covered by our tests.

Michel van den Berg

@promontis

yeah

migrating an existing project

https://github.com/nrwl/nx/blob/7c3f0f76cc6d79d32d0d9c80ae40c5cdb14f2bcf/packages/workspace/src/utilities/assets.ts#L33

is this it?

Craigory V Coppola

@AgentEnder

I plan on adding some schematic to make that easier, but like I said it should work in the meantime. The nx source you should look at is https://github.com/nrwl/nx/blob/master/packages/workspace/src/core/file-utils.ts#L277

Michel van den Berg

@promontis

ah great!

let me try to debug it

ah found it

Craigory V Coppola

@AgentEnder

Whats going on?

Michel van den Berg

@promontis

you actually have to put everything in either an app folder or on lib folder hehe

Craigory V Coppola

@AgentEnder

Ah, yeah that can be the case depending on your nx setup. An option to get around that is to set your configuration to have apps: "" in nx.json

Or libs: ""

Michel van den Berg

@promontis

ah great… was just looking for that config

was hoping that it wasn’t hard coded haha

Craigory V Coppola

@AgentEnder

Yeah, here is how its setup in nx itself https://github.com/nrwl/nx/blob/master/nx.json

Lines 51-52

Michel van den Berg

@promontis

yeay, it works!

Craigory V Coppola

@AgentEnder

Excellent, feel free to let me know if you encounter any further issues.

Michel van den Berg

@promontis

I will :)

thnx for helping out! :beers:

Craigory V Coppola

@AgentEnder

Sure, no worries

Michel van den Berg

@promontis

Quick question… you can’t configure the layout algoritm of the dependency graph right?

It is now outputting like this, and the box is in the way

Michel van den Berg

@promontis

nevermind… nrwl/nx#4553

Craigory V Coppola

@AgentEnder

Yeah, theres not anything we can do at the plugin-layer on that

Where communities thrive

People

Repo info

Activity